Commit Graph
17505 Commits
Author SHA1 Message Date
James Byers d0931025dd expose --listen* command line arguments in RPM init script 2013-06-14 10:11:37 -07:00
Christoph Kutzinski 93c31be1b7 [FIXED JENKINS-18351] file descriptor leak while fingerprinting 2013-06-14 18:36:08 +02:00
Jesse Glick 0e1bc560ae [FIXED JENKINS-18352] Retroactively filing. 2013-06-14 11:00:30 -04:00
Jesse Glick 98cf52b699 Slave.remoteFS is intended to be an absolute path.
(Could consider throwing IAE if it does not appear to be.
Cannot easily call getRootPath().absolutize() since that requires a connection.)
2013-06-13 09:41:19 -04:00
Kohsuke Kawaguchi 63aba90db1 Introduced a new permission to control whether a given slave can accept a build.
... as per the discussion in the dev list

Related: https://groups.google.com/forum/?fromgroups#!topic/jenkinsci-dev/TMm-h6Hnb6Q
2013-06-13 15:42:00 +03:00
Kohsuke Kawaguchi 513a45b309 Added QueueListener extension point
This can track items as they go through the queue.
2013-06-13 15:42:00 +03:00
Kohsuke Kawaguchi 7b2541d4db doc fix 2013-06-13 15:42:00 +03:00
Kohsuke Kawaguchi f984e8298d doc fix 2013-06-13 15:41:59 +03:00
Jesse Glick c2756ecc33 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-06-13 06:57:52 -04:00
Jesse Glick 984c4cf44e Setting a nonempty contextPath turned up a couple problems in the test harness; goTo must be given a relative path.
https://ci.jenkins-ci.org/job/jenkins_main_trunk/2602/testReport/junit/hudson.model/JobTest/readPermission/
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:47898/jenkins//j_acegi_security_check
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:549)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:333)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:357)
	at com.gargoylesoftware.htmlunit.html.HtmlForm.submit(HtmlForm.java:196)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:1776)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:1788)
	at hudson.model.JobTest.readPermission(JobTest.java:182)
2013-06-13 06:57:10 -04:00
Olivier Lamy 4c0bb61a07 Revert "changelog entry for [JENKINS-18326]"
This reverts commit 9fb2a02530.
2013-06-13 16:55:07 +10:00
Olivier Lamy d2212757c7 Revert "[JENKINS-18326] add maven site support for nested submodules"
This reverts commit f460e1e817.
2013-06-13 16:54:38 +10:00
Olivier Lamy 9fb2a02530 changelog entry for [JENKINS-18326] 2013-06-13 14:50:08 +10:00
Olivier Lamy 529f590ebb Merge pull request #805 from leachbj/master
[JENKINS-18326] add maven site support for nested submodules
Thanks!
2013-06-12 21:48:33 -07:00
Bernard Leach f460e1e817 [JENKINS-18326] add maven site support for nested submodules 2013-06-13 13:09:41 +10:00
Jesse Glick bff177dfa1 Deprecating HudsonTestCase. 2013-06-12 16:23:11 -04:00
Jesse Glick 1ed4e4b80f Set a nonempty context path to strengthen tests, just like we do for hpi:run & hudson-dev:run. 2013-06-12 16:07:39 -04:00
Jesse Glick cc26f23ec4 [JENKINS-16845] Properly report the IllegalStateException, rather than throwing an NPE producing the exception message.
java.lang.NullPointerException
	at hudson.model.Run.getFullDisplayName(Run.java:711)
	at hudson.model.Run.toString(Run.java:706)
	at java.lang.String.valueOf(Unknown Source)
	at java.lang.StringBuilder.append(Unknown Source)
	at hudson.model.AbstractBuild.getPreviousBuild(AbstractBuild.java:218)
2013-06-12 15:18:15 -04:00
Jesse Glick acf8884f42 Was missing Javadoc. 2013-06-12 11:44:21 -04:00
Kohsuke Kawaguchi 4398a60bcb wrong method was implemented 2013-06-12 18:33:45 +03:00
Kohsuke Kawaguchi a821d859bc this sentence was already moved to Queue.Task.getDefaultAuthentication() 2013-06-12 18:33:45 +03:00
Kohsuke Kawaguchi a452e5ff26 Handshaking should fix on the encoding.
See f8916a839c5a7bfe6d0de100a33cf23de33de6e4 for the corresponding change in the remoting.

Since the error messages only use ASCII
2013-06-12 18:33:45 +03:00
Jesse Glick 25eff9006f getInjector introduced in 1.433. 2013-06-12 11:31:08 -04:00
Kohsuke Kawaguchi e3a1a78f6d ProjectAuthenticator -> QueueItemAuthenticator
As Jesse pointed out, contextual information is often useful in authenticating the build, which means we need to take Queue.Item (initially AbstractBuild was the parameter, which provided the context, and I failed to accommodate that in transition to AbstractProject.)

To still allow Queue.Tasks to provide a meaningful value fallback to Queue.Task.getDefaultAuthentication() as opposed to hard code it to ACL.SYSTEM. This allow plugins like remote-terminal-access to supply a meaningful secure value without forcing a configuration change to the user.
2013-06-12 17:20:17 +03:00
Kohsuke Kawaguchi ec91933fc3 Minor edits based on review comments 2013-06-12 16:53:09 +03:00
Kohsuke Kawaguchi b7027563fe how Jesse finds all the typos, I have no idea 2013-06-12 16:40:50 +03:00
Kohsuke Kawaguchi 48be96865f forgot to update this as well 2013-06-12 16:39:06 +03:00
Kohsuke Kawaguchi 2d09a0e54b [FIXED JENKINS-18285] Merge the feature branch 2013-06-12 13:56:35 +03:00
Kohsuke Kawaguchi b89387cfed Not shipping any implementation out of the box.
... because the fallback behaviour is sufficient for compatibility. In this way, we can phase in this feature more slowly
2013-06-12 13:52:13 +03:00
Kohsuke Kawaguchi 5e78a17fab a test case that verifies whether the queue honors the permissions 2013-06-12 13:08:47 +03:00
Kohsuke Kawaguchi 6fa5b936d7 wrong package name 2013-06-12 13:08:47 +03:00
Kohsuke Kawaguchi 931777f0c8 added a test case for ProjectAuthenticator 2013-06-12 13:08:47 +03:00
Kohsuke Kawaguchi e5b834921c IntelliJ complains about this. Not sure if it's a real problem 2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi aa6dd095a4 Grouping related messages together 2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi 7392d3f0d1 tweaking the wording a bit 2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi ada4a21607 Have the scheduling algorithm honor the permissions 2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi 6d8723a985 Instead of authenticating Executor, authenticating AbstractProjects.
This is necessary because a part of the access control is determining which Executor can accept which Queue.Task, so we can't have the authenticator taking Executor as a parameter.

I briefly thought about changing ExecutorAuthenticator to authenticate Queue.SubTask, but doing this intelligently is very difficult as an authenticator wouldn't really be able to make any sensible decisions unless it checks for specific subtypes (think of the dist-fork plugin and the remote terminal access plugin that implements Queue.Task.) So I made the change to have it accept AbstractProject, which is really the primary use case anyway.

The relevant classes are renamed to better represent what it does now.
2013-06-12 13:08:45 +03:00
Kohsuke Kawaguchi a3bf8c7297 run the build under the designated Authentication objec 2013-06-12 13:08:45 +03:00
Kohsuke Kawaguchi 570197fc93 PersistedList now implements List, not just Iterable.
This required bridge method injector that maps boolean->void
2013-06-12 13:08:45 +03:00
Jesse Glick 3c01366e0b [FIXED JENKINS-16974] Unsafe to define a function in <script> without a generated name, as it could clash with functions defined in unrelated *.jelly that happen to included in the same page. 2013-06-11 17:48:22 -04:00
Kohsuke Kawaguchi e42149faa9 Added basic abstraction for authenticating Executors 2013-06-11 16:29:05 +01:00
Jesse Glick 609c4f8df0 [JENKINS-17451] Noting. 2013-06-11 08:59:29 -04:00
Jesse Glick b64d3dbfb7 Merge pull request #802 from Vlatombe/JENKINS-17451
[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven
2013-06-11 05:58:19 -07:00
Jesse Glick dedb24ef03 Merge branch 'master' into JENKINS-14362-jzlib 2013-06-11 08:00:27 -04:00
Jesse Glick 23eddfa145 Stapler ≥2.11 to use 2013-06-11 08:00:12 -04:00
Jesse Glick 47b97cb67f back to 1.513 2013-06-11 07:59:10 -04:00
Jesse Glick 307bef7c07 Merge commit '9d8ee80' into rc 2013-06-11 06:56:21 -04:00
Jesse Glick cc2a91bdbd Merge commit '9d8ee80' 2013-06-11 06:55:41 -04:00
Jesse Glick 9d8ee801f2 Fixed regression in AbstractItem.getShortUrl from e50f0f5 caught by MatrixTest.testSpaceInUrl.
https://ci.jenkins-ci.org/job/jenkins_main_trunk/2590/testReport/junit/hudson.matrix/MatrixTest/testSpaceInUrl/
2013-06-11 06:54:52 -04:00
Oliver Gondža 7ac7967f55 [FIXED JENKINS-18282] Optionally override name from XML in create-node CLI command 2013-06-11 12:31:37 +02:00