Commit Graph
17505 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 39acb350c1 make this row always stick to the top 2013-04-19 12:05:29 -07:00
Kohsuke Kawaguchi 9b072294af Added 'sorttop' class to make rows stick to the top.
Plus more simplifications
2013-04-19 12:03:49 -07:00
Kohsuke Kawaguchi d5d4b45ef7 refactored to eliminate duplication.
Using prototype.js to simplify the code
2013-04-19 11:55:28 -07:00
Kohsuke Kawaguchi 8bcc07326d avoid global names 2013-04-19 10:22:37 -07:00
Kohsuke Kawaguchi 368d8c7394 Don't let the error icon get clipped when the text is short.
On Chrome (and possibly others), an inline element like span doesn't enlarge
its size to cover its content, so the 1px place holder wasn't taking effect.

To ensure the minimum height of 16px, make it an inline-block element. I'm
not entirely sure how an inline-block element with no fixed width would behave,
but with a bit of casual testing, the text inside seems to wrap OK.
2013-04-19 10:11:28 -07:00
Kohsuke Kawaguchi 22d1175ac6 Show when the monitor data was obtained 2013-04-18 19:21:56 -07:00
Kohsuke Kawaguchi 58cb75fd28 Improved the robustness in the node monitoring
- Improved logging and recovery for the Record thread that dies in the middle.
- Recover from failing to monitor one node and move on to the next.
2013-04-18 18:54:15 -07:00
Kohsuke Kawaguchi 5c95be34e4 don't let a programming error kill this thread 2013-04-18 18:39:18 -07:00
Kohsuke Kawaguchi e131764850 formatting improvements 2013-04-18 18:09:58 -07:00
Kohsuke Kawaguchi b1f0a7be75 Adding more diagnostics logging 2013-04-18 15:36:02 -07:00
Kohsuke Kawaguchi 7578aa93ad expose the display name of the build as environment variable 2013-04-18 10:38:20 -07:00
redlab ca7f4e682c also testing the removal of build if LogRotator is configured to discard
old builds and not only artifacts (Not needed for the issue, but an
extra test is not a luxury )
2013-04-18 08:58:30 +02:00
Kohsuke Kawaguchi 070f74f667 making this extension point more discoverable 2013-04-17 16:25:47 -07:00
Kohsuke Kawaguchi 3abc50253a 46b6bee16e left this comment that's no longer meaningful. 2013-04-17 13:52:35 -07:00
Kohsuke Kawaguchi e36a075436 Improve the error message to indicate which file had failed to parse.
This allows administrator to remove this problematic file.
2013-04-17 13:51:17 -07:00
Kohsuke Kawaguchi 3f4d82a1a3 Adding a new item should cause the dependency graph recalculation.
For example, a new job might have a trigger setting to begin with,
or it might resolve a reference that was previously failing (for
example, 'up' job referring to 'down' job and the 'down' job is newly
created.)
2013-04-17 09:55:12 -07:00
Kohsuke Kawaguchi 46b6bee16e pointless double invocation 2013-04-17 09:08:52 -07:00
redlab 2a0bd7eebd add documentation to testcase. 2013-04-17 14:02:46 +02:00
redlab c8f73d0015 adds test that looks in jobs archive with 2 builds when LogRotator set as build discarder with settings to keep only 1 build with artifacts, test searches for jars in archive for build one and build two expecting no jars in build 1 and expecting jars in build 2 2013-04-17 12:21:09 +02:00
Kohsuke Kawaguchi 5f806d8f63 Marked various mode-link as inside.
Observations:

- When marked inside, moving the mouse to <A> and clicking the context menu becomes easier,
  because you can move the mouse toward the hot spot area and it'll activate.
  Otherwise you have to move the mouse over to <A>, then move the mouse on the side, click it,
  then click the menu, which adds cognitive stress.

- Marking model link as inside creates an empty space to the right of <A>, which looks
  odd if hyperlinks appear inline or if some other text follows it.

Given that, my guiding principle for this change is:

- any model link that is the last child of a block element gets marked as inside
- I've adjust a few text to get rid of the single-letter training text after a model link,
  like "(#3)" to "- #3"
- If another inline element follows a model link, leave it as is.
  This does create an ugly overlap.
2013-04-16 20:09:09 -07:00
Kohsuke Kawaguchi e6ee4abc84 Forgot to commit this image. 2013-04-16 19:28:15 -07:00
Kohsuke Kawaguchi 63b3c935ef Use transparent background in the title logo.
This prevents one pixel height difference between the logo and the title
bar background.
2013-04-16 19:27:36 -07:00
Kohsuke Kawaguchi 24aa5a54be adding more ModelObjectWithChildren implementations 2013-04-16 18:59:15 -07:00
Kohsuke Kawaguchi 304ffabed2 implemented ModelObjectWithChildren in various model object implementations 2013-04-16 18:50:33 -07:00
Kohsuke Kawaguchi c77baaae07 improving the sample to cover ModelObjectWithChildren 2013-04-16 18:07:20 -07:00
Kohsuke Kawaguchi e6da4f7773 BUG: z-index of the context menu must be bigger than that of the menu selector.
And both values need to be still bigger than the z-index of the top sticker
since the breadcrumb bar is on the top-sticker
2013-04-16 17:58:46 -07:00
Kohsuke Kawaguchi 89621a90d6 BUG: z-index of the context menu must be bigger than that of the menu selector 2013-04-16 17:52:27 -07:00
Kohsuke Kawaguchi b2cd4120ec Breadcrumb is reworked to show descendants to provide additional navigational shortcuts.
Object that implements ModelObjectWithChildren can expose its children in the breadcrumb.
2013-04-16 17:51:15 -07:00
Kohsuke Kawaguchi 0f6b02bd18 Modifying the breadcrumb context menu so that it also requires clicking 'v'. 2013-04-16 17:10:09 -07:00
Kohsuke Kawaguchi 69835e0f8a Additional 'inside' class allows pre-allocation of the context menu space 2013-04-16 16:57:16 -07:00
Kohsuke Kawaguchi 8b8ea1c77b Elements passed in are already extended via Prototype 2013-04-16 16:48:01 -07:00
Kohsuke Kawaguchi 9cddeba7b2 [JENKINS-13995]
Made the 'v' icon bigger to increase the hit test area, and improved the alignment
logic so that the text and the 'v' icon gets vertically aligned.
2013-04-16 16:43:27 -07:00
Kohsuke Kawaguchi 11bc7ce933 [JENKINS-13995]
Now that the context menu is open only when clicking 'v', the tooltip on model link should
be displayed as soon as the mouse hovers over it.
2013-04-16 16:00:46 -07:00
Kohsuke Kawaguchi 5aa4af75c2 we want to prefer *.jpi over *.hpi, but the code was other way around 2013-04-16 13:38:54 -07:00
Kohsuke Kawaguchi 38eec41601 Simplification without changing the semantics 2013-04-16 12:56:37 -07:00
Kohsuke Kawaguchi ff7f272a4b Fixing StringIndexOutOfBoundsException
I'm not really sure what this code is doing or what ID is supposed to look like. So this is just a minimum-intrusion change to avoid an exception.

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1875)
        at hudson.tasks.junit.PackageResult.findCorrespondingResult(PackageResult.java:86)
        at hudson.tasks.junit.TestResult.findCorrespondingResult(TestResult.java:295)
        at hudson.tasks.test.AbstractTestResultAction.findCorrespondingResult(AbstractTestResultAction.java:183)
        at hudson.tasks.test.TestResult.getResultInBuild(TestResult.java:162)
        at hudson.tasks.junit.History.getList(History.java:82)
        at hudson.tasks.junit.History$1.createDataSet(History.java:105)
        at hudson.tasks.junit.History$GraphImpl.createGraph(History.java:169)
        at hudson.util.Graph.render(Graph.java:87)
        at hudson.util.Graph.doPng(Graph.java:98)
2013-04-16 12:56:37 -07:00
Jesse Glick 5ee9ab5451 Merge pull request #760 from mpapo/JENKINS-17416
JENKINS-17416 - Improve Wipe Out Workspace label
2013-04-16 12:48:32 -07:00
Kohsuke Kawaguchi 72fbcbfcea the trunk is toward 1.513-SNAPSHOT 2013-04-16 12:44:28 -07:00
Kohsuke Kawaguchi 1c35f3638f creating an RC branch 2013-04-16 12:44:26 -07:00
Kohsuke Kawaguchi 084da443e1 [JENKINS-13995]
Added logging more liberally, and fixed the problem.
The root cause was that when the mouse enters a hot spot, I wasn't cancelling the previous delayed hide timer.

This fix eliminates the need for the hack in the hide method where I was testing if the mouse was still over the hotspot.
2013-04-16 12:04:34 -07:00
Kohsuke Kawaguchi 6fb7a50d07 [JENKINS-13995]
Fixed a bug where the context menu anchor 'v' disappears even when the mouse is still over a model link.
2013-04-16 12:03:47 -07:00
Kohsuke Kawaguchi d9ec2ce7f3 matching the size with font size since the context menu is most likely aligned with text 2013-04-16 12:03:47 -07:00
Kohsuke Kawaguchi 7547681a24 need to prefer linked files over archives.
This regression appeared to be introduced in 32d5c23.
2013-04-16 12:03:47 -07:00
Michael Pailloncy 15cc52276e JENKINS-17416 - Improve Wipe Out Workspace label 2013-04-16 19:59:32 +02:00
Jesse Glick 293403f3d1 [JENKINS-17637] Noting. 2013-04-16 12:04:53 -04:00
Jesse Glick f8ce8c6e5a Removed junk from cdee827d55. 2013-04-16 11:55:58 -04:00
Nicolas De loof cdee827d55 restore backward compatibility
d3096819f6 changed constructor signature. Add a backward-compatible one
2013-04-16 13:52:23 +02:00
redlab d4459d9d0f As this is my first look inside Jenkins codebase I not sure it's correct
but perhaps artifacts for modulebuilds should be deleted just as logs
are deleted. see https://issues.jenkins-ci.org/browse/JENKINS-17508
I did not fully test it yet, all unit tests ran fine, but didn't succeed
to run jobs inside Jenkins, due to classloader issues while running
Jenkins in Jetty, to verify deletion
2013-04-15 20:59:06 +02:00
Kohsuke Kawaguchi a9edf6a421 merged back the RC branch 2013-04-14 19:04:41 -07:00
Kohsuke Kawaguchi 5ea3d54067 updated changelog as a part of the release 2013-04-14 19:04:38 -07:00