This patch makes standard post-build action refuse to let you configure a downstream project you cannot currently build.
The one from parameterized-trigger will show an error in the configure screen but still lets you save the configuration; needs an analogous patch to that plugin.
Does not yet protect against POSTing config.xml with the trigger.
(cherry picked from commit 757bc8a539)
Conflicts:
core/src/main/java/hudson/model/Descriptor.java
- My second patch, with whitelisted XPath values and forbidden JSONP.
- Disabling JSONP altogether for REST API (unless explicitly allowed).
- Forbid primitive XPath result sets by default.
- Refuse to serve _crumb=123456 as this could (very hypothetically) be exploited.
(cherry picked from commit f4af9b1ab4)
Conflicts:
core/src/main/java/hudson/model/Api.java
- Use the proper block cipher mode.
Or else the information about the plain text still ends up revealing as a pattern without the attacker knowing the key.
- No need to hide SLAVE_SECRET from the encrypted payload.
jnlpMac is needed to decrypt this payload to begin with, so there's no point in hiding it. This simplifies the code a little bit.
- Using a newer slave installer that uses the -secret option
(cherry picked from commit f4496df19e)
- Use the proper block cipher mode.
Or else the information about the plain text still ends up revealing as a pattern without the attacker knowing the key.
- No need to hide SLAVE_SECRET from the encrypted payload.
jnlpMac is needed to decrypt this payload to begin with, so there's no point in hiding it. This simplifies the code a little bit.
- Using a newer slave installer that uses the -secret option
purged duplicated translations for GlobalCrumbIssuerConfiguration
("Prevent Cross Site Request Forgery exploits").
Changed property name "Crumb" to "Crumbs" because this is the value that the existing translations actually use.
Removing old static field, which was not friendly to tests, especially multithreaded runners.
Cleaned up existing tests to use updateDirectly rather than POSTing raw JSON.