Commit Graph
17505 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 332b4e10e2 the trunk is toward 1.485-SNAPSHOT 2012-09-23 20:56:02 -07:00
Kohsuke Kawaguchi 5ffeee81f8 creating an RC branch 2012-09-23 20:55:57 -07:00
Kohsuke Kawaguchi 268d9c8350 merged back the RC branch 2012-09-23 20:45:02 -07:00
Kohsuke Kawaguchi 936cc085ed updated changelog as a part of the release 2012-09-23 20:44:59 -07:00
Kohsuke Kawaguchi 70abc95d1d toward the next release 2012-09-23 20:12:51 -07:00
Kohsuke Kawaguchi c3958393cd releasing a new plugin parent POM 2012-09-23 20:12:38 -07:00
Kohsuke Kawaguchi 788a663ddf updated changelog for release 2012-09-23 20:12:38 -07:00
Kohsuke Kawaguchi dcc63c261c [maven-release-plugin] prepare for next development iteration 2012-09-23 19:57:17 -07:00
Kohsuke Kawaguchi 5c1374ab51 [maven-release-plugin] prepare release jenkins-1.483 jenkins-1.483 2012-09-23 19:57:17 -07:00
Vojtech Juranek 823cda1a1c Added changelog for 452f4f1c74 2012-09-22 11:48:28 +02:00
Vojtech Juranek 452f4f1c74 [Fixed JENKINS-15277] Check permissions before showing config page as we did in all other cases 2012-09-22 11:46:04 +02:00
Kohsuke Kawaguchi 4b4d35d241 Missing @since 2012-09-21 15:59:28 -07:00
Kohsuke Kawaguchi 550afcc9d7 simplification 2012-09-21 15:39:53 -07:00
Kohsuke Kawaguchi 7917ccb723 reducing variable scope 2012-09-21 15:39:26 -07:00
Kohsuke Kawaguchi 1f38518f53 Fixing concurrency problems.
The following bug report from olamy made me look hard at the code, but I'm not spotting an obvious problem.
The binary search algorithm here seems to always satisfy the invariant of 0<=lo<=pivot<=hi<=size, so I can't understand how lo==size+1 at the end, for this to happen.

So the only thing I can think of is concurrency related, which is indeed buggy --- we are editing indices after they are set to instance fields, which violates the copy-on-write semantics. This commit fixes that.

Sep 21, 2012 9:38:35 PM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading job MahoutQM
java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
	at java.util.ArrayList.rangeCheck(ArrayList.java:604)
	at java.util.ArrayList.get(ArrayList.java:382)
	at jenkins.model.lazy.SortedList.get(SortedList.java:60)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:381)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.newestBuild(AbstractLazyLoadRunMap.java:243)
	at hudson.model.AbstractProject.getLastBuild(AbstractProject.java:998)
	at hudson.maven.AbstractMavenProject.createTransientActions(AbstractMavenProject.java:184)
	at hudson.model.AbstractProject.updateTransientActions(AbstractProject.java:665)
	at hudson.maven.MavenModule.updateTransientActions(MavenModule.java:411)
	at hudson.model.AbstractProject.onLoad(AbstractProject.java:299)
	at hudson.maven.MavenModule.onLoad(MavenModule.java:236)
	at hudson.model.Items.load(Items.java:221)
	at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:99)
2012-09-21 15:38:14 -07:00
Kohsuke Kawaguchi de15893cc4 tweaking the co-efficient 2012-09-21 14:57:07 -07:00
Kohsuke Kawaguchi 2bc20ad2c7 don't do this by default 2012-09-21 13:35:11 -07:00
Kohsuke Kawaguchi c32f006fe4 Allow AbstractBuilds to be garbage collected (and reloaded lazy later) 2012-09-21 12:28:26 -07:00
Olivier Lamy 4c7e39d47c Merge pull request #572 from alfonsocora/master
Fix spanish translation for 'build now'
Thanks!
2012-09-21 10:41:01 -07:00
Alfonso Cora e785437bde Fix spanish translation for 'build now' 2012-09-21 14:35:10 -03:00
Jesse Glick 23ade1cda5 [FIXED JENKINS-15271] NPE in <code>MatrixProject.onLoad</code>. 2012-09-21 12:52:07 -04:00
Kohsuke Kawaguchi 9e6d8f71ce build numbers might exhibit some uniformity that makes it problematic with %4==0, so switching to random.
The average memory saving should be about the same.
2012-09-21 09:12:50 -07:00
Jesse Glick ec3005e1a0 /people is now a 404.
https://ci.jenkins-ci.org/job/jenkins_main_trunk/1943/testReport/junit/hudson.model/ViewTest/testAllImagesCanBeLoaded/
2012-09-21 09:57:17 -04:00
Jesse Glick 61034f7dcf Test failure.
https://ci.jenkins-ci.org/job/jenkins_main_trunk/1943/testReport/junit/org.jvnet.hudson.test/JellyTestSuiteBuilder$JellyCheck/lib_layout_progressiveRendering_jelly/
2012-09-21 09:55:19 -04:00
Kohsuke Kawaguchi a36223cc7c [FIXED JENKINS-15178] Merge branch 'pull-567' 2012-09-20 17:12:29 -07:00
Kohsuke Kawaguchi 454d0f2b87 Merge branch 'pull-570' 2012-09-20 17:10:06 -07:00
Kohsuke Kawaguchi 90d463b6a2 clarified a bit 2012-09-20 17:09:56 -07:00
Kohsuke Kawaguchi 0b35a03505 Pointless use of eval() 2012-09-20 17:07:17 -07:00
Kohsuke Kawaguchi e6f3ec4427 Took care of i18n 2012-09-20 16:57:31 -07:00
Kohsuke Kawaguchi 1bc181a9eb Exception looks bad to admins 2012-09-20 16:18:05 -07:00
Kohsuke Kawaguchi eb8818641e avoid recursinv the history forever 2012-09-20 16:17:20 -07:00
Kohsuke Kawaguchi 5ab06c4ae8 Merge remote-tracking branch 'origin/master' into lazy-load 2012-09-20 15:26:59 -07:00
Kohsuke Kawaguchi c15791c092 doc improvements 2012-09-20 15:10:04 -07:00
Kohsuke Kawaguchi 6043cdc97e doc improvements 2012-09-20 15:06:53 -07:00
Jesse Glick 4ab9c096bc Be more resilient against Guice errors.
com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance can throw NCDFE, it seems.
2012-09-20 17:58:33 -04:00
Kohsuke Kawaguchi 43a31d8fae Recording my notes 2012-09-20 14:43:55 -07:00
Kohsuke Kawaguchi d11284b152 the registerService call can be slow. run these asynchronously 2012-09-20 14:41:57 -07:00
Kohsuke Kawaguchi 8add095881 added logging 2012-09-20 14:13:49 -07:00
Kohsuke Kawaguchi 07ba368a39 we can't let these fields persisted! 2012-09-20 14:13:38 -07:00
Kohsuke Kawaguchi f8014d974c Path might be via symlink that uses build number. 2012-09-20 14:05:53 -07:00
Kohsuke Kawaguchi 516c4a7430 leaving notes for future TODO 2012-09-20 13:15:40 -07:00
Kohsuke Kawaguchi 5b00127eab Needs to copy the collection before it mutates them. 2012-09-20 11:31:05 -07:00
Jesse Glick f5a7869506 Null safety of Trigger.timer.
A botched startup (say by an error in InitializerFinder) can cause log to be filled with junk like:
Sep 20, 2012 1:10:50 PM hudson.ExtensionFinder$GuiceFinder instantiate
WARNING: Failed to load hudson.node_monitors.DiskSpaceMonitor
java.lang.InstantiationException: java.lang.ExceptionInInitializerError
	at net.java.sezpoz.IndexItem.instance(IndexItem.java:193)
	at hudson.ExtensionFinder$GuiceFinder.instantiate(ExtensionFinder.java:353)
	at hudson.ExtensionFinder$GuiceFinder.access$400(ExtensionFinder.java:232)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule$1.get(ExtensionFinder.java:509)
	at com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:84)
	at com.google.inject.internal.InternalFactoryToInitializableAdapter.provision(InternalFactoryToInitializableAdapter.java:52)
	at com.google.inject.internal.ProviderInternalFactory.circularGet(ProviderInternalFactory.java:66)
	at com.google.inject.internal.InternalFactoryToInitializableAdapter.get(InternalFactoryToInitializableAdapter.java:45)
	at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1018)
	at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
	at com.google.inject.Scopes$1$1.get(Scopes.java:59)
	at hudson.ExtensionFinder$GuiceFinder$4$1.get(ExtensionFinder.java:420)
	at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
	at com.google.inject.internal.InjectorImpl$3$1.call(InjectorImpl.java:965)
	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1011)
	at com.google.inject.internal.InjectorImpl$3.get(InjectorImpl.java:961)
	at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:389)
	at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:380)
	at hudson.ExtensionFinder._find(ExtensionFinder.java:149)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:289)
	at hudson.ExtensionList.load(ExtensionList.java:278)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:231)
	at hudson.ExtensionList.getComponents(ExtensionList.java:149)
	at hudson.DescriptorExtensionList.load(DescriptorExtensionList.java:182)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:231)
	at hudson.ExtensionList.size(ExtensionList.java:157)
	at java.util.AbstractCollection.isEmpty(AbstractCollection.java:86)
	at hudson.model.labels.LabelAtom.updateTransientActions(LabelAtom.java:107)
	at hudson.model.labels.LabelAtom.load(LabelAtom.java:189)
	at jenkins.model.Jenkins.getLabelAtom(Jenkins.java:1545)
	at jenkins.model.Jenkins.getSelfLabel(Jenkins.java:2422)
	at hudson.model.Node.getAssignedLabels(Node.java:240)
	at jenkins.model.Jenkins$17.run(Jenkins.java:2499)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:146)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:259)
	at jenkins.model.Jenkins$7.runTask(Jenkins.java:875)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:187)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:94)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:722)
Caused by: java.lang.ExceptionInInitializerError
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at net.java.sezpoz.IndexItem.instance(IndexItem.java:183)
	... 41 more
Caused by: java.lang.NullPointerException
	at hudson.node_monitors.AbstractNodeMonitorDescriptor.schedule(AbstractNodeMonitorDescriptor.java:73)
	at hudson.node_monitors.AbstractNodeMonitorDescriptor.<init>(AbstractNodeMonitorDescriptor.java:58)
	at hudson.node_monitors.AbstractNodeMonitorDescriptor.<init>(AbstractNodeMonitorDescriptor.java:54)
	at hudson.node_monitors.DiskSpaceMonitorDescriptor.<init>(DiskSpaceMonitorDescriptor.java:49)
	at hudson.node_monitors.DiskSpaceMonitor$1.<init>(DiskSpaceMonitor.java:62)
	at hudson.node_monitors.DiskSpaceMonitor.<clinit>(DiskSpaceMonitor.java:62)
	... 46 more
2012-09-20 13:38:36 -04:00
Kohsuke Kawaguchi b4888f2dd1 bug fix 2012-09-20 10:12:58 -07:00
Kohsuke Kawaguchi e357135e9f Rewrote RunList to derive from List, not ArrayList.
This is a signature breaking change, but it's critical in avoiding
unnecessary record load operations.
To my limited repository search, I couldn't find any use in a plugin
where RunList is casted to ArrayList, so hopefully this would be safe
enough.
2012-09-19 16:52:34 -07:00
Kohsuke Kawaguchi 0500ec9c27 overridden a number of Job methods in AbstractProject to avoid the slow path (of loading everything) 2012-09-19 15:29:08 -07:00
Kohsuke Kawaguchi b35678d5c1 fixed a regression in a test. 2012-09-19 14:31:13 -07:00
Jesse Glick a885cc2179 [FIXED JENKINS-7214] FilePath.validateAntFileMask too slow for /configure. 2012-09-19 16:43:20 -04:00
Jesse Glick 347bca5e5a testValidateAntFileMask 2012-09-19 16:03:26 -04:00
Jesse Glick 30de1dd47c Merge branch 'master' into slow-people-15206
Conflicts:
	changelog.html
2012-09-18 20:53:04 -04:00