Commit Graph
17505 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 40c10ff6eb Fixed a regression in 1.468 that broke LDAP
Stack trace:

org.jvnet.hudson.reactor.ReactorException: java.lang.IllegalAccessError: tried to access method hudson.security.SecurityRealm.findBean(Ljava/lang/Class;Lorg/springframework/context/ApplicationContext;)Ljava/lang/Object; from class hudson.security.LDAPSecurityRealm$LDAPUserDetailsService
  at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:246)
  at jenkins.InitReactorRunner.run(InitReactorRunner.java:43)
  at jenkins.model.Jenkins.executeReactor(Jenkins.java:885)
  at jenkins.model.Jenkins.<init>(Jenkins.java:790)
  at hudson.model.Hudson.<init>(Hudson.java:81)
  at hudson.model.Hudson.<init>(Hudson.java:77)
  at hudson.WebAppMain$2.run(WebAppMain.java:217)
Caused by: java.lang.IllegalAccessError: tried to access method hudson.security.SecurityRealm.findBean(Ljava/lang/Class;Lorg/springframework/context/ApplicationContext;)Ljava/lang/Object; from class hudson.security.LDAPSecurityRealm$LDAPUserDetailsService
  at hudson.security.LDAPSecurityRealm$LDAPUserDetailsService.<init>(LDAPSecurityRealm.java:419)
  at hudson.security.LDAPSecurityRealm.createSecurityComponents(LDAPSecurityRealm.java:369)
  at hudson.security.SecurityRealm.getSecurityComponents(SecurityRealm.java:398)
  at hudson.security.HudsonFilter.reset(HudsonFilter.java:134)
  at jenkins.model.Jenkins.setSecurityRealm(Jenkins.java:1960)
  at jenkins.model.Jenkins$17.run(Jenkins.java:2524)
  at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:146)
  at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:259)
  at jenkins.model.Jenkins$7.runTask(Jenkins.java:874)
  at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:187)
  at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:94)
  at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
  at java.lang.Thread.run(Thread.java:680)
2012-06-11 17:31:07 -07:00
Kohsuke Kawaguchi 02f6e4f8d9 Updating to Jetty 8 to get full stack trace in case of an error. 2012-06-11 17:04:42 -07:00
Kohsuke Kawaguchi 2b9b49101c allow SCM classes to have buildEnv.groovy since SCM can contirbute environment variables 2012-06-11 15:36:17 -07:00
Kohsuke Kawaguchi bc0b850510 Merge branch 'pull-434.2' 2012-06-11 15:23:28 -07:00
Kohsuke Kawaguchi 72fbaba275 Refactored existing static list into CoreEnvironmentContributor. 2012-06-11 15:21:57 -07:00
Kohsuke Kawaguchi 08d870baeb this should be done in the reverse order. 2012-06-11 14:24:09 -07:00
Kohsuke Kawaguchi 36b84a5d7f moving the logic from core to an extension point implementation 2012-06-11 14:23:04 -07:00
Kohsuke Kawaguchi 559656679c added a convenience method 2012-06-11 14:21:49 -07:00
Kohsuke Kawaguchi 5d78f3c958 Merge branch 'pull-449' 2012-06-11 11:54:46 -07:00
Kohsuke Kawaguchi d5513b0bd5 Reworked the dynamically modifiable Axis.
I thought about this and decided that the best way to incorporate this
expansion of the abstraction is to think of it as a re-configuration of
project right before the build.

This resolves my concern with the previous change of calling expensive
rebuildConfigurations() from every getActiveConfigurations() call (and
getter shouldn't have a side-effect, right?)

Also, in this way, Axis gets a reference to MatrixBuildExecution, so it
makes it more explicit that the Axis can update values based on the
current build.
2012-06-11 11:51:11 -07:00
Emanuele Zattin 5f7d239c6f Added support for runtime modifiable Axis
Sometimes there's the need to change the value of an axis right when the build starts.
I did this adding a couple of methods to Axis and letting MatrixBuild use them.
It should all be backwards compatible.
2012-06-11 10:51:24 -07:00
Kohsuke Kawaguchi dea9588415 the trunk is toward 1.471-SNAPSHOT 2012-06-11 10:34:20 -07:00
Kohsuke Kawaguchi 3427f2c003 creating an RC branch 2012-06-11 10:34:16 -07:00
Kohsuke Kawaguchi 78362282bf I botched 1.469 release, so skipping that and moving on to 1.470
This is a precautionary measure against those Maven proxies that might
have already cached 1.469 binaries while they were out.
2012-06-11 10:04:37 -07:00
Kohsuke Kawaguchi bacba61f4b merged back the RC branch
Conflicts:
	war/pom.xml
2012-06-11 10:01:56 -07:00
Kohsuke Kawaguchi 18e6e67503 updated changelog as a part of the release 2012-06-11 10:00:23 -07:00
Kohsuke Kawaguchi a2614d657b toward the next release 2012-06-11 09:26:36 -07:00
Kohsuke Kawaguchi 522b8285af releasing a new plugin parent POM 2012-06-11 09:26:27 -07:00
Kohsuke Kawaguchi fd3548b282 updated changelog for release 2012-06-11 09:26:27 -07:00
Kohsuke Kawaguchi 436df00528 [maven-release-plugin] prepare for next development iteration 2012-06-11 09:11:48 -07:00
Kohsuke Kawaguchi 5f48c2d91f [maven-release-plugin] prepare release jenkins-1.468 jenkins-1.468 2012-06-11 09:11:47 -07:00
Kohsuke Kawaguchi 195e900cd1 Fixed a classloader problem 2012-06-11 08:45:41 -07:00
Kohsuke Kawaguchi 4ec7ebf879 Added the -v option to report the console output of the build in progress. 2012-06-09 12:45:09 -07:00
Kohsuke Kawaguchi f037b11311 Added an option to wait for the start of a build. 2012-06-09 12:28:39 -07:00
Kohsuke Kawaguchi 9e3b4951df added ability to wait for the start of a build in a future, not just the end of it. 2012-06-09 12:16:43 -07:00
Kohsuke Kawaguchi 2776eea674 formatting changes 2012-06-09 11:49:26 -07:00
Kohsuke Kawaguchi 1d928a7b68 doc improvement 2012-06-09 11:49:05 -07:00
Kohsuke Kawaguchi 07c09bebb8 do not approximate the aggregated test result.
AggregatedTestResultAction remembers the exact build # of the child build, so honor that number, and don't let MatrixBuild.getRunFor(Configuration) picks up some earlier run.

The problem was discovered in the following situation:

 - there's a matrix project M with single configuration X
 - M #868 run normally, with 69 failures.
 - M #869 run with 258 failures, and that was reported in MatrixTestResult.add(AbstractTestResultAction), updating  the total count.
 - but for whatever reason, X #869 is lost
 - now if you look at M #869 test report, you'll see 258 as the total count, but the detail drill down would show 69, from X #868.

----
(05:25:57 PM) veebers: Hi all, I  have an odd issue with the 'test results'
(05:26:12 PM) veebers: In this result: Test Result (258 failures / +189) where could the +189 come from?
(05:26:20 PM) veebers: I can only actually see 69 failed tests :P
(05:26:48 PM) kohsuke: it means comparing to the last test result, you got 189 more failure
(05:27:37 PM) veebers: ah ok, but how can I have +189 failing tests when there are only 69 failed this time around?
(05:28:21 PM) kohsuke: I wonder if it cuts off the summary display at 70 (out of your 258 failures)?
(05:29:48 PM) veebers: Hmmm, kohsuke I don't know about that. Clicking the 'show all failed tests'  only shows 69 tests :P
(05:30:22 PM) veebers: and when I look at a prev. failing test, one that has ~200 fails
(05:30:24 PM) veebers: it shows the lot
(05:31:07 PM) kohsuke: veebers: want to do the screenshot?
(05:34:59 PM) veebers: kohsuke: sure: http://static.inky.ws/image/2143/image.jpg
(05:35:40 PM) kohsuke: this is a matrix project that just has one configuration?
(05:35:49 PM) kohsuke: Or is it a partial re-run?
(05:35:53 PM) mode (+o abayer) by ChanServ
(05:36:46 PM) veebers: first option. Only one config
(05:37:56 PM) kohsuke: I wonder if this is some kind of rendering gritch
(05:38:06 PM) kohsuke: perhaps if somehow it's showing the data of the previous run?
(05:38:24 PM) kohsuke: 69+189=258 can't be a coincidence
(05:38:53 PM) kohsuke: is this instance publicly visible?
(05:39:25 PM) veebers: err not that one, just checking if the results are published to the public one
(05:41:16 PM) veebers: hmm, that's odd. The publicly avail. one isn't showing the right details :P
(05:41:24 PM) kohsuke: URL?
(05:41:26 PM) veebers: well, perhaps there is something screwy with that setup
(05:42:14 PM) veebers: kohsuke: https://jenkins.qa.ubuntu.com/job/dx-autopilot-run/869/
(05:43:33 PM) veebers: kohsuke: although I don't think that's going to be much help as that gives me a 500 error :P
(05:43:45 PM) kohsuke: that's a bug of its own
(05:43:51 PM) kohsuke: I think I can fix that one
(05:50:29 PM) kohsuke: veebers: I think I have a hypothesis
(05:51:00 PM) kohsuke: when you do click that 69 failed tests reported under a configuration, I suspect you'll be actually taken to the different build number
(05:51:23 PM) kohsuke: likely the same configuration build of the previous one
(05:53:02 PM) veebers: kohsuke: hmm, not sure that's it.
(05:53:10 PM) veebers: it's the same build number all over
(05:53:53 PM) kohsuke: I'm pretty sure that's it
(05:54:01 PM) kohsuke: let me think of other ways to prove this
(05:54:27 PM) veebers: sure
(05:54:36 PM) kohsuke: try /job/dx-autopilot-run/869/label=1EBEE0FF-DAC9-11DF-BBDA-64A98C34D485/parentBuild/
(05:54:43 PM) kohsuke: and I predict you'll see #868 in the UI
(05:54:45 PM) veebers: so, the public page there says: Test Result (258 failures / +189)
(05:55:16 PM) veebers: When I click that link in the private server it takes me to that report you saw in the screenshot
(05:55:43 PM) veebers: which says: .../869/testReport/
(05:55:52 PM) veebers: and any other link on that page references 869
(05:56:04 PM) veebers: so perhaps it's somewhere in the background that might be accessing a prev build?
(05:56:36 PM) veebers: i.e. whatever builds up the top graph bar (at the top of the page) in server end rendering?
(05:56:50 PM) kohsuke: does /job/dx-autopilot-run/869/ show gray ball?
(05:57:27 PM) veebers: no, it shows the default config
(05:57:37 PM) veebers: (yeah, something is wrong with the public facing one :P)
(05:59:29 PM) veebers: not sure why you can't click through
(06:00:40 PM) veebers: kohsuke: ah, looks like you are correct
(06:00:50 PM) veebers: I was looking in the wrong place
(06:01:01 PM) veebers: kohsuke: d'oh, thanks for pointing that out :)
(06:01:41 PM) kohsuke: OK, I understand what happened
(06:02:38 PM) veebers: so yeah, clicking on that config, I can see the line: Started by upstream project dx-autopilot-run build number 868
(06:04:37 PM) kohsuke: #869 really did have 258 failures, but for some reason Jenkins lost the record of it
(06:05:02 PM) kohsuke: and when it's displaying this to you, it's approximating the lost record by using the nearest build, that was #868
(06:05:20 PM) kohsuke: and that's why the public instance, which runs ancient version of Jenkins, reports NPE
(06:05:30 PM) kohsuke: this version doesn't have that approximation feature
(06:05:42 PM) kohsuke: veebers: BTW you really should upgrade that publicly facing instance
(06:06:00 PM) kohsuke: there have been some security advisories issued since then
(06:06:11 PM) veebers: kohsuke: Makes sense, will get onto that
(06:06:30 PM) kohsuke: I'm fixing this in the trunk so that it doesn't incorrectly approximate here
(06:06:36 PM) veebers: nice
2012-06-07 18:15:08 -07:00
Kohsuke Kawaguchi d8d5305311 fixed NPE 2012-06-07 17:47:02 -07:00
Seiji Sogabe 35fc7a13c8 fixed test error. we expected application/json. 2012-06-07 20:50:59 +09:00
Nicolas De Loof 5ea1f5e6f4 SNAPSHOT plugins have been released 2012-06-07 11:47:37 +02:00
Nicolas De Loof a06acd9096 [FIXED JENKINS-14038] consider requested context when building Run.url 2012-06-07 11:47:37 +02:00
Kohsuke Kawaguchi 182f7bee5c [STAPLER-17] Fixed MIME type of JSON to application/json 2012-06-06 16:45:02 -07:00
Kohsuke Kawaguchi ebc6af72e9 Improved the mechanism of how we store passwords hashed. 2012-06-06 16:31:35 -07:00
Kohsuke Kawaguchi ffff8fb826 added a mechanism to run test without a Jenkins instance 2012-06-06 16:31:23 -07:00
Kohsuke Kawaguchi 6b1980e817 Released these plugins in preparation of a release 2012-06-05 21:05:15 -07:00
Kohsuke Kawaguchi 72cad376c4 These commits are for 1.469 2012-06-05 20:31:28 -07:00
Kohsuke Kawaguchi 6ab4691eff Merge remote-tracking branch 'origin/master' 2012-06-05 20:31:10 -07:00
Kohsuke Kawaguchi 372e8cb650 the trunk is toward 1.469-SNAPSHOT 2012-06-05 20:30:58 -07:00
Kohsuke Kawaguchi 473d486d32 creating an RC branch 2012-06-05 20:30:49 -07:00
Kohsuke Kawaguchi a68d644773 Merge commit 'ddd6867125c97bd8569d31a5092b3c577d5da241' 2012-06-05 20:29:29 -07:00
Kohsuke Kawaguchi d3f233ddf4 Merge branch 'pull-428'
Moved the changelog entry to the trunk part.
2012-06-05 18:22:43 -07:00
Kohsuke Kawaguchi 99b11d0df2 added UI sample fo contextual form field validation 2012-06-05 18:16:28 -07:00
Kohsuke Kawaguchi 17317bb4ca supported more complex relative path 2012-06-05 18:16:27 -07:00
Kohsuke Kawaguchi d72a9a2bc5 fixed a bug in the neighbor field discovery.
Previously, the code was "find the nearby element of the expected @name,
then make sure it has gotten the right parent."

So if the structure is like:

  {/* outer object */
      name: "parent-name",  /* A */

      child1: {/* inner object */
        name: "child-name" /* B */
      },

      child2: {/* inner object */
        name: "child-name" /* C */
      }
  }

... and if we are looking for "../name", it finds B, and it gets
rejected, so we won't be able to find A, which is what we are supposed
to find.

With this change, we keep trying until we find the right one,
so the above case will correctly return A.
2012-06-05 18:16:27 -07:00
Vincent Latombe ec5812c82e In ListView, wrap the list of jobs inside a scrollable div.
When managing instances with lots of jobs, the size of the view
configuration screen becomes huge because there is one line per job on
the instance.
2012-06-05 15:55:37 -07:00
Kohsuke Kawaguchi 658fd226ba allowed plugins to implement subtypes of the Search class to provide different search implementations 2012-06-05 15:51:35 -07:00
Kohsuke Kawaguchi e334748cb3 doc improvement 2012-06-05 15:40:11 -07:00
Kohsuke Kawaguchi ddd6867125 Completed the new extension point.
Adding a test and fixed a broken databinding (because of SCM vs Scm)
2012-06-05 15:23:09 -07:00
Olivier Lamy 9a3f25acbf add @since for a new method in 1.466 2012-06-05 22:45:41 +03:00