Commit Graph
19856 Commits
Author SHA1 Message Date
github-actions[bot]andtimja edd84f7ca7 Fill in since annotations (#9820)
Co-authored-by: timja <21194782+timja@users.noreply.github.com>
2024-10-03 09:10:53 -07:00
Mark Waite 208238192f Fix yarn lint error 2024-10-02 09:02:59 -06:00
Daniel BeckandDaniel Beck 4759f1a6f0 Be more explicit about not being logged in on 404 error page (#9766)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2024-10-02 08:47:49 -06:00
Basil Crow 1c2b84cb76 [JENKINS-73801] Nested Views plugin overrides View#doConfigDotXml(StaplerRequest) (#9764) 2024-10-02 08:47:16 -06:00
Basil Crow 47a212aa79 [JENKINS-73760] Updates fail due to invalid JSON from HTTP Update Center (#9760) 2024-10-02 08:46:51 -06:00
Vincent Latombe 39e6622524 Extract interfaces for objects to be used through the executors widget (#9749)
* Extract interfaces for objects to be used through the executors widget

This is required for CloudBees CI HA support: we provide alternate implementations of these interfaces to represent computers and related objects that exist in different physical replicas of the same logical instance. This allows to be build an aggregated view of computers and executors, some local, some remote.

* Fix Deprecated annotation

* Missing @Override annotations

* Missing @since TODO

* No longer true according to AbstractSubTask javadoc

* Restore old signature for compatibility

* Fix reviews

* Javadoc

* Typo

* Fix inconsistency between hasOfflineCause and getOfflineCauseReason

* Remove default implementation of ITask#getUrl

* Provide default impl in SubTask for compatibility

* Mark as CheckForNull

* Spotbugs

* ComputerSet#getComputers returns a collection that is sorted by name

* Missing Override

* Move permission declaration to the right place, closer to usage
2024-10-02 08:46:21 -06:00
Vincent Latombe a6f723cef7 Introduce SaveableListener#onDeleted (#9743)
* Introduce SaveableListener#onDeleted

Usually `Saveable` objects are written, but it can happen on occasion that they get deleted, and it wasn't generating an event for every case.

This provides a more fine-grained event that can be handled by implemented listeners.

In my case, I have a use case in CloudBees CI where I need to clear a cache entry when a Saveable gets deleted from disk.

* Spotless

* Explicitly test that the user that has performed the change can be obtained from the Saveable listener.
2024-10-02 08:45:44 -06:00
Jan FaracikandTim Jacomb 68ea077ed1 Refine 'Administrative monitors' interface (#9735)
* Squashed commit of the following:

* Rename section

* Push

* Update _plugin-manager.scss

* Update _checkbox.scss

* Reset files

* Update _badges.scss

* Update _badges.scss

* Update _theme.scss

* Remove label

* Fix lint

---------

Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
2024-10-02 08:45:04 -06:00
7a1c2ce67a [JENKINS-60866][JENKINS-71515] Use JSON#parse to process codemirror-config argument (#6867)
* [JENKINS-60866] Use JSON#parse to process codemirror-config argument

* Add backward compatibility for most common setting

* Integrate fixed antisamy-markup-formatter to pass test

* Fix JS and revert unnecessary antisamy-markup-formatter update

How do we have a billion different linters and not one did tell me
I'm redefining a variable?

* Remove comment

---------

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Basil Crow <me@basilcrow.com>
2024-10-02 08:44:18 -06:00
Daniel Beck dfd7a9c48b [SECURITY-3373] 2024-09-25 07:59:32 +00:00
Daniel Beck d0c0d07bc4 [SECURITY-3451] 2024-09-25 07:59:26 +00:00
Kevin-CB cd242d9ed4 [SECURITY-3448] 2024-09-25 07:59:21 +00:00
github-actions[bot]andtimja 32039daa66 Fill in since annotations (#9758)
Co-authored-by: timja <21194782+timja@users.noreply.github.com>
2024-09-19 10:30:19 -07:00
Vincent LatombeandJesse Glick f9fef613ce Clean up a few plain e.printStackTrace() calls (#9742)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2024-09-19 09:47:42 +01:00
Jan Faracik 1836bd6ef4 Add full stops to user page descriptions (#9750) 2024-09-18 22:06:41 +01:00
Daniel BeckandDaniel Beck de25478f3f [JENKINS-73785] Restore ContextMenu#from with StaplerRequest/Response args (#9737)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2024-09-16 18:36:50 -07:00
Jan FaracikandTim Jacomb 2d2adefabd Refine content and appearance of the user account screen (#9521)
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2024-09-16 13:38:47 +01:00
Jan Faracik 239ced05af Use Notice component for views lacking jobs (#9724)
* Use notice for views lacking jobs

* Update _notice.scss

* Rename text to title, use 'invokeBody' rather than description field
2024-09-15 13:28:22 -06:00
github-actions[bot]andtimja be3d711d69 Fill in since annotations (#9721)
Co-authored-by: timja <21194782+timja@users.noreply.github.com>
2024-09-13 16:21:38 -06:00
Devin Nusbaum dab6597416 [JENKINS-73687] Make deserialization of Map fields in XML files more robust (#9653)
* Improve resilience against malformed XML files during deserialization

* Improve error message
2024-09-13 16:21:22 -06:00
Jan Faracik ce3d8c102c Update appearance of 'Jenkins is starting' pages (#9707)
* Init

* Update simple-page.scss

* Simplify

* Update simple-page.scss

* Delete loading.css

* Update some translations

* Remove some translations (still more to update)

* WIP translations - just need to confirm with friends

* Update/remove translations
2024-09-13 07:42:40 +01:00
Vincent LatombeandJesse Glick 35d767790f Introduce HistoricalBuild interface (#9674)
* Introduce HistoricalBuild interface

This allows to display Run-like objects in build history without having concrete Run present in the Jenkins instance.

* Remove BuildHistoryWidget#entries.jelly

* JDK17 level

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

---------

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2024-09-10 20:32:36 -06:00
Basil Crow 85d6358c32 Compatibility for ChainedServletFilter (#9696) 2024-09-09 16:14:48 +01:00
Juan Jesús Alejo Sillero 4334aa0723 fix(i18n): correct typo in Spanish translation for 'Preparation' (#9702) 2024-09-09 16:13:51 +01:00
Markus WinterandKris Stern 2431b7c9b3 [JENKINS-72988] validate displayname against items in the same ItemGroup (#9152)
Co-authored-by: Kris Stern <krisstern@outlook.com>
2024-09-09 16:13:20 +01:00
Vincent Latombe bfcb8741d8 Merge pull request #9645 from Vlatombe/with-console-url 2024-09-09 16:57:03 +02:00
Vincent Latombe b56e5d796a Merge pull request #9673 from Vlatombe/computerListener.onIdle 2024-09-09 11:21:50 +02:00
Tim Jacomb 525a8be453 Disable dependents toggle in plugin manager with system read (#9463) 2024-09-07 20:19:01 +01:00
Vincent Latombe 2f6d77c70f Merge branch 'master' into with-console-url 2024-09-04 10:48:53 +02:00
7006cded64 [JENKINS-73278] Migrate core from EE 8 to EE 9 (#9672)
Co-authored-by: Kevin Guerroudj <91883215+Kevin-CB@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2024-09-03 14:59:04 -07:00
Thorsten Scherler 1008dcb1df [JENKINS-73695] BUG: Dashboard shows white space on certain width space >900px (#9667) 2024-09-01 15:50:49 +01:00
Allan BurdajewiczandDaniel Beck 5fe9a44805 [JENKINS-73422] Add escape hatch for Authenticated user access to Resource URL (#9644)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2024-08-30 14:26:27 +01:00
Markus Winter fc73c2622a [JENKINS-73669] don't change unrelated checkboxes in rowSelectionCont… (#9648) 2024-08-30 14:26:10 +01:00
Kris SternandDaniel Beck a075ffb583 Add doCheckDisplayNameOrNull to jenkins core (#9150)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2024-08-30 14:25:58 +01:00
Vincent Latombe 6b88bfcbd5 Spotless 2024-08-28 16:22:14 +02:00
Vincent Latombe ed93ad020a Revert "Call listener synchronously, but outside synchronized"
This reverts commit 75242cf030.
2024-08-28 16:12:09 +02:00
Vincent Latombe 75242cf030 Call listener synchronously, but outside synchronized 2024-08-28 15:47:51 +02:00
Vincent Latombe 9823b8ed7e Execute ComputerListener#onIdle in another thread. 2024-08-28 15:40:43 +02:00
Vincent Latombe 64667af499 Implement ComputerListener#onIdle
Introduces a new computer listener fired whenever a Computer becomes idle.
2024-08-28 09:54:25 +02:00
Vincent LatombeandJesse Glick 5df30de435 Add -webSocket option by default when creating an inbound agent (#9665)
* Add -webSocket option by default when creating an inbound agent

* Update core/src/main/resources/hudson/slaves/JNLPLauncher/main.properties

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

---------

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2024-08-27 19:22:38 -06:00
Jesse Glick f84ab6aae1 [JENKINS-73692] Turn off logging from BackgroundGlobalBuildDiscarder (#9663)
Turn off logging from `BackgroundGlobalBuildDiscarder`
2024-08-27 19:22:12 -06:00
Daniel BeckandDaniel Beck ffdd5be9a3 Fix error message when creation of item by type is prohibited (#9662)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2024-08-26 17:43:31 -06:00
Mark Waite a6d093d18d [JENKINS-73302] Restore margins around setup wizard alert messages (#9658) 2024-08-26 10:27:51 +01:00
秋 雨落 9045a3db16 Fix PathRemoverTest timeout in RISC-V devices. (#9661) 2024-08-26 10:26:54 +01:00
Markus Winter 83541cfb0e [JENKINS-73613] refresh buildhistory widget in all cases (#9624)
* [JENKINS-73592] refresh buildhistory widget when page gets focus

* [JENKINS-73613] refresh buildhistory in all cases

refresh the buildHistory widget instantly when the window gets focus,
e.g. after switching browser tabs but also when one was in another
application and clicks in the browser window.
When the window is visible it will update even when it has no focus,
when the window is hidden no calls to the controller will be done.

Additionally the buildHistory will be updated when it is not on the
first page. So e.g. when someone deletes a build, changes the display
name or the description or when a build is still running the page gets
updated.
2024-08-24 11:58:09 +02:00
Basil Crow 856bd0fc58 Turn down log level of StaplerFilteredActionListener (#9643) 2024-08-22 12:50:03 -06:00
Vincent Latombe 2d30cfcf98 Fix review 2024-08-22 17:20:38 +02:00
Vincent LatombeandDevin Nusbaum 44602bbf9c Typo spotted by @dwnusbaum
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
2024-08-22 17:12:59 +02:00
Vincent Latombe 39d30c8828 Add WithConsoleUrl interface
This simplifies the logic of `Functions#getConsoleUrl` and makes it pluggable.
2024-08-22 15:33:03 +02:00
Madis PärnandTim Jacomb b064be0de8 JENKINS-68822 added support for removing all builds with LogRotator (#9405)
* JENKINS-68822 added support for removing all builds with LogRotator

* Update core/src/main/java/hudson/tasks/LogRotator.java

---------

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2024-08-21 07:46:42 +02:00