Commit Graph
18139 Commits
Author SHA1 Message Date
Oleg Nenashev eee8fc7d8a Merge pull request #3535 from jtnord/missing-annotation
Method just called and cast another method that was CheckForNull
2018-07-07 11:46:59 +02:00
Daniel Beck 3d7fbb485f Merge pull request #3532 from LinuxSuRen/i18n/login
Add translation for login page
2018-07-07 11:28:38 +02:00
James Nord 6e9babd41e Method just called and cast another method that was CheckForNull
toComputer() was annotated with CHeckForNull yet getComputer which just
calls that and casts it was not.  This causes code using getComputer()
to not have a findbugs check and this has been observed in a
NullPOinterException happening at runtime.
2018-07-03 13:31:35 +01:00
Oleg Nenashev d041df95f9 Merge pull request #3520 from jsoref/toplevel-description-help
improve docstring for TopLevelItemDescriptor.getDescription
2018-07-03 14:18:07 +02:00
suren 3a125b65c8 Translate for login page 2018-07-02 16:59:30 +08:00
Kohei Suzuki 639e5d3562 Fix documentation of getItems's return value 2018-07-02 16:32:39 +09:00
Devin Nusbaum dbeda50aba [JENKINS-52164] Fix rename action for AbstractItems that don't define URL when including the actions taglib (#3523)
* Reproduce JENKINS-52164

* Fix JENKINS-52164 by creating URL inline

* Remove tests from core
2018-06-29 17:01:09 -04:00
Josh Soref 0f4df5b628 Revoke and revoked token (#3524)
* i18n: include RevokedToken translation

Note: This message is shown in the "Legacy API Token" field after the user has revoked their legacy token.

* Include alt text so that at least blind users can figure out how to revoke tokens

As a sighted user, I could not figure it out. This gives the blind a chance.
2018-06-29 20:43:10 +02:00
Daniel Beck 20d9431222 Merge pull request #3519 from jsoref/legacy-api-token-ux
Legacy api token ux
2018-06-29 16:21:47 +02:00
Daniel Beck 0107b8fa41 Merge pull request #3522 from jsoref/JENKINS-52159
JENKINS-52159: Queue.maintain - tolerate misbehaving sorter.sortBuild…
2018-06-29 14:38:20 +02:00
Daniel Beck 57b2bf79e7 Merge pull request #3526 from jsoref/title
i18n/a11y: provide alt text for the jenkins logo and masthead
2018-06-29 14:36:44 +02:00
Daniel Beck 1b805f8871 Merge pull request #3525 from Wadeck/JENKINS-52161_UNKNOWN_DATE
[JENKINS-52161] Improve creation-date value determination
2018-06-29 14:34:53 +02:00
Daniel Beck a2b24b37e1 Merge pull request #3356 from daniel-beck/sha-256-512
Add support for SHA-256/512 in update site metadata
2018-06-29 14:29:31 +02:00
Josh Soref 1adde3ac5c i18n: include localization for Jenkins
This is the alternate text that replaces the picture of Jenkins in the banner
2018-06-27 00:02:40 -04:00
Josh Soref db5aa4bf6c i18n: Add jenkins alt item for localization 2018-06-27 00:01:17 -04:00
Josh Soref b8f7d3b94a i18n: add Jenkins banner text 2018-06-26 23:59:06 -04:00
Wadeck Follonier d0be7b3431 Avoid using deprecated constructor in test 2018-06-26 21:15:13 +02:00
Wadeck Follonier e0cc790ee7 Address other comments
- also add translation for another creationDate
- and manage correctly the null creation date instead of 0
2018-06-26 17:33:05 +02:00
Wadeck Follonier 0a41e87b66 Address Josh's comments 2018-06-26 14:51:25 +02:00
Wadeck Follonier 5f7c50cd0d [JENKINS-52161] Improve creation-date value determination
- in case of migration we put null instead of now
- improve also the difference in days for the Xxx day(s) ago to take calendar day in difference and not the total duration (<24h = 0 days, which seems wrong in UI)
2018-06-26 13:06:16 +02:00
Josh Soref 1083a3f5c6 JENKINS-52159: Queue.maintain - tolerate misbehaving sorter.sortBuildableItems()
Any plugin that implements the sort step could throw an exception which would break
the maintain() step. As sorting is really an optional step, it really should not be fatal.

Instead, we wrap the step in a try block, log it, and move on with life.
2018-06-25 17:12:13 -04:00
Josh Soref ad4c1250b9 grammar: this 2018-06-25 14:36:33 -04:00
Josh Soref bd05b8cc04 clarify: jnlp agent port help
document default and recommended behavior first
grammar: recommended-that
explain that the system is responsible for random generation at launch

Removes mention of "default" secondary behavior because, afaict
the default is simply "disabled", but by listing random before assigned,
we're implicitly favoring that.
2018-06-25 12:23:26 -04:00
Josh Soref 7d71c5a6a1 improve docstring for TopLevelItemDescriptor.getDescription
grammar: recommended
grammar: plain text
clarify: consistent -- the old text did not really make sense
clarify: Stapler Thread association
clarify: otherwise
2018-06-25 12:19:36 -04:00
Josh Soref 6896b1c5bd spelling: User ID 2018-06-25 11:23:26 -04:00
Josh Soref a004d83b4f grammar: tense/whether-or-not/left/count-agreement 2018-06-25 11:17:06 -04:00
Josh Soref f610a04223 active voice 2018-06-25 11:13:32 -04:00
Josh Soref 15ebe65102 grammar: agreement token-exists 2018-06-25 10:59:26 -04:00
Josh Soref afc4d06d21 realistic: it will be inaccurate 2018-06-25 10:58:46 -04:00
Josh Soref c96a8e0ac5 grammar: count agreement #-of(plural) 2018-06-25 10:58:30 -04:00
Kohsuke Kawaguchi 22aa2e6e76 mvn incrementals:reincrementalify 2018-06-24 20:21:19 -07:00
Kohsuke Kawaguchi b9cd13dc6e [maven-release-plugin] prepare for next development iteration 2018-06-24 20:14:27 -07:00
Kohsuke Kawaguchi 216231625c [maven-release-plugin] prepare release jenkins-2.129 2018-06-24 20:14:27 -07:00
Jon f47037846f [JENKINS-52026] - Adding logging of called CLI commands (#3506)
[JENKINS-52026] - Adding logging of called CLI commands
2018-06-24 13:11:20 +02:00
Daniel Beck fd1ec1d125 Merge pull request #3271 from Wadeck/JENKINS-32442-32776_HASHED_TOKEN
[JENKINS-32442][JENKINS-32776] New API Token system
2018-06-23 23:20:44 +02:00
Mark Waite e18df1ffd3 [JENKINS-52153] - Check SlaveComputer.getChannelToMaster() before use (#3488)
[JENKINS-52153] - Check SlaveComputer.getChannelToMaster() before use
2018-06-23 22:48:41 +02:00
Oleg Nenashev 41083ef30f [JENKINS-51837] - Update BCT from 1.8 to 2.0-beta-2 with ASM 6.2 2018-06-21 13:26:46 +02:00
Youngrok Kim d391eac520 Fix Korean translation in the login page 2018-06-19 21:32:32 +09:00
Wadeck Follonier c3e6f9101d Merge branch 'master' into JENKINS-32442-32776_HASHED_TOKEN 2018-06-19 13:24:18 +02:00
James Nord 1e8c07a4ea Merge pull request #3496 from jtnord/JENKINS-JENKINS-28683
[JENKINS-28683] (A)PeriodicWork suuport for dynamically loaded plugins.
2018-06-18 22:29:21 +01:00
Kohsuke Kawaguchi 8b4dea41de mvn incrementals:reincrementalify 2018-06-17 15:21:01 -07:00
Kohsuke Kawaguchi 5a66551e3d [maven-release-plugin] prepare for next development iteration 2018-06-17 15:15:06 -07:00
Kohsuke Kawaguchi 29141f8ea3 [maven-release-plugin] prepare release jenkins-2.128 2018-06-17 15:15:05 -07:00
Thorsten Scherler 90670e05c1 [JENKINS-50447] New design and slim down of login page (#3380)
* [JENKINS-50447] New design and slim down of login page

The change will provide a new designed login page that is using no external deps to prevent any possible malvious javascript.
We still allow the user to use the legacy login page, which has not changed the behaviour.

[JENKINS-50447] Implement error case and use final svg jenkins logo

[JENKINS-50447] remove mock up logo

[JENKINS-50447] Fix feet back from jlong

[JENKINS-50447_squash] Use theme css which only contains values to be overriden. Drop ie js since with the theme css it is not needed anymore

* [JENKINS-50447_squash] Fix expression to evaluate when to show an error and when to simply redirect

* eslint - formating changes and fix offences

* [JENKINS-50447_squash] Use system property to controll whether or not to use the legacy login

* [JENKINS-50447_squash] prevent that the jsessionId appears in the url which should fix most tests

* [JENKINS-50447_squash] Fix cli test by adding pageDecorators magic from layout.jelly

* [JENKINS-50447_squash] remove pageDecorators because they assume existence of js that we do not have

* [JENKINS-50447] New design and slim down of login page

The change will provide a new designed login page that is using no external deps to prevent any possible malvious javascript.
We still allow the user to use the legacy login page, which has not changed the behaviour.

[JENKINS-50447] Implement error case and use final svg jenkins logo

[JENKINS-50447] remove mock up logo

[JENKINS-50447] Fix feet back from jlong

[JENKINS-50447_squash] Use theme css which only contains values to be overriden. Drop ie js since with the theme css it is not needed anymore

[JENKINS-50447_squash] Fix expression to evaluate when to show an error and when to simply redirect

eslint - formating changes and fix offences

[JENKINS-50447_squash] Use system property to controll whether or not to use the legacy login

[JENKINS-50447_squash] prevent that the jsessionId appears in the url which should fix most tests

[JENKINS-50447_squash] Fix cli test by adding pageDecorators magic from layout.jelly

[JENKINS-50447_squash] remove pageDecorators because they assume existence of js that we do not have

[JENKINS-50447_squash] make login page extensible with pagedecorators

[JENKINS-50447_squash] drop legacy support

* Make theme customisable by using a magic package for css and header. Limiting the implemetation of those to one.

* [JENKINS-50447_squash] Creating a specific decorator for login which only returns one instance

* [JENKINS-50447_squash] using rounded corner

* JENKINS-50447 remove legacy code

* [JENKINS-50447_squash] Fix comments from @amuniz about javadoc and uniqueness of css for login

* [JENKINS-50447_squash] Fix click on label span to toggle the select of the checkbox

* [JENKINS-50447_squash] fix comments from @daniel-beck

* [JENKINS-50447_squash] Fix license headers

* [JENKINS-50447_squash] Implement loading/restarting and signup with same design

* [JENKINS-50447_squash] Implement the loading/restarting view and signup with same design as the login page

* [JENKINS-50447_squash] Remove limitation that only one validation error can be shown at a time

* [JENKINS-50447_squash] implement password strength checker

* [JENKINS-50447_squash] Fix different comments from @daniel-beck regarding titles. Further enhanced spacing of label and input

* [JENKINS-50447_squash] Fix restart screen css. Fix comments regarding signup page.

* [JENKINS-50447_squash] fix tabindex flow

* harmonize design
- of checkboxes using jdl styles.
- distance of headers

* [JENKINS-50447] Fix comments from @daniel-beck
- fix some accessibility issues
-- html has now a lang tag
-- define main region
- fix missplaced }
- fix when server down for real that we still show the loading page

* [JENKINS-50447_squash] should never ended up here
2018-06-17 18:02:37 +02:00
Vincent Latombe a372afff94 [JENKINS-48480] Switch deprecated protocols to opt-in. (#3188)
* [JENKINS-48480] Switch deprecated protocols to opt-in.

They no longer need to be removed by setup wizard since they won't be
enabled in the first place.

* [JENKINS-48480] Fix tests

* [JENKINS-48480] Remove useless calls to CLI.get().setEnabled(true)

It is already enabled.

* [JENKINS-48480] Bump remoting.minimum.supported.version to 3.4
2018-06-17 14:56:52 +02:00
Oleg Nenashev 3d6229d9e8 Merge pull request #3495 from jsoref/more-i18n
More i18n
2018-06-17 10:09:16 +02:00
Oleg Nenashev e4e06333ee Merge pull request #3489 from oleg-nenashev/bug/JENKINS-51889
[JENKINS-51889,JENKINS-51955,JENKINS-51971] - Stop using Guava’s NullOutputStream, document setChannel API
2018-06-15 20:09:28 +02:00
Oleg Nenashev 89d9c21e44 [JENKINS-51971] - Defaults to the null charset 2018-06-15 16:30:42 +02:00
James Nord 198c73120a [JENKINS-28683] method should be private 2018-06-15 11:21:36 +01:00
Oleg Nenashev fef59606a8 [JENKINS-51955] - Prevent NPE in SlaveComputer#setChannel(Channel,OutputStream launchLog,Channel.Listener,) when null launchLog is passed from API 2018-06-15 00:56:51 +02:00