Commit Graph
164 Commits
Author SHA1 Message Date
Basil Crow f12f400a5c Consistently use issues.jenkins.io for issue links (#5724) 2021-09-13 20:07:44 +01:00
Daniel Beck ef6b562161 Update at-since up to 2.308 2021-08-26 17:09:43 +02:00
Basil Crow bd7c823c27 Remove unnecessary parentheses (#5576) 2021-06-25 09:23:37 +01:00
Basil CrowandDaniel Beck b8c20c6428 Fix violations of a handful of Error Prone checks (#5519)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-06-14 16:45:34 +01:00
Tobias GruetzmacherandDaniel Beck 4fc0d5a085 Show implied plugin dependencies (#5472)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-05-25 20:57:19 +01:00
Basil Crow ccaabe5adc Reduce usages of com.google.common.collect in favor of native Java functionality (#5464)
* Reduce usages of `com.google.common.collect` in favor of native Java functionality

* Copy original list to preserve original behavior
2021-05-10 11:40:21 +02:00
Basil Crow f6378676b1 Add missing @Override annotations (#5430) 2021-04-28 17:28:25 +08:00
Basil Crow 44c5342c58 Declare modifiers in JLS order (#5339) 2021-03-08 07:58:59 +00:00
Oleg Nenashev b49610e29f Cleanup warnings for missing getPlugin() null checks (#5222) 2021-02-10 19:52:44 +00:00
Basil Crow 64dbdbc4f5 Remove unused imports 2020-12-19 13:10:38 -08:00
Basil Crow 81bbfea719 Remove redundant close() statements 2020-12-11 21:34:22 -08:00
Daniel BeckandDaniel Beck 3ea9dc6b3a Do not block rendering of Manage Jenkins while waiting for UC data (#4881)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:34:18 +01:00
Daniel BeckandDaniel Beck c632f42f07 Update at-since Javadoc (#4877)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:33:48 +01:00
StefanSpiekerandOleg Nenashev 463cd113ba Minor refactorings either for performance or readability (#4845)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-07-17 15:14:46 +01:00
Daniel Beck f0ef947bf4 Make this a list to allow direct element access 2020-05-03 22:40:10 +02:00
Daniel Beck d213ef962c Add support for top-level 'deprecations' element in update site 2020-05-03 22:09:47 +02:00
Daniel Beck 0dc475a1df Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-05-03 18:29:48 +02:00
Daniel BeckandDaniel Beck e7efc567d2 Hide message re disabling implied dependencies when no dependents exist (#4597)
* Hide message re disabling implied dependencies when no dependents exist

* Rename CSS class to be clear about when it's added

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-04-07 09:40:15 +02:00
James Nord 1f946961b9 s/javax.annotation.CheckForNull/edu.umd.cs.findbugs.annotations.CheckForNull/g 2020-03-26 16:12:35 +00:00
James Nord 819f80b12f s/javax.annotation.Nonnull/edu.umd.cs.findbugs.annotations.NonNull/g 2020-03-26 11:14:41 +00:00
Antonio MunizandTim Jacomb b6678c2241 [JENKINS-61455] "About Jenkins" accessible with Jenkins.MANAGE (#4569)
* [JENKINS-61455] _About Jenkins_ accesible with Jenkins.MANAGE

_About Jenkins_ management link is now accessible to users with
Jenkins.MANAGE or Jenkins.SYSTEM_READ (as well as the usual
Jenkins.ADMINISTRATOR)

* [JENKINS-61455] Test updated to cover this use case

* [JENKINS-61455] Fix test

* [JENKINS-61455] Fix permissions on linked pages

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
2020-03-25 07:57:56 +00:00
Daniel Beck 665bc4deea Add inline security warnings to installed plugins list 2020-03-07 19:15:27 +01:00
Tim Jacomb 47a0be9eda JENKINS-61201 JEP-224 System read - about jenkins (#4520) 2020-02-27 07:47:54 +00:00
Joseph Petersen a05b37ea87 Hide deprecated plugins inside the available section on update center 2020-02-19 22:36:52 +01:00
Joseph Petersen ed9baefc56 Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-02-19 18:37:04 +01:00
Stefan Spieker 40206e023c removed some redundant constructs and replaced stringbuilder operations with too few arguments with string concatenation 2019-11-24 16:15:20 +01:00
Oleg Nenashev eedf2a4e2a Merge pull request #4262 from StefanSpieker/replace_getActiveInstance
Replaced deprecated getActiveInstance() with get()
2019-11-22 10:25:21 +01:00
Zbynek Konecny 40b68eaadb [JENKINS-59679] Use plugin URL from the update site rather than the manifest (#4273)
* Use plugin URL from the update site rather than the manifest

* Avoid Mockito when not needed

* Resolve plugin URL from multiple update sites
2019-11-10 11:24:28 +01:00
Oleg Nenashev 41a13dffc6 Merge pull request #4308 from basil/javadoc
Javadoc cleanup
2019-11-01 01:30:33 +03:00
Basil Crow 861855953b Replace <code>…</code> with {@code …} 2019-10-19 14:02:59 -07:00
Basil Crow a6e22982d4 Fix typos in Javadoc declarations 2019-10-19 14:02:59 -07:00
Daniel Beck fdb6faed00 Update at-since in Javadoc, make script work on Mac OS X 2019-10-16 12:22:03 +02:00
Joseph Petersen c1b532b437 add since todo 2019-10-12 11:14:04 +02:00
Stefan Spieker 76057897be replaced deprecated getActiveInstance() with get() 2019-10-03 21:13:14 +02:00
Jesse GlickandOleg Nenashev 2bfded176c Display a warning in the Installed tab if the admin is about to disable or uninstall a detached plugin (#4098)
* Display a warning in the Installed tab if the admin is about to disable or uninstall a detached plugin.

* @since

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
2019-07-09 08:54:15 +02:00
Gustavo de Souza Bezerra 0e62b68012 [JENKINS-57678] - Change getInstance() (deprecated) to get() (#4042)
* Change getInstance() (deprecated) to get()

* Reverting modifications according review

* Changing for use the variable
2019-06-27 17:24:45 +02:00
Joseph Petersen 908c5ace5d Enable labels/categories with deprecated to show a warning for plugins 2019-06-17 19:00:40 +02:00
Jesse Glick 0f73231f77 [JENKINS-33843] Permit disabling optional dependencies (#4001)
* Implied dependencies on detached plugins were not being marked optional despite being listed in optionalDependencies, confusing the calculation of optionalDependents in resolveDependentPlugins.

* Javadoc improvements based on code exploration.

* [JENKINS-33843] Do not consider optional dependencies for purposes of disabling plugins.

* PluginManagerInstalledGUITest updated to reflect new behavior.
2019-06-15 11:21:20 +02:00
Josh Soref 8825451f67 spelling: dependent (#3821)
* spelling: dependent

Writers following British writing convention often confuse dependent and dependant. Those following US writing convention have an easier time with these words because Americans do not use dependant.

A dependant is a person who is dependent on someone else. (For example, a child is dependent on its parents. Therefore, a child is a dependant of its parents.)

Jenkins does not deal with people, thus the UK rule which is confusing does not apply.

* Add deprecated shims
2019-02-28 14:12:37 +01:00
Oleg Nenashev 9a146147c4 [JENKINS-55980] - Switch Java Specification Version comparison in the core to a robust implementation.
After the change all Java Specification Version comparison operations are robust against comparison of old and new Java spec version formats
See https://openjdk.java.net/jeps/223 for the new format
2019-02-05 18:16:25 +01:00
Baptiste Mathus 1afa724313 Introduce method to fetch java.specification.version 2019-01-09 18:12:02 +01:00
Baptiste Mathus 282e42b161 Provide more information about where/how the Minimum-Java-Version is coming from the plugin's metadata 2019-01-09 17:51:09 +01:00
Baptiste Mathus 791253d08a Remove duplicated Javadoc
as proposed by @jglick
2019-01-09 17:37:57 +01:00
Baptiste Mathus c61031db6b Add missing space in javadoc 2019-01-09 17:37:57 +01:00
Baptiste Mathus 29de9aaef6 Rename to minimumJavaVersion to keep the name across tooling
Given this field is present in maven-hpi-plugin, update-center, etc.
I think it does not hurt to keep the 'Minimum-Java-Version' name across
various usages to help make it clear.
2019-01-07 14:31:16 +01:00
Baptiste Mathus 27c49bf0a1 Merge branch 'master' into JENKINS-20679-filter-out-plugins-compiled-with-more-recent-jdk 2019-01-07 11:11:38 +01:00
Stephen Connolly 4bf99bae6e Merge branch 'master' into jenkins-45235 2018-11-16 21:17:13 +00:00
Baptiste Mathus 131794b84d Merge pull request #3648 from MRamonLeon/JENKINS-27177
[JENKINS-27177] Add disable plugin command and tests
2018-11-08 13:04:13 +01:00
M Ramon Leon 8f239f6ee1 [JENKINS-27177] Add new status error_disabling and minor fixes
When there is some problem disabling a plugin (the disabling file cannot
be created) it should be indicated and also reflected in the dependee
plugin.
2018-10-16 11:47:23 +02:00
M Ramon Leon 1aa7dbb818 [JENKINS-27177] Minor fixes 2018-10-15 11:56:27 +02:00