Commit Graph
3953 Commits
Author SHA1 Message Date
kohsuke f2aecc5551 more convenience methods.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21746 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 20:28:24 +00:00
kohsuke d2c8e6b8f8 more references.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21699 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 02:31:06 +00:00
kohsuke 235db08eb4 improved cross referencing.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21698 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 02:29:49 +00:00
kohsuke 200518006a refactoring the JDK installer to allow ssh-slaves to do this over SSH.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21687 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:53:31 +00:00
kohsuke 08c9928037 allow subtypes to be defined by plugins.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21686 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:12:52 +00:00
kohsuke 8a73c25000 Fixed the charset encoding handling when different encodings are involved between the master and slaves.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21664 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 23:52:25 +00:00
kohsuke 73f1b2ebac fixed a serialization form of Result so that it works like a value type.
See http://d.hatena.ne.jp/masanobuimai/20090911#1252684658

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21663 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 22:56:08 +00:00
mindless 82f0feb999 Updates to use non-deprecated APIs, and add some @Override annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21661 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:40:23 +00:00
mindless 2a67420162 fix indent
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21657 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:19:35 +00:00
mindless db93c57e03 Add @Override annotations, one copyright header and some tab->ws
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21655 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:10:57 +00:00
mindless 9fed9823f5 Add @Override annotations, remove unused imports,
add some copyright headers, some tab->ws


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21654 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 18:08:34 +00:00
pgweiss 7c2d1e9455 Don't fail the build when there is nothing to archive -- just warn -- provided system property hudson.tasks.ArtifactArchiver.warnOnEmpty=true
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 15:28:53 +00:00
dty 2a34cdafe6 [HUDSON-3677] First pass at providing read-only access to project configuration.
Defined a new permission, ExtendedRead, which can be enabled by specifying true
for the system property hudson.security.ExtendedReadPermission. Granting job
configuration permissions implies this permission.

	main/core/src/main/java/model/Item.java

Added plumbing for dynamic enabling and disabling of permissions at runtime.
This will be the basis for future UI based toggling of the availability of a
permission.

	main/core/src/main/java/hudson/security/Permission.java

Add the enabled state of a permission to the decision about whether a principal
has it or not. Only show a permission when it's enabled.

	main/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java

Allow access to config.xml when ExtendedRead is granted.

	main/core/src/main/java/hudson/model/Job.java

Don't show the save button if the user only has ExtendedRead.

	main/core/src/main/resources/hudson/model/Job/configure.jelly

Change the text of the Configure link in the side panel based on whether a user
has Configure or ExtendedRead permissions.

	main/core/src/main/resources/hudson/model/AbstractProject/sidepanel.jelly



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21626 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-12 08:13:00 +00:00
kohsuke dfacf6eab5 delete the config file first, so that even if the request doesn't fully complete, the job won't be resurrected.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21575 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 20:40:25 +00:00
mindless c3583afaff avoid a couple redundant save() calls in submit()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21571 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 16:35:26 +00:00
mindless bf9c475fe6 [FIXED HUDSON-4405] trim remoteFS value to avoid hard-to-notice error
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21557 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 19:04:17 +00:00
mindless bcd7e87b0d [FIXED HUDSON-4392] call Util.rawEncode on slaveName in jnlp url
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 18:51:33 +00:00
mindless d47993cfc6 [FIXED HUDSON-4333] rename constructor param from defaultvalue to defaultValue
so it works properly with @DataBoundConstructor


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21553 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 17:40:51 +00:00
abayer c13c7f94f0 [FIXED HUDSON-4423] Properly setting blockBuildWhenUpstreamBuilding now
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21550 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 16:03:12 +00:00
mindless f7e9b4fbd1 Replace uses of /fieldCheck validator with clazz="required" client-side validation.
Marked Hudson.doFieldCheck as deprecated.
Also a few more escape->encodeURIComponent.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21549 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 01:27:07 +00:00
mindless 5491cb256a [Util.rawEncode] Change complicated if expression to simpler array lookup
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21537 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-08 17:26:13 +00:00
kohsuke 3f20513201 allow multi-level CLI target resolution, so that resolution of Run can piggy back on that of Job, and so on.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21497 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 23:31:17 +00:00
kohsuke cbf4b41080 made multiple @Argument work co-operatively.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21485 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 14:48:11 +00:00
mindless 22b729ff81 Add authentication support in hudson.Main (if username/password are included in
HUDSON_HOME URL, then include Authorization header in Hudson http requests).

Also moved Functions.isUnitTest to Main.isUnitTest, to remove dependency on
winstone.jar for running hudson.Main (Main uses EnvVars which checks isUnitTest
flag.. in Functions which uses servlet classes).

Updated http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs
with info about required jars and authentication.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21479 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 04:49:03 +00:00
kohsuke 940fc1c658 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21450 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-04 01:30:37 +00:00
kohsuke 5167a64490 added a mechanism to perform a method parameter binding for CLI, which is somewhat akin to how Stapler performs a method parameter binding for HTTP requests.
This makes it much easier to expose CLI commands from existing model objects.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21448 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-04 00:44:57 +00:00
kohsuke 1642a98e64 turns out these are unnecessary.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21446 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-03 23:46:24 +00:00
kohsuke 65de7809ba recording these code before I delete them.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21445 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-03 23:45:47 +00:00
kohsuke f1577378b3 been here too long to claim it's still experimental.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21397 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-03 00:36:30 +00:00
pgweiss e9def49a05 If a project is not set for concurrent builds and there is more than one job
in the queue (e.g. if the build is parameterized), then don't make more than
one of them runnable.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21365 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 19:11:20 +00:00
mindless b07d3d007d Add validator and submit-time checks for axis names; uses Hudson.checkGoodName now,
though probably could be even more restrictive since these are used as shell variables.
Also added duplicate name check when form is submitted.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21340 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 03:48:16 +00:00
mindless 480dd9898d Make validator for new job name warn about invalid characters (instead of not
getting this error until you click Ok).
Make ComputerSet store the trimmed name when adding a new slave.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21332 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 01:05:54 +00:00
kohsuke 9a3caa1d31 Fixed a regression in 1.112. Adding more tests about i18n chars.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21325 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 20:07:18 +00:00
abayer feb3b5b508 [FIXED HUDSON-1938] Moved Maven project's block when upstream is building functionality up to AbstractProject. Now available as advanced option for all project types
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21323 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 16:39:26 +00:00
kohsuke 3b67a0847d [FIXED HUDSON-4245] Fixed a bug in the tabular display of a matrix. Will be in 1.323.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21322 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 16:07:43 +00:00
mindless acc727d626 [FIXED HUDSON-2670] Matrix project includes axis values in URLs..
add encoding when needed for characters in these values, particularly /

- Use Util.rawEncode in AbstractItem.getShortUrl() so that axis values
  needing encoding will be encoded
- STAPLER-8 fix makes Stapler properly parse a URL with %2F (don't 
  split on %2F, only a real /)
- Stapler fix also makes urls generated via Ancestor class maintain proper encoding
- Add MatrixBuild.RunPtr.getShortUrl() and use this in MatrixBuild/ajaxMatrix.jelly
  so links to combinations are properly encoded
- Use Util.rawEncode in MatrixProject.getRootDirFor() so directories created on
  the filesystem won't use illegal characters; matching decode() in
  MatrixProject.loadConfigurations()



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21321 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 16:02:38 +00:00
sogabe d934a5dafc i18n & Japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21318 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 10:33:39 +00:00
kohsuke faaf185362 Footer now includes a timestamp
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21305 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 01:19:59 +00:00
kohsuke 65f2c1fffa moved the method to where it belongs to.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21256 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-30 19:52:36 +00:00
kohsuke ef84348861 follow up fix to rev.21175.
- toString -> getShortDescription so that ParameterValue.getShortDescription() can explain what this method is expected to return.
- added proper HTML escape to avoid XSS vulnerability.
- modified to use StringBuilder for string concatanation.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21252 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-30 16:33:39 +00:00
mindless 96bae19e4c [HUDSON-4344] urlencode name when redirecting to rename?newName=..
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21208 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-29 17:51:00 +00:00
pgweiss 427dd0fdb1 Expand the tooltip of a queued item to include the parameters if it is for a parameterized build.
This is very useful when you are using the parameterized trigger plugin and have dozens of queued
jobs -- you can now know which jobs to kill.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21175 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-28 22:16:22 +00:00
lifeless dec6b35bd2 - Moves LabelFinder to hudson.model, as its a core facility, not necessarily a
task or even slave related.
- Removes all caching of labels. Slow extensions can cache (see nodetags).
- Pulls up common implementations of getAssignedLabels and an immutable
  getDynamicLabels facility into Node. getDynamicLabels was previously public,
  but never exported.
- factored out some trivially duplicated code into Node.getHudsonlabel
- changes LabelFinder to return Collection<Label> as that is the data that
  higher layers want to work with, and there is no good reason to force lookups
  when implementations can and should cache themselves.
- Deletes OSLabeler, a disabled version of the LabelFinder extension point -
  there is no need for dead code to be keep in the tree.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21160 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-28 10:47:25 +00:00
mindless 2999b2c405 [FIXED HUDSON-4286] Changed health level boundaries from 0-19, ... 80+
to 0-20, 21-40, ... 81+ and removed hack in Job.java lowering build health
scores by one so 4/5 wouldn't be "sunny".  Now 80 is in the 2nd bracket so
hack not needed.
Left image filenames unchanged for compatibility, in case anyone uses
these images for other things.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21152 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-28 03:39:29 +00:00
kohsuke 3236c56d3b Exposing load statistics to the remote API.
(<a href="http://www.nabble.com/time-in-queue-td25127970.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21147 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-28 02:02:54 +00:00
kohsuke c09523609e i18n and clarified what it was trying to install, since that's not obvious.
See http://www.nabble.com/Don%27t-understand-build-messages...-td25177740.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21144 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-28 01:16:20 +00:00
abayer 00afaa5263 [FIXED HUDSON-4056] Added support for marking a new plugin version as configuration-incompatible with previous versions - see http://wiki.hudson-ci.org/display/HUDSON/Marking+a+new+plugin+version+as+incompatible+with+older+versions
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21097 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-26 19:46:36 +00:00
kohsuke cbb3e313ad Merged revisions 20928-20929,20939,20974-20975,20988,21009,21011,21015 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r20928 | kohsuke | 2009-08-19 14:47:13 -0700 (Wed, 19 Aug 2009) | 1 line
  
  test bug fix.
........
  r20929 | kohsuke | 2009-08-19 14:48:23 -0700 (Wed, 19 Aug 2009) | 1 line
  
  bumped up to a new version that has a trouble-shooting hook for resetting cached views
........
  r20939 | kohsuke | 2009-08-19 15:20:57 -0700 (Wed, 19 Aug 2009) | 1 line
  
  picking up subversion 1.5
........
  r20974 | kohsuke | 2009-08-20 11:50:04 -0700 (Thu, 20 Aug 2009) | 3 lines
  
      Hudson can make mistakes in binding plugins to their right /plugin/NAME/ URLs.
      (<a href="http://www.nabble.com/Custom-Plugin---No-external-resources-available-td25064554.html">report</a>)
........
  r20975 | kohsuke | 2009-08-20 12:05:11 -0700 (Thu, 20 Aug 2009) | 1 line
  
  Build history AJX update was buggy.
........
  r20988 | kohsuke | 2009-08-20 17:01:57 -0700 (Thu, 20 Aug 2009) | 3 lines
  
      Hudson wasn't working on WebLogic on Windows.
      (<a href="http://www.nabble.com/Re%3A-Hudson-on-Weblogic-10.3-td25038378.html#a25043415">report</a>)
........
  r21009 | kohsuke | 2009-08-21 14:21:35 -0700 (Fri, 21 Aug 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-
........
  r21011 | kohsuke | 2009-08-21 14:22:00 -0700 (Fri, 21 Aug 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r21015 | kohsuke | 2009-08-21 16:00:17 -0700 (Fri, 21 Aug 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21095 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-26 15:13:55 +00:00
kohsuke 734abf2a82 Labels for nodes are shown in a tag cloud style. Compared to the patch, the following changes are made:
- fixed a divide-by-0 problem if every weight is 0.
- Stapler prefers a typed data structure over bare Map, so TagCloudFactory is changed to TagCloud.
- There are different tag cloud rendering for the same model, so the weight assignment is pushed outside the item. For example, labels can be made into a tag cloud via # of slave / # of tied jobs, etc.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21086 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-26 01:09:35 +00:00
mindless cd6a71af00 [FIXED HUDSON-4301] Creation of symlinks failed (or created in wrong location) since 1.320.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21046 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-24 21:36:34 +00:00