Commit Graph
2493 Commits
Author SHA1 Message Date
Daniel Beck de740c756f [FIX JENKINS-18114] Exclude /cli URL from crumb requirement (#2315)
* [FIX JENKINS-18114] Exclude /cli URL from crumb requirement

* [JENKINS-18114] Fix test: Don't send the crumb

The CLI doesn't do this either.
2016-09-22 17:02:06 +02:00
Oliver Gondža 0ba90615c7 Present stacktrace when throwable attached to Descriptor.FormException 2016-09-20 10:00:51 +02:00
Oliver Gondža d988964d5f Fix test class declaration 2016-09-05 16:29:57 +02:00
Felix Belzunce Arcos 4278804582 [JENKINS-36748] Do not process null specs in triggers (#2482)
* [JENKINS-36748] Add a test case and not process null specs

* [JENKINS-36748] Correct license and add a minor comment

* [JENKINS-36748] Add a Waning logger when spec is null
2016-08-25 01:14:06 +02:00
Jesse Glick e94c399139 Simplified HTTP calls with basic auth. (#2441) 2016-08-08 20:35:31 +03:00
Kohsuke Kawaguchi 172df6a7df [FIXED JENKINS-37223]
Added a simple diagnostic HTTP response to the TcpSlaveAgentListener.
2016-08-05 12:59:40 -07:00
Vincent Latombe dff8e806b9 [JENKINS-21486] Only consider plugins detached before the current
version
2016-07-29 14:33:56 +02:00
Vincent Latombe 43ddbdfc1c [JENKINS-21486] Fix plugin dependencies resolution
* Check that dependencies are enabled. A disabled optional dependency
  will not prevent a plugin from loading.
* Check versions of dependencies declared by a plugin before loading it.
  If any dependency (even optional) is older than what is required,
  then the plugin isn't loaded.

This should prevent use cases where a plugin is loaded but one of its
dependencies is too old so that :
* its @Extension annotated classes cannot be loaded, causing the full
  Jenkins to blow up with crapload of exceptions which are tedious to
  investigate to understand the root cause.
* NoSuchMethodError and the likes at runtime even though boot has
  completed.

Version check (for setups where version list is manually crafted but yet
works) can be disabled by starting Jenkins with

-Dhudson.PluginWrapper.dependenciesVersionCheck.enabled=true

Minor fixes done while implementing this change :
* Fix version parsing in PluginWrapper.Dependency
* Dynamic plugin load didn't check for disabled flag
2016-07-29 14:31:41 +02:00
Jesse Glick 81bc2ef348 Merge pull request #2484 from jglick/ArtifactArchiver.excludes-JENKINS-29922
[JENKINS-29922] Correct the default value handling of ArtifactArchiver.excludes
2016-07-28 14:14:55 -04:00
Jesse Glick edfffb160a Merge pull request #2478 from jglick/Test2
Tests are not run unless the class name ends with "Test"
2016-07-28 11:02:11 -04:00
Alvaro Lobato 404384eefe [JENKINS-36908] Make sure that the All view is created (#2472)
* [JENKINS-36908] Make sure that the All view is created

* Revert old All view behaviour

* Fix changed comment

* Tests

* Delete unwanted file.
2016-07-27 18:31:29 +02:00
Jesse Glick cd24167458 [JENKINS-29922] Correct the default value handling of ArtifactArchiver.excludes. 2016-07-27 10:29:25 -04:00
Stephen Connolly a8ee5752b9 Noting merge of PR#2480 and integrate instance-identity 2.1 release 2016-07-27 14:35:07 +01:00
Stephen Connolly d7f62a29a6 Merge pull request #2480 from stephenc/jenkins-36871-prep
[JENKINS-36871] Allow accessing instance identity from core
2016-07-27 13:47:47 +01:00
Stephen Connolly 80af6cb000 [JENKINS-36923] Make the UsageStatisticsTest less brittle
- We now check the format and assure that all detached plugins are reported
2016-07-26 21:08:56 +01:00
Stephen Connolly 0faae72f36 [ENKINS-36923] Add a test for the /instance-identity root action 2016-07-26 20:10:24 +01:00
Stephen Connolly 0ec686ef65 [JENKINS-36871] Add a test for the slave agent listener 2016-07-26 17:44:31 +01:00
Jesse Glick 9a056c591b Correcting a typo in the original test. 2016-07-25 18:46:35 -04:00
Jesse Glick a264bfca75 Tests are not run unless the class name ends with "Test". 2016-07-25 18:38:58 -04:00
Daniel Beck 321cd04dc2 Merge pull request #2396 from pjanouse/JENKINS-34915
[JENKINS-34915] CLI commands wait-node-online/wait-node-offline extracted from core to CLI
2016-07-25 11:42:40 +02:00
Daniel Beck 44a9e2b799 Merge pull request #2455 from rsandell/JENKINS-18435
[JENKINS-18435] Tell browsers not to cache or try to autocomplete forms
2016-07-22 14:44:56 +02:00
Ing. Pavel Janousek cb8e9ec5e9 [JENKINS-34915] CLI commands wait-node-online/wait-node-offline extracted from core to CLI
wait-node-online and wait-node-offline covered by test-cases
2016-07-21 15:52:08 +02:00
Pavel Janousek fb7458f2e6 [JENKINS-34468] CLI command offline-node extracted from core to CLI (#2392)
* [JENKINS-34468] CLI command offline-node extracted from core to CLI

offline-node extended to accept multiple node names
offline-node covered by test-cases

* Fixed translation properties

* Fixes based on Oleg's comments

* Fixed HelpCommandTest test-case

* Minor fixes

* Uses Matchers.instanceOf everywhere instead of Java operator instanceof
2016-07-20 15:30:09 +03:00
Robert Sandell 538332385e Merge remote-tracking branch 'origin/master' into JENKINS-35493 2016-07-18 17:36:56 +02:00
Oleg Nenashev 055457d0b8 Merge pull request #2457 from oleg-nenashev/bug/JENKINS-36193
[JENKINS-36193] Raise exception when trying to build a job that is disabled
2016-07-16 22:16:20 +03:00
Jesse Glick c31392d140 [JENKINS-36476] Underprivileged users could not use the default value of a password parameter (#2454)
* [FIXED JENKINS-36476] Do not even send the default password in encrypted form; leave the text field blank, and apply the default upon submission.

* [JENKINS-36476] Use a special token, not the empty string, as the marker for the default value.
2016-07-16 22:14:48 +03:00
Oleg Nenashev 8a330acc5e [JENKINS-36193] - Add direct unit test for the issue 2016-07-15 17:33:29 +03:00
godfath3r 439426236f [JENKINS-36387] Catch exception when scm retry count field is empty. (#2433)
* [JENKINS-36387] Catch exception when scm retry count field is empty.

* Add test for JENKINS-36387

* [JENKINS-36387] Move test in correct place

* [JENKINS-36387] Reproduce actuall behaviour
2016-07-14 21:18:45 +04:00
Stephen Connolly 2e533ef7a0 Merge pull request #2451 from stephenc/optimize-recent-build-stability
[JENKINS-36629] Optimization for recent build stability calculation
2016-07-14 16:08:40 +01:00
Robert Sandell 88c2d8ed04 [JENKINS-18435] Tell browsers not to cache or try to autocomplete forms
Setting autocomplete to "off" will tell browsers not to try to autofill
forms during history navigation. Since this seems to be a prominent
problem in Jenkins I feel it is best to have it default to "off" and let
individual inputs or pages opt-in to enable it instead
to indicate they can handle it.
The standard login page does not seem to use the taglib form tag
so it is not affected, even so, all modern browsers ignores
the autocomplete attribute on username and password fields anyway.
2016-07-14 15:49:28 +02:00
Jesse Glick 175aa55c70 Merge pull request #2438 from jglick/LoggerRule
Use LoggerRule
2016-07-13 10:17:03 -04:00
Stephen Connolly b7c0d93de8 [FIXED JENKINS-36629] Add a test
The test found out that RunMap's subMap implementation only returns loaded builds, so we needed to introduce a method to test if there was a specific run on the disk. For the weather reports we do not care if the record on the disk fails to load
2016-07-12 17:46:31 +01:00
Pavel Janousek b21ab921de [JENKINS-35570] List of computer's names extracted to Util (#2408)
* [JENKINS-35570] List of computer's names extracted to Util
2016-07-12 09:13:33 +02:00
Oliver Gondža e750cd3511 Merge pull request #2420 from pjanouse/JENKINS-35423
[JENKINS-35423] CLI commands quiet-down/cancel-quiet-down extracted from core to CLI
2016-07-12 09:10:16 +02:00
Stephen Connolly bb4eb45fb3 Merge pull request #2437 from stephenc/jenkins-36494
[FIXED JENKINS-36494] Switch to a try with resources form of impersonation
2016-07-11 21:28:56 +01:00
Jesse Glick b6dfdf4c8e Merge branch 'master' into LoggerRule 2016-07-11 11:05:00 -04:00
Robert Sandell fefd61c87d [JENKINS-35493] Introduce a UserDetails cache
to fix performance regression after SECURITY-243
2016-07-11 15:08:17 +02:00
Jesse Glick 3ef1db59ea Merge pull request #2439 from jglick/nextBuildNumber-JENKINS-27530
[JENKINS-27530] nextBuildNumber snafu after reload
2016-07-08 18:51:22 -04:00
Jesse Glick e98910377b Adapted to changes in LoggerRule. 2016-07-08 10:23:50 -04:00
Jesse Glick 0969e0a381 Another unnecessary call to doYank. 2016-07-07 23:31:22 -04:00
Jesse Glick 7a3b176495 Remove the concept of yanking dead executors. 2016-07-07 23:16:36 -04:00
Jesse Glick 12fd3e47e3 [FIXED JENKINS-27530] Jenkins.reload must also reload the Queue to ensure that every Queue.Item.task corresponds to a live Job, lest nextBuildNumber be bogus. 2016-07-07 20:50:54 -04:00
Jesse Glick 0d4f9a5841 @oleg-nenashev created a BasicCredentialsProvider for SetupWizardTest but seems to have never used it. 2016-07-07 20:28:25 -04:00
Jesse Glick c69a0cd762 Use LoggerRule. 2016-07-07 20:20:47 -04:00
Stephen Connolly 0203504a2c [FIXED JENKINS-36494] Switch to a try with resources form of impersonation 2016-07-07 11:46:45 +01:00
Oleg Nenashev 0b8febbdc3 [JENKINS-25416][JENKINS-28790] - Fix the parametersReferencedFromPropertiesShouldRetainBackslashes() test, which relies on the legacy behavior (#2435)
The test fails after https://github.com/jenkinsci/jenkins/pull/1976/commits/84ee34f2df620f1280022f1678b81e5c27dfc330
2016-07-05 12:09:05 +02:00
Oliver Gondža e66e719f1e [FIXED JENKINS-25416][JENKINS-28790] Do not inject build variables into maven process optionally (#1976)
* [FIXED JENKINS-25416][JENKINS-28790] Do not inject build variables into maven process optionally

* [JENKINS-25416][JENKINS-28790] Fixed typo in test method name

* [JENKINS-25416][JENKINS-28790] Suggest alternatives in help

* [JENKINS-25416][JENKINS-28790] Use less hackish approach to preserving legacy behaviour
2016-07-02 21:27:50 +02:00
Stephen Connolly 5a0d7ece6a Merge pull request #2427 from stephenc/jenkins-36280
[FIXED JENKINS-36280] Enable DescriptorVisibilityFilter for Slave's C…
2016-07-01 17:06:45 +01:00
Kohsuke Kawaguchi 213363d387 Merge pull request #2428 from jenkinsci/closeable-bulkchange
Make BulkChange auto-closeable
2016-06-30 08:10:36 +09:00
Jesse Glick b7a7c81f41 Stray import. 2016-06-29 13:25:40 -04:00