(Note: mainly bumping for the CI to not fail since I was never able to
see this test fail on my machine [takes ~17 with this change] anyway
other than by running in Docker and aggressively reduce IOPS to 40 using
Docker resource constraints.)
Since we now *actually* sync to disk, this isn't really a regression IMO.
From the very role of AtomicFileWriter, it looks more like a feature or
an improvement than an issue.
So I suspect that anyway 1) we won't see
a lot of bad impact in the wild on most setups (as we generally already
recommend SSDs and so on as per how Jenkins works) and 2) we win anyway
in term of integrity by making sure (well, raising the chances, let's
say) we do write to disk before renaming files.
* [JENKINS-48157] - Reproduce the issue in test
* [JENKINS-48157] - Annotate and document nullness conditions in MyViewsProperty and ViewGroupMixIn
* [FIXED JENKINS-48157] - Prevent NPEs when using public API and when using null primaryViewName
* [JENKINS-48157] - Fix typo in Javadoc
```
WARNING] Rule 3: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps fai
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for org.objenesis:objenesis:2.1 paths
+-org.jenkins-ci.main:test:2.92-SNAPSHOT
+-org.mockito:mockito-core:1.10.19
+-org.objenesis:objenesis:2.1
and
+-org.jenkins-ci.main:test:2.92-SNAPSHOT
+-org.awaitility:awaitility:3.0.0
+-org.objenesis:objenesis:2.5.1
```
Also reduce the time 250 ms (instead of 1 second previously) between
retries to hopefully reduce the test duration on quick enough setups,
and still degrade nicely on less performing ones.
* [JENKINS-34138] Adding equals/hashCode methods so that installs don't step on each other
* [JENKINS-34138] Added issue reference to unit tests
* [JENKINS-34138] - changed the order of equals / hashcode
* Avoid having "authenticated" twice in the group membership of a user
- this occur when the SecurityRealm potentially already grants that role (like in github-oauth-plugin)
* - changed as requested by Oleg
- the list has a maximum of roles.length and in reality it's either roles.length or (roles.length-1), so the maximum is ok
* - fix problem of missing the "authenticated" authority
* - convert the Groovy script to a Java version
- the Groovy test was not run by default (IIUC Groovy scripts are not compiled if placed in java src folder)
* [FIXED JENKINS-47181] - Recover the agent protocol handling tests.
The protocol handling logic does not longer use bogus assumptions anymore.
Instead of that, there are extra `MockAgentProtocol` instances (to be moved to JTH?)
* Extremely important fix to retrigger the PR builder
* JENKINS-47426: getPropertyKey is not consistent over time
- add passing test for the case the rootUrl is set
- add failing test for the case the rootUrl is not set yet, the propertyKey is not consistent
- add a warning message when the flow passes in the fallback mode
* - fixing the getEncryptedValue using a static memory
* - add issue annotations
* - modifications proposed by Jesse: use legacyId instead of randomId, stable over restart
* - small correction for a test case
Baptiste Mathus