Commit Graph
2253 Commits
Author SHA1 Message Date
frizbog f76fdaec10 Issue 1634. Changed failed authentication so try again link keeps track of where you were when you tried logging in, and the login link returns you to the top page if you click it while logging in.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9623 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-25 00:20:58 +00:00
kohsuke 32913046e2 [FIXED HUDSON-1672] Fixed NPE in fingerprinting. Will be in 1.219
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9617 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 21:34:57 +00:00
kohsuke f10090e2b8 [FIXED HDUSON-1648]
A debug code crept in. When Hudson's own user database is used, every user got the "admin" role.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9616 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 21:19:44 +00:00
kohsuke 704343f57e [FIXED HUDSON-1458] Fixed the mysterious JVM hang issue on Windows&Maven2.
I spent a good part of yesterday afternoon to track down this problem. I first attached Visual Studio to the hanging JVM. While I can see the JVM source code and Windows API symbols all right, I couldn't figure out how to relate back the code produced by JIT to its Java, so this made the debugging very hard.

What I observed was that Maven's main thread seems to be blocked in WaitForSingleObject kernel API, but I can't figure out what handle it's blocking on. This call appears to come directly from JIT-ed Java code.

The problem disappears if I enable Java debugger support, or if I attach jconsole. So this cannot be a plain Java-level deadlock.

So after that much work, I still coudldn't figure out the root cause.


But I took the advice from mriem@dev.ajva.net anyway, and modified the remoting to use a separate TCP socket, instead of stdin/stdout. This is useful anyway, because sometimes JVM writes out to stdout and that breaks the whole set up, which was one of the known issues.

This commit brings in this change, and in the limited testing so far, this appears to work. So let's hope that it fixes the problem once and for all.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9615 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 20:48:09 +00:00
kohsuke f70901a7c6 when the slave is offline, don't crap out.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9612 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 17:43:09 +00:00
kohsuke 38953b8869 [FIXED HUDSON-1589] Applied a patch from thepner.
My apologies for the delay in handling this.
This change will be in 1.219.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9609 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 15:18:57 +00:00
kohsuke 82a594f496 [FIXED HUDSON-1730] Tagged builds will get a badge, just like locked builds
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9605 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 06:22:01 +00:00
kohsuke d9840234a7 [FIXED HUDSON-1734] applied a patch from rfaber@dev.java.net. In 1.219
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9592 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-22 21:18:18 +00:00
kohsuke bbc9229cf9 prevent new builds during deletion.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9536 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 23:43:43 +00:00
kohsuke 81eaa8af55 rolling back the synchronizatoin in closeChannel() for now to avoid NPE as discussed in "hudson 1.217 issue -" Please wait while hudson is getting ready to work..."
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9511 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 19:42:22 +00:00
stephenconnolly d6a3e23e2c public domain version from http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/TimeUnit.java?view=markup
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9510 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 19:40:12 +00:00
stephenconnolly fa2d986480 this call to launch causes a partially constructed object to escape the constructor.
I think this is the safest quickest fix until the proper fix is implemented

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9507 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 19:32:38 +00:00
kohsuke 739b625f26 needs to use the same listener or else the later will clover the former log.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9498 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 16:20:09 +00:00
kohsuke 0b2c506dbd removed TimeUnit2, which is under GPL and hence incompatible.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9497 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 16:19:05 +00:00
stephenconnolly 579c390ef6 I am unsure as to whether we should expose the closeChannel method on a SlaveComputer and have just one disconnect method, or use this before and after pair of methods to allow for tidy termination...
Also, I think there was a missing synchronized(channelLock) in closeChannel... now I'm wondering if the entire disconnect runnable should hold that lock... but it could be long running!

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9494 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 08:15:51 +00:00
stephenconnolly 70adc6fec1 backport of JDK 6 version of TimeUnit... it's just too handy to be able to convert from MINUTES, etc
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9492 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-21 08:08:01 +00:00
stephenconnolly b002fdbc7a VMware will need a hook to shutdown the slave after disconnecting
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9483 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-20 22:14:32 +00:00
kohsuke 544f5d3e5f fixed the serialization error.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9472 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-20 17:00:42 +00:00
kohsuke f66c670f25 added more debug probe
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9465 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-20 06:11:14 +00:00
kohsuke 25514b706b id is only used for sorting
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9463 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-20 00:06:01 +00:00
kohsuke 4a0d9d907d Information about how a task moves through various stages in the queue is very useful
for both smarter scheduling and better slave management. For that, we need to have
a real object to attach information to.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9462 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-20 00:04:37 +00:00
kohsuke b02f945dc3 field name changed to clarify the meaning.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9461 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 22:57:20 +00:00
kohsuke e7780ebd10 <p/> is not the right usage of the p tag.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9460 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 22:47:45 +00:00
kohsuke f855aa11bf doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9459 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 22:46:39 +00:00
kohsuke 6c5a18da8b doc fix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9458 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 22:43:41 +00:00
kohsuke 2e243b8841 if the workspace is locked, wipe out and retry.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9456 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 22:34:11 +00:00
stephenconnolly f07faa5060 defensive against negative or zero delays
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9447 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 04:02:01 +00:00
stephenconnolly db07f253fc better to have the demand start utility method in computer... it keeps the retention strategies simpler
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9446 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 03:50:45 +00:00
stephenconnolly c71690b7ca better logging
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9445 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 03:46:06 +00:00
stephenconnolly 7060c5ffdd Better idle and in demand detection
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9444 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 03:42:12 +00:00
stephenconnolly 8c2eb94bb6 defensive for estimates that are unknown
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9443 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 03:12:13 +00:00
stephenconnolly 0072bda2c8 adding utility methods to allow querying how long a computer has been idle
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9442 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 03:06:27 +00:00
stephenconnolly 70a842f9f1 retention strategy working with log statements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9440 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 02:48:04 +00:00
stephenconnolly a0df4e2745 adding a demand retention strategy
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9436 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 01:57:40 +00:00
kohsuke c3fc898bd6 [FIXED HUDSON-1705] In case of abnormal termination, kill the process
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9434 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 01:07:43 +00:00
kohsuke 3b1cd40f52 StaplerRequest is not required if it's not used.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9426 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 00:04:28 +00:00
kohsuke e544f4dbd5 No need to show an option if there's only one choice.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9423 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-19 00:02:34 +00:00
kohsuke b29a6a1d73 fixed initialization order bug.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9421 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:52:35 +00:00
kohsuke 421ec30849 more renaming to align with the new name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9417 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:42:52 +00:00
kohsuke 8996827225 more renaming to align with the new name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9416 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:38:27 +00:00
kohsuke 930ffc0768 Renamed to reflect what it really does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9415 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:36:04 +00:00
kohsuke 5450534dc8 fixed a problem in the initialization order issue.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9414 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:32:20 +00:00
davidseymore e25747c341 fix for #1539.. svn:externals can have externals in them... the path needs to be appended for revisions to be properly recorded
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9411 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:11:52 +00:00
kohsuke 8b8ff2fb36 more renaming
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9410 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:51:57 +00:00
kohsuke ce2614e121 Renaming to reflect what it really does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9409 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:44:43 +00:00
kohsuke efcfe5d1d6 Renamed to reflect what it really does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9408 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:41:23 +00:00
kohsuke c2d95bcab3 moving the initialization code to the proper place.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9407 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:39:30 +00:00
kohsuke f7a131f85d still reserving the rights to change this signature
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9406 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:38:44 +00:00
kohsuke 28dbb672ca clarifying the role of Computer a little.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9405 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:37:08 +00:00
kohsuke 0a4746751f needs NOOP for the master.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9404 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:36:19 +00:00