Commit Graph
7509 Commits
Author SHA1 Message Date
Daniel Beck 578c028e2c [SECURITY-3669] 2026-02-15 03:32:45 +00:00
Daniel Beck f92eadb581 [SECURITY-3658] 2026-02-15 03:32:39 +00:00
Jan Faracik f972b9d819 Refine the 'New Item' screen (#26031)
* Refine the 'New Item' screen

* Simplify SCSS

* Fix submission, fix some tests, improve tabbing + focus states

* Fix more tests

* Simplify JS + hopefully fix test

* Update pom.xml

* Update Jenkinsfile

* Fix issue noticed in #26069

* Restore Jenkinsfile/test pom

* Simplify JS

* Restore ability to have headings

* Fix focus state in Firefox/Chrome

* Add separator between items and 'Duplicate an item'
2026-02-09 11:13:17 -07:00
renovate[bot] ff119772a7 Update dependency org.jenkins-ci.plugins:credentials to v1487 (#26280)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-02-07 19:02:16 -07:00
renovate[bot] 97c40d28ca Update dependency org.jenkins-ci.plugins:script-security to v1399 (#26266)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-02-06 17:03:47 -07:00
renovate[bot] 7fad3c0553 Update dependency org.jenkins-ci.plugins:scm-api to v728 (#26265)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-02-06 17:03:30 -07:00
renovate[bot] 845f6c023a Update dependency org.jenkins-ci.plugins:cloudbees-folder to v6.1079.vc0975c2de294 (#26264)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-02-06 17:03:15 -07:00
renovate[bot] 0d2efe4bbc Update dependency org.jenkins-ci.plugins.workflow:workflow-support to v1015 (#26247)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-02-06 17:01:37 -07:00
6227cd1091 Do not compute CSP header if disabled (#26255)
* Do not compute CSP header if disabled

* Replace waiting with counting invocations

* Replace waiting with counting

---------

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Kris Stern <88480540+krisstern@users.noreply.github.com>
2026-02-07 00:56:10 +01:00
Mark Waite f72718b747 Do not run symlink tests on Windows if symlinks are not supported (#26203)
* Do not run symlink tests on Windows if symlinks are not supported

Windows does not support symbolic links by default.  Tests fail for new
contributors on Windows if they do not adjust their Windows configuration
to allow symbolic links.

* Fast incremental build

* Create a symbolic link on Windows to confirm they are supported

* Fix the copyright year - 2026

GitHub Copilot caught the mistake

* Remove a white space change

* Revert "Fast incremental build"

Don't change production

This reverts commit 0750dd8bc5.

* Fail tests on CI if Windows symlinks are not enabled

We do not want to fail the test on a developer computer if symlinks are
not enabled, but we do want to fail the test if a CI agent on Windows
does not have symbolic links enabled.
2026-02-02 13:07:58 -07:00
renovate[bot] 587f636791 Update dependency org.jenkins-ci.main:jenkins-test-harness to v2553 (#26239)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-02-01 21:29:18 -07:00
renovate[bot] d3e912e350 Update dependency org.jenkins-ci.plugins:junit to v1396 (#26200)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-29 17:42:34 +01:00
renovate[bot] a71fe2bb67 Update dependency io.jenkins.plugins:prism-api to v1.30.0-703.v116fb_3b_5b_b_a_a_ (#26208)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-28 11:50:38 +00:00
Markus WinterandTim Jacomb 5490f91afa API tokens with expiration date (#23859)
* API tokens with expiration

API tokens can now get an optional expiration date.
Added a select drop down from where you can choose from predefined
durations, a custom date (max 1 year) and no expiration.
Expiration date is shown in the list. Not expiring tokens are marked
with warning.

fixes #16695

* revert changes in SetupWizard

* fix linter

* fix ordering

* show when token expired

* notify on expiring and expired tokens

* format

* 2 lines only

make the creation date a tooltip of the expiration

* feedback

* feedback 2

don't add token when choosing date in the past

directly warn after creation when about to expire

* prettier

---------

Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
2026-01-25 20:28:34 -07:00
strangelookingnerdandMark Waite 4a2f5f24b9 Migrate code base to Java 21 (#26075)
* Replace if-cascades with switch

* Reference to empty collection field replaced with method call (Java 5)

* Anonymous type replaced with lambda (Java 8)

* Replaced lambda with method reference (Java 8)

* Statement lambda replaced with expression lambda (Java 8)

* Loop replaced with 'Collection.removeIf()' (Java 8)

* Null check replaced with method call (Java 9)

* Statement replaced with enhanced 'switch' (Java 14)

* Use text blocks (Java 15)

* Use pattern variable (Java 16)

* Replace if-cascades with switch

* Use 'Comparator' combinator

* Null check replaced with method call (Java 9)

* Use pattern variable (Java 16)

* Use record pattern (Java 21)

* Use SequencedCollection method (Java 21)

* Replaced lambda with method reference (Java 8)

* Cleanup unused imports

* Cleanup migrations (move comments, formatting, spotbugs...)

* Remove duplicate comment

Resolve GitHub Copilot review comment

* Remove blank line that may confuse Copilot

* Inject comments into source line

Attempt to satisfy GitHub Copilot

Complains about unreachable code

* Simplify with return value of switch statement

* Use pattern matching instanceof in one more case

* Don't lose the NetBeans comment that was there before

* Remove TODO for Java 21 pattern use, implemented

* Align comments with Unicode character they describe

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2026-01-23 23:31:47 -07:00
renovate[bot] 15a6b4efb4 Update dependency io.jenkins.plugins:prism-api to v1.30.0-701.vf8f8f1f3fd55 (#26167)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-23 11:24:43 +00:00
Markus Winter 620b9021d3 Fix temporary offline state of computer is lost on config submit (#26154) 2026-01-23 10:53:07 +00:00
renovate[bot] 80598c82d8 Update dependency org.jenkins-ci.plugins:credentials to v1480 (#26110)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-16 21:13:29 -07:00
Mark Waite 06a41152b3 Delete builds in QueueTest to prevent Windows test failures (#26104)
* Remove noisy test logging from QueueTest

No one is reading the test logs.  They add megabytes to the output and
may obscure useful messages.

* Stop and delete builds 1 and 2 in QueueTest to prevent Windows test failures

The Windows file system prevents cleanup of the builds and jobs directory
while the test has them open.  Stopping the builds and deleting them is
enough to close the directory and allow it to be deleted.

Testing done:

* Before this change, testGetCauseOfBlockageForNonConcurrentFreestyle
  failed in about 50% of runs on my 7 different Windows agents
* After this change, testGetCauseOfBlockageForNonConcurrentFreestyle
  passes all runs on my 7 different Windows agents
2026-01-12 15:02:04 -07:00
renovate[bot] 33859569a1 Update dependency org.jenkins-ci.main:jenkins-test-harness to v2545 (#26072)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-12 15:01:06 -07:00
Mark Waite 402640d91b Use Matrix Project Plugin in Security914Test, not Credentials Plugin (#26090)
Fixes #26088

The user interface update to the Credentials plugin in pull request:

* https://github.com/jenkinsci/credentials-plugin/issues/990

removed the image that this test used for its initial configuration.
The change was released in Credentials plugin:

* https://github.com/jenkinsci/credentials-plugin/releases/tag/1460.v48765a_c7d849

The new release of the Credentials plugin was included in Jenkins core
with pull request:

* https://github.com/jenkinsci/jenkins/pull/26046

This change switches from the Credentials plugin to the Matrix Project
plugin as the base for the test.  The assumption is that user interface
changes are less likely to the Matrix Project plugin.

Testing done:

* Confirmed that the tests fail on Windows without this change
* Confirmed that the tests pass on Windows with this change
2026-01-08 14:14:40 -07:00
renovate[bot] 5eb869a238 Update dependency org.jenkins-ci.main:jenkins-test-harness to v2544 (#26050)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-05 14:45:24 -07:00
renovate[bot] 4120c2880d Update dependency org.jenkins-ci.plugins:credentials to v1460 (#26046)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-04 20:18:55 -07:00
strangelookingnerd bcbe63159d Bump minimum supported remoting version (#26034) 2026-01-04 20:16:23 -07:00
strangelookingnerd d938a49752 Fix references to RealJenkinsRule.Endpoint (#26020) 2026-01-02 13:35:47 -07:00
renovate[bot] da99a73ee4 Update dependency org.jenkins-ci.main:jenkins-test-harness to v2541 (#26015)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-29 18:18:22 -07:00
renovate[bot] 29b8b139fb Update dependency org.jenkins-ci.main:jenkins-test-harness to v2538 (#25994)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-29 01:04:20 -07:00
Adham AhmedandMark Waite e0f83edfc3 [JENKINS-75905] Include update site URL in signature verification in error messages (#25980)
* [JENKINS-75905] Include update site URL in signature verification error messages

* [JENKINS-75905] Include update site URL in signature verification error messages

* [JENKINS-75905] Include update site URL in signature verification error messages

* Use the non-deprecated getJsonSignatureValidator method and add @NonNull annotation

Use the non-deprecated getJsonSignatureValidator Add @NonNull annotation to the Throwable parameter in JSONSignatureValidator#getRootCauseMessage.

* Test both branches of message formatter

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2025-12-29 01:03:09 -07:00
renovate[bot] 816cc9740a Update dependency org.jenkins-ci.main:jenkins-test-harness to v2537 (#25954)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-19 15:48:49 +01:00
renovate[bot] 6036ff3a76 Update dependency io.jenkins.plugins:design-library to v417 (#25957)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-19 15:48:38 +01:00
07d2ff18a4 Remove IP address from DefaultCrumbIssuer (#25918)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2025-12-18 22:10:03 +00:00
renovate[bot] 587983b3d5 Update dependency org.jenkins-ci.main:jenkins-test-harness to v2535 (#25943)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-18 11:00:40 +01:00
Kevin Guerroudj f341800b26 Update SetupWizardTest to test wizard login (#25939) 2025-12-18 10:58:27 +01:00
renovate[bot]andMark Waite 1bb6359330 Update dependency org.jenkins-ci.plugins:junit to v1380 (#11335)
* Update dependency org.jenkins-ci.plugins:junit to v1380

* Add prism-api as a bundled plugin, required for junit

Since we are including other plugins that are dependencies of junit, it
seems correct to include this plugin that is also a dependency of junit.

Testing done:

* Confirmed that tests pass that were failing prior to this change

Testing to do:

* Plugin BOM
* Acceptance test harness

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2025-12-16 20:11:10 -07:00
Amanraz ThakurandMark Waite 15263a67d9 Fix NPE in ReverseBuildTrigger due to null upstream threshold (#23916)
* Fix NPE in ReverseBuildTrigger due to null upstream threshold (JENKINS-39044)

* Use ReverseTrigger constructor that is not deprecated

Has the same result as the deprecated constructor that was used before.

* Add automated test of JENKINS-39044

If the ReverseTrigger threshold were null, a null pointer exception would
be thrown.  The config round trip operation resets a null threshold to
SUCCESS, so this test reaches inside the job definition and changes the
threshold directly.

Testing done:

* Confirmed that the modified automated test fails when the change to
  ReverseTrigger is removed.
* Confirmed that the modified automated test passes when the change to
  ReverseTrigger is included.

* Link to GitHub issue

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2025-12-15 10:57:19 -07:00
renovate[bot] 9f3978c071 Update dependency org.jenkins-ci.plugins:mailer to v525 (#23891)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-12 20:55:16 -07:00
renovate[bot] ad29675405 Update dependency org.jenkins-ci.plugins.workflow:workflow-support to v1010 (#23907)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-12 20:54:48 -07:00
renovate[bot] beaae46a15 Update dependency org.jenkins-ci.plugins:scm-api to v724 (#11317)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-12 20:53:19 -07:00
renovate[bot] 666bf611d9 Update dependency org.jenkins-ci.main:jenkins-test-harness to v2533 (#25915)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-12 20:48:38 -07:00
renovate[bot] d0438f9c65 Update dependency io.jenkins.plugins:commons-lang3-api to v3.20.0-109.ve43756e2d2b_4 (#25907)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-12 20:47:11 -07:00
renovate[bot] 43dfe0fa9a Update dependency io.jenkins.plugins:commons-text-api to v1.15.0-210.v7480a_da_70b_9e (#25904)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-12 20:46:32 -07:00
Daniel BeckandDaniel Beck 88fdfa9223 Add telemetry for Content Security Policy (#23901)
* Add telemetry for Content Security Policy

* Add license header

* Add header length

---------

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2025-12-12 20:45:02 -07:00
James Nord a29b01739d make the MANAGE permission enabled by default (#23873)
* make the MANAGE permission enabled by default

Removed experimental warning for MANAGE permission and enable it by default.

* update tests to accomodate enabling of Overall/Manage
2025-12-12 20:43:37 -07:00
Daniel BeckandDaniel Beck 9878d67e8b https://github.com/jenkins-infra/helpdesk/issues/4904 (#25927)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2025-12-12 11:38:12 -07:00
Daniel BeckandDaniel Beck 67db13142a Allow entirely disabling CSP headers (#23915)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2025-12-11 13:50:24 +00:00
Daniel BeckandDaniel Beck 52e050e7d6 Update Winstone to 8.1026.v31def012a_f48, add test confirming the CSP response header can be >30KB (#25901)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2025-12-11 13:49:31 +00:00
renovate[bot] dfc98e5fa5 Update dependency org.jenkins-ci.plugins:credentials to v1453 (#23868)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-11 13:48:40 +00:00
Jesse Glick fc8425c69e Windows flake of QueueTest.computerFailsJustAfterCreatingExecutor (#23899) 2025-12-11 05:34:07 -07:00
Daniel Beck efa1816322 [SECURITY-3630] 2025-12-02 13:46:19 +00:00
Kevin-CB 31598feb0a [SECURITY-1166] 2025-12-02 13:46:13 +00:00