Commit Graph
17450 Commits
Author SHA1 Message Date
Tim Jacomb 6a275901d0 Merge pull request #4522 from zbynek/search-resize
[JENKINS-61300] Update search box size on page resize, max width
2020-03-06 11:32:48 +00:00
Tim Jacomb 692c68430f Merge pull request #4541 from daniel-beck/JENKINS-61321
[JENKINS-61321] Fix permission check
2020-03-05 20:32:07 +00:00
Oleg Nenashev 9537ee5154 Show plugin release date in plugin manager (#4535)
* Show plugin release date in plugin manager

* Add at-since

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* Make sorting work property

- Sort independently of sortable.js date parsing magic
- Hide categories when sorting by release date

* Show friendlier labels for the age of plugin releases

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-03-05 10:09:14 +01:00
Tim Jacomb 3ebb9e3592 Merge pull request #4389 from jeffret-b/suppressStack
[JENKINS-60410] Add stack trace suppression into core as a standard behavior.
2020-03-04 18:42:53 +00:00
Tim Jacomb 12cd159367 Merge pull request #4513 from daniel-beck/JENKINS-61166
[JENKINS-61166] Show on 'updates' tab when a warning would be fixed
2020-03-04 18:41:25 +00:00
Tim Jacomb 989945f633 JENKINS-61284 Read only textarea remove grey bar (#4536) 2020-03-04 18:41:09 +00:00
Tim Jacomb 7dbb592b7d Merge pull request #4534 from daniel-beck/nicer-plugin-manager
Improve presentation of plugin categories
2020-03-04 18:40:55 +00:00
Alex Earl 3295aec18e [JENKINS-60788] Add null check to avoid NPE (#4540)
Added a null check on the entryList so that if the schema
is not as expected, there is no NullPointerException caused.
2020-03-04 16:51:27 +00:00
Daniel Beck 96e795c1e8 [JENKINS-61321] Fix permission check 2020-03-04 11:21:38 +01:00
Tim Jacomb 1e5112a106 JENKINS-61285 Fix blank page on configure clouds if no cloud pl… (#4537)
implementation
2020-03-03 09:14:53 +00:00
Daniel Beck 56cf496059 Fix message wording 2020-03-03 05:44:37 +01:00
Felix QueirugaandDaniel Beck fc92da0532 Fix presentation
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-03-03 05:39:38 +01:00
Daniel Beck 060b2c4997 Improve presentation of plugin categories
- Show labels/categories in each plugin entry (supporting filtering)
- Don't have multiple table sections for categories
2020-03-01 07:41:54 +01:00
Sumit Sarin 631f8ba571 [JENKINS-28379] Allow FingerprintFacet to block the deletion of Fingerprint (#4478)
* [JENKINS-28379] Allow FingerprintFacet to block the deletion of Fingerprint

* Syntax improvements + CheckForNull annotation

* Changed method name 'facetBlockingDeletion' -> 'getFacetBlockingDeletion'
2020-03-01 07:26:13 +01:00
Wadeck FollonierandDaniel Beck ae99586fd0 [JENKINS-55070, 59992, 60454, 61192] Correct symptom of missing instance (#4525)
* [JENKINS-55070] Correct symptom of missing instance

* Apply Daniel's proposal

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-03-01 07:24:59 +01:00
Oleg NenashevandDaniel Beck e4843aef44 [JENKINS-61004, JENKINS-60299] - Reintroduce Build History description truncation by default, allow managing/disabling the limit via a system property (#4529)
* [JENKINS-61004] - Reintroduce Build History description truncation by default, allow managing/disabling the limit via a system property

* Apply suggestions from code review by @daniel-beck

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-03-01 07:23:51 +01:00
Jesse Glick 06712954c2 [JENKINS-61197] Skip $WORKSPACE_TMP for root directories (#4527)
* [JENKINS-61197] Skip $WORKSPACE_TMP for root directories

* Documenting amended behavior

* Javadoc
2020-02-29 13:31:23 +01:00
Tim Jacomb 053fb51527 JENKINS-61205 System read - global security configuration (#4524) 2020-02-28 11:20:42 +00:00
Tim Jacomb 47a0be9eda JENKINS-61201 JEP-224 System read - about jenkins (#4520) 2020-02-27 07:47:54 +00:00
StefanSpieker 28cad7f317 Removed unused class stringConverter2 (#4468) 2020-02-26 10:44:02 +00:00
Tim Jacomb d66f19f933 Allow secret to convert to itself (#4516)
Reduces warning logs when exporting config via JCasC
2020-02-25 18:39:38 +00:00
Oleg Nenashev 6985c0e30d Merge pull request #4470 from StefanSpieker/Memoizer
Removed unused deprecated Memoizer
2020-02-25 16:12:11 +01:00
Jeff Thompson 6b68c9e164 Merge branch 'master' into suppressStack 2020-02-24 11:42:36 -07:00
Jeff Thompson 984601d7e4 Merge branch 'suppressStack' of github.com:jeffret-b/jenkins into suppressStack 2020-02-24 11:36:32 -07:00
Jeff Thompson 4786a1c481 Merge branch 'master' into suppressStack 2020-02-24 08:47:10 -07:00
Tim Jacomb 450d87491d Read-only extended read view (#4479)
* Read-only extended read view

* Namespace css, add selector for when read-only

Remove select changes

* Revert change that is no longer in use

* Format radioBlock

* Disable select

* Reduce diff and rename to read only

* More whitespace revert

* Add possibleReadOnlyField to wrap content

* Less diff

* Fix missing tag close

* New line

* Fix another if

* Change if statement to bail out early

* Remove drag and drop re-order when read only
2020-02-24 16:19:08 +01:00
Daniel Beck 3472e10e95 Remove 'auto refresh' feature (#4503)
* Remove 'auto refresh' feature

* Remove obsolete CSS
2020-02-24 16:18:00 +01:00
zbynek 294d011dec Update search box size on page resize, simplify code 2020-02-24 08:51:01 +01:00
Daniel Beck 7cc0628d4c Merge branch 'master' into suppressStack 2020-02-22 23:14:25 +01:00
Mark Waite d99500ff1e Merge pull request #4514 from daniel-beck/fix-note
Update note after this was done wrong yet again
2020-02-22 08:31:59 -07:00
9ead76e210 [JEP-223] Deprecate permissions RUN_SCRIPTS, UPLOAD_PLUGINS, an… (#4365)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-22 15:28:42 +00:00
Tim JacombandDaniel Beck 991f379924 JEP-224 Minimal system read (#4506)
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-22 15:27:52 +00:00
Daniel Beck d9355ff05f Update note after this was done wrong yet again 2020-02-22 00:57:54 +01:00
Daniel Beck 9ec7a736ef [JENKINS-61166] Show on 'updates' tab when a warning would be fixed 2020-02-21 22:29:56 +01:00
Jeff ThompsonandDaniel Beck a9c391073a Adjust math operations for clarity.
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-21 11:54:55 -07:00
Jeff Thompson ec707b3652 Change popup dialog size. 2020-02-21 11:16:18 -07:00
Tim Jacomb 15ad9ea13b Merge pull request #4511 from res0nance/spotbugs-internal-rep
[JENKINS-36720] Spotbugs fixes
2020-02-21 15:18:02 +00:00
Tim Jacomb 8219d504cd Merge pull request #4496 from res0nance/followup
Follow up optimizations to getAllItems() and getItems()
2020-02-21 15:17:25 +00:00
Tim Jacomb 45cf21d2e6 Merge pull request #4510 from res0nance/double-checked
[JENKINS-36720] Fix instances of double checked locking
2020-02-21 15:17:08 +00:00
Oleg Nenashev 824718bce0 Merge pull request #4509 from daniel-beck/force-crumb-issuer2
Always set a crumb issuer
2020-02-21 11:31:29 +01:00
Jeff Thompson df385a88de Adjust jelly for popup. 2020-02-20 16:02:09 -07:00
Tim Jacomb fdfcbc3c7f Merge pull request #4508 from res0nance/spotbugs-version
[JENKINS-36720] Spotbugs fix possible NPE
2020-02-20 16:59:54 +00:00
Tim Jacomb 8175695eef Merge pull request #4505 from jbleduigou/master
Adding french translation for concurrent build help
2020-02-20 16:58:09 +00:00
673a18c637 [JENKINS 60920] header breadcrumbs CSS update (#4463)
* New styles for breadcrumbs and warnings monitor

* Adds the svgxuse polyfill for svg sprites on IE 11

* Created new styles for the page header

- Used the material icons svg sprites to deliver the icons
- Icons are rendered using a <svg> tag

* Create new base styles file and undo changes to the layout-common and style css files

* Fixes and refactor for the new UI CSS code

* Make the new header color and logo section opt-in

- The new UI can be toggled with the -Dui.enableNewUi=true flag

* Rename and refactor the page-header css

- Rename the css class namespace from .main-header to .page-header
- Page header CSS moved into a modules folder and now included on the new-base-styles.css. This is done to avoid loading a separate file everytime.
- Extracted color variables to their own file

* Updated localization for header and admin monitor

- The pageHeader template receives localization strings as props
- Missing translation for the admin monitor on the it, bg and pl locales

* Update core/src/main/resources/lib/layout/layout.jelly

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Most measurements migrated to REMs

* Code cleanup and apply new-ui toggle to the html.jelly file

* Breadcrumb fixes

- Reverts breadcrumb link styling to use nested selectors instead of the .breadcrumbs__link class. The reason is that several plugins would break.
- Shifted margins so that breadcrumbs can be fullwidth in the absence of the auto refresh link

* Implemented some fixes from the feedback received

- Removed box shadow webkit prefix
- Fixed formatting on the breadcrumbs.css and layout-commons.less files
- Renamed the new UI toggle class from _new-ui_ to _ui-refresh_
- Renamed references to the _new ui_ to _v2_

* Created jelly helper to use svg icons

* Fix: restore proper icon for the user on the header

* Fixes for Edge, IE 11 and IE 10

* Improvements on the header and breadcrumbs

- Logo v2 changed and optimized using the svgo frontend https://jakearchibald.github.io/svgomg/
- Refactored the ammonitor insertion code
- Breadcrumbs are no longer capitalized
- Classic logo link no longer stretches past the images
- Fixed classic logo link on IE11
- Updated color of the footer
- Menu items background is also changed when hovering over the menu selector
- Removed copyright notice on top of some files

* Bumped JTH version with the SVG download fix

* Update test/pom.xml

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Added a function to check boolean system properties from jelly

* Fix header links and add svg styles for legacy layout

*  Some bug fixing for the new header

- The ui-refresh changes were not properly being enabled with the boolean system property. Added explicit true check on the jelly templates.
- Added an explicit width for the ui-refresh logo because it would mess with the layout

* Update core/src/main/java/hudson/Functions.java

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

* Do not check the system property on every page render

Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-20 16:57:47 +00:00
Raihaan ShouhellandAdrien Lecharpentier 48ed32ba11 Apply suggestions from code review
Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
2020-02-20 20:17:40 +08:00
Tim Jacomb 71c5fa5bbb Merge pull request #4504 from daniel-beck/JENKINS-61121
[JENKINS-61121] Fix too many open files with resource domain
2020-02-20 07:58:36 +00:00
Raihaan Shouhell c82f5147d0 Fix 2 instances of interal rep leak and a possible handle leak 2020-02-20 10:44:04 +08:00
Raihaan Shouhell e904ec9c74 Fix instances of double checked locking 2020-02-20 07:47:40 +08:00
Daniel BeckandJesse Glick 3bc83e3503 Apply suggestions from code review
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
2020-02-19 15:50:10 +01:00
Daniel Beck 107c8575a4 Always set a crumb issuer 2020-02-19 15:00:31 +01:00