Commit Graph
13051 Commits
Author SHA1 Message Date
Jeff Thompson 6b68c9e164 Merge branch 'master' into suppressStack 2020-02-24 11:42:36 -07:00
Daniel Beck 3472e10e95 Remove 'auto refresh' feature (#4503)
* Remove 'auto refresh' feature

* Remove obsolete CSS
2020-02-24 16:18:00 +01:00
Daniel Beck 7cc0628d4c Merge branch 'master' into suppressStack 2020-02-22 23:14:25 +01:00
9ead76e210 [JEP-223] Deprecate permissions RUN_SCRIPTS, UPLOAD_PLUGINS, an… (#4365)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-22 15:28:42 +00:00
Tim JacombandDaniel Beck 991f379924 JEP-224 Minimal system read (#4506)
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-22 15:27:52 +00:00
Tim Jacomb 15ad9ea13b Merge pull request #4511 from res0nance/spotbugs-internal-rep
[JENKINS-36720] Spotbugs fixes
2020-02-21 15:18:02 +00:00
Tim Jacomb 8219d504cd Merge pull request #4496 from res0nance/followup
Follow up optimizations to getAllItems() and getItems()
2020-02-21 15:17:25 +00:00
Tim Jacomb 45cf21d2e6 Merge pull request #4510 from res0nance/double-checked
[JENKINS-36720] Fix instances of double checked locking
2020-02-21 15:17:08 +00:00
Oleg Nenashev 824718bce0 Merge pull request #4509 from daniel-beck/force-crumb-issuer2
Always set a crumb issuer
2020-02-21 11:31:29 +01:00
Tim Jacomb fdfcbc3c7f Merge pull request #4508 from res0nance/spotbugs-version
[JENKINS-36720] Spotbugs fix possible NPE
2020-02-20 16:59:54 +00:00
673a18c637 [JENKINS 60920] header breadcrumbs CSS update (#4463)
* New styles for breadcrumbs and warnings monitor

* Adds the svgxuse polyfill for svg sprites on IE 11

* Created new styles for the page header

- Used the material icons svg sprites to deliver the icons
- Icons are rendered using a <svg> tag

* Create new base styles file and undo changes to the layout-common and style css files

* Fixes and refactor for the new UI CSS code

* Make the new header color and logo section opt-in

- The new UI can be toggled with the -Dui.enableNewUi=true flag

* Rename and refactor the page-header css

- Rename the css class namespace from .main-header to .page-header
- Page header CSS moved into a modules folder and now included on the new-base-styles.css. This is done to avoid loading a separate file everytime.
- Extracted color variables to their own file

* Updated localization for header and admin monitor

- The pageHeader template receives localization strings as props
- Missing translation for the admin monitor on the it, bg and pl locales

* Update core/src/main/resources/lib/layout/layout.jelly

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Most measurements migrated to REMs

* Code cleanup and apply new-ui toggle to the html.jelly file

* Breadcrumb fixes

- Reverts breadcrumb link styling to use nested selectors instead of the .breadcrumbs__link class. The reason is that several plugins would break.
- Shifted margins so that breadcrumbs can be fullwidth in the absence of the auto refresh link

* Implemented some fixes from the feedback received

- Removed box shadow webkit prefix
- Fixed formatting on the breadcrumbs.css and layout-commons.less files
- Renamed the new UI toggle class from _new-ui_ to _ui-refresh_
- Renamed references to the _new ui_ to _v2_

* Created jelly helper to use svg icons

* Fix: restore proper icon for the user on the header

* Fixes for Edge, IE 11 and IE 10

* Improvements on the header and breadcrumbs

- Logo v2 changed and optimized using the svgo frontend https://jakearchibald.github.io/svgomg/
- Refactored the ammonitor insertion code
- Breadcrumbs are no longer capitalized
- Classic logo link no longer stretches past the images
- Fixed classic logo link on IE11
- Updated color of the footer
- Menu items background is also changed when hovering over the menu selector
- Removed copyright notice on top of some files

* Bumped JTH version with the SVG download fix

* Update test/pom.xml

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Added a function to check boolean system properties from jelly

* Fix header links and add svg styles for legacy layout

*  Some bug fixing for the new header

- The ui-refresh changes were not properly being enabled with the boolean system property. Added explicit true check on the jelly templates.
- Added an explicit width for the ui-refresh logo because it would mess with the layout

* Update core/src/main/java/hudson/Functions.java

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

* Do not check the system property on every page render

Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-20 16:57:47 +00:00
Raihaan ShouhellandAdrien Lecharpentier 48ed32ba11 Apply suggestions from code review
Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
2020-02-20 20:17:40 +08:00
Tim Jacomb 71c5fa5bbb Merge pull request #4504 from daniel-beck/JENKINS-61121
[JENKINS-61121] Fix too many open files with resource domain
2020-02-20 07:58:36 +00:00
Raihaan Shouhell c82f5147d0 Fix 2 instances of interal rep leak and a possible handle leak 2020-02-20 10:44:04 +08:00
Raihaan Shouhell e904ec9c74 Fix instances of double checked locking 2020-02-20 07:47:40 +08:00
Daniel BeckandJesse Glick 3bc83e3503 Apply suggestions from code review
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
2020-02-19 15:50:10 +01:00
Daniel Beck 107c8575a4 Always set a crumb issuer 2020-02-19 15:00:31 +01:00
Raihaan Shouhell a978ae6fad Use ternary 2020-02-19 21:51:19 +08:00
Raihaan Shouhell 2b75058b1c Use ternary 2020-02-19 21:50:48 +08:00
Raihaan Shouhell 0074146017 Fix possible NPE 2020-02-19 16:10:04 +08:00
Tim Jacomb dc8781dd69 Merge pull request #4497 from res0nance/tied-jobs
Improve performance when loading tied jobs
2020-02-18 20:59:24 +00:00
Wadeck Follonier e377050faf Merge pull request #4501 from daniel-beck/jep-223
[JEP-223] Overall/Manage permission
2020-02-18 17:05:54 +01:00
Daniel Beck 548d9969cc [JENKINS-61121] Fix too many open files with resource domain 2020-02-18 14:38:48 +01:00
Daniel Beck b0dd37324f Adapt annotations 2020-02-18 14:24:24 +01:00
Daniel Beck 913844de17 Javadoc improvements, improve description of Manage permission 2020-02-18 14:09:09 +01:00
Daniel Beck 9c8a44ca34 Rename to #getRequiredGlobalConfigPagePermission to disambiguate 2020-02-18 12:41:00 +01:00
James NordandRaihaan Shouhell b39ff9938a [JENKINS-61046] - Allow plugins to force an update of the UpdateCenter (#4488)
* Allow plugins to force an update of the UpdateCenter

* Add javadoc to updateDirectlyNow

* [JENKINS-61046] introduce updateDirectlyNow() and updateDirectly()

@oleg-nenashev notes that the public API should not expose the security
option that is for testing.  Introduced updateDirectlyNow() as the new
API and updateDirectly() to have a mirror and deprecated
updateDirectly(boolean) as a consequence.

* fix javadoc grammar

fixes the grammar of the UpdateSite#updateDirectlyNow javadoc

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>

Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-02-18 11:36:38 +01:00
Daniel BeckandOleg Nenashev 735193c2ec Add at-since TODO to Javadoc
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-02-17 14:14:58 +01:00
Raihaan Shouhell 60b3ef1260 Use Streams 2020-02-17 11:27:39 +08:00
Tim Jacomb 9ba18f5de0 Merge branch 'master' into jep-223 2020-02-15 11:56:04 +00:00
Jesse Glick 7ff5f097d0 [JENKINS-61071] Ensure that initialization tasks run as SYSTEM (#4491) 2020-02-15 11:51:03 +00:00
Tim Jacomb a405be946f Merge pull request #4455 from Wadeck/JENKINS-60866_cleanup-hudson-security-realm
[JENKINS-60866] Un-inline JavaScript / CSS from HudsonPrivateSecurity…
2020-02-15 11:49:51 +00:00
Tim Jacomb 5c36f4571f Merge pull request #4381 from jeffret-b/findsecbugs
Add findsecbugs plugin to spotbugs.
2020-02-15 11:47:01 +00:00
Daniel Beck 042dc75a8f For consistency with ManagementLink, name this #getRequiredPermission() 2020-02-14 21:55:18 +01:00
Daniel Beck 17f1a7c155 Fix Javadoc 2020-02-14 21:31:28 +01:00
Daniel Beck 3b2d0d2c78 As this is experimental, annotate with Restricted(Beta) 2020-02-14 19:59:03 +01:00
55b2bc7f3f [JEP-223] Overall/Manage permission
Co-Authored-By: Esther Alvarez Feijoo <ealvarez@cloudbees.com>
Co-Authored-By: aHenryJard <ajard@cloudbees.com>
Co-Authored-By: michael cirioli <mikecirioli@gmail.com>
2020-02-14 19:37:32 +01:00
Daniel Beck 5c9ba1428b Add extensible background build discarders (#4368) 2020-02-14 08:50:07 +00:00
Raihaan Shouhell 57d8045e8d Use predicate form in getItems(Class)
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
2020-02-14 14:52:34 +08:00
Raihaan Shouhell 19be5e2862 Optimize getTiedJobs()
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
2020-02-14 10:26:55 +08:00
Raihaan Shouhell e93e236d84 Optimize getAllItems() 2020-02-14 10:01:28 +08:00
Jeff Thompson 39fc974889 Pass the HTTP status code on to the oops page.
If we didn't get a code then continue to use 500. If we did, then use it.
2020-02-13 11:29:12 -07:00
James Nord d67c1b0247 allert-error does not exist, update javadoc to allert-danger 2020-02-13 17:03:45 +00:00
Tim Jacomb 2fcd831866 Merge pull request #3989 from olivergondza/afw-suppressed
Changed exception presented when AtomicFileWriter fails to write to file
2020-02-13 13:18:17 +00:00
Daniel Beck 7777d8f28b Do not show disabled permissions in permission errors (#4482) 2020-02-13 09:40:58 +01:00
Raihaan ShouhellandEvaristo Gutiérrez 9c4dac702e Add preauth filtering overload of getAllItems(), getItems() and allItems() (#4469)
* Add preauth filtering overload of getAllItems()

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Add allItems filtering

* Apply suggestions from code review

Co-Authored-By: Evaristo Gutiérrez <egutierrez@cloudbees.com>

* Use streams

* Add stream functions

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Missed simplification

Co-authored-by: Evaristo Gutiérrez <egutierrez@cloudbees.com>
2020-02-13 09:40:35 +01:00
Jeff Thompson cfc5e526fa Adjust naming. 2020-02-11 14:10:12 -07:00
Jeff Thompson 4a0146390c Adopt Daniel's suggestion for tying Stapler change to Jenkins.
And remove duplication in tests.
2020-02-11 14:10:12 -07:00
Jeff Thompson 13d4a37ae0 Remove now unused method. 2020-02-11 14:10:12 -07:00
Jeff Thompson 8baddd2f42 Don't handle embedded security exceptions. 2020-02-11 14:10:12 -07:00