Commit Graph
1476 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi fce4fed4e8 [JENKINS-21932] Merge pull request #1160 2014-04-13 16:54:57 -07:00
Oliver Gondža 82472d7f2b Merge pull request #1092 from jbrejner/master
[FIXED JENKINS-21394] Avoid irrelevant job queing while node is offline

Conflicts:
	test/src/test/java/hudson/model/ProjectTest.java
2014-04-13 00:08:34 +02:00
Jesse Glick 26ec7bdf93 Properly testing ReverseBuildTrigger, and refining what information is displayed in build logs. 2014-04-11 18:29:19 -04:00
Jesse Glick 772e36662e Introduced MockQueueItemAuthenticator as a convenience. 2014-04-11 16:38:18 -04:00
Jesse Glick ac220e3f2b Unnecessary and misleading for a QueueItemAuthenticator to be a @TestExtension.
(It may have a @TestExtension QueueItemAuthenticatorDescriptor if one is needed.)
2014-04-11 16:13:16 -04:00
Jesse Glick d4b5549d60 No sense in spending ~20s running HtmlUnit to verify code which has since been deleted anyway (configuration-time ACL checks). 2014-04-11 16:03:53 -04:00
Jesse Glick b53139e0db Test of JENKINS-13502 fix is obsolete since we no longer check permissions when configuring triggers. 2014-04-11 15:39:42 -04:00
Jesse Glick 840bb66944 Replacing pseudoUpstreamTrigger with ReverseBuildTrigger. 2014-04-10 20:58:30 -04:00
Jesse Glick 3342d74182 Merge branch 'master' into BuildTrigger-auth-JENKINS-16956 2014-04-09 12:10:47 -04:00
Jesse Glick ef382f90a5 Introduced a QueueItemAuthenticator overload taking Task.
And moving the permissions checks in BuildTrigger from being hardcoded in execute to being overridable in Dependency.
This has two benefits:
· We can restore the previous form validation logic predicting whether Item.BUILD will be available.
· A (true) Trigger could check Item.READ on the upstream project
  under the authentication that the downstream project would have if it were to be built.
  (This part is not yet implemented; probably will want to make this replace the current pseudotriggers.)
2014-04-03 17:09:41 -04:00
Jesse Glick dcfeaf3c2a OldDataMonitorTest.robustness consistently passes for me locally, but has been causing trouble in CI. Suppressing for now. 2014-04-03 12:29:13 -04:00
Jesse Glick d31ff2fed3 [JENKINS-16956] More compatible behavior: if no QIA’s are configured yet, fall back to running as SYSTEM.
Also make a best effort to issue a warning in the log if downstream builds might skipped due to lack of authentication;
or if downstream build permissions might not be checked due to legacy behavior.
2014-04-02 18:28:05 -04:00
Jesse Glick 48e92efaed [JENKINS-16956] Make BuildTrigger.execute pay attention to build permissions, rather than checking the configuring user. 2014-04-02 17:21:04 -04:00
Jesse Glick dd5a3b1465 @RandomlyFails 2014-03-24 13:41:54 -04:00
Jesse Glick f82f0bb9f6 testEnterCredential observed to fail due to offline mirror.
Since downloading tool metadata seems inessential for the test, leaving it disabled as is the default.
503 Service Unavailable for http://mirrors.jenkins-ci.org/updates/updates/hudson.tasks.Ant.AntInstaller.json?id=hudson.tasks.Ant.AntInstaller&version=1.557-SNAPSHOT%2520(private-03%252F24%252F2014%252014%253A15%2520GMT-jenkins)
2014-03-24 11:55:54 -04:00
Jesse Glick 56b360d6f3 [JENKINS-19976] Touch-ups to PR #1054. 2014-03-24 10:10:52 -04:00
Jesse Glick df8df45c27 [FIXED JENKINS-19976] Merged #1054: fix class loading from dynamically installed optional dependencies. 2014-03-24 09:52:32 -04:00
Jesse Glick 681a8ff307 [FIXED JENKINS-19544] When OldDataMonitor is reported a Run, just remember the ID rather than holding a strong reference. 2014-03-21 18:58:03 -04:00
Jesse Glick 8508fc365a [JENKINS-19544] Whether or not we manage to save an object with old data, be sure to remove it from the list, and continue with other objects.
Otherwise a bug like JENKINS-20950 can prevent *anything* from being saved, and holds references to all the old data.
2014-03-21 18:13:51 -04:00
Jesse Glick 8861563bd1 [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. 2014-03-19 16:03:41 -04:00
Mads Nielsen b98e0abe56 Added test for JENKINS-21394 2014-03-19 10:03:18 +01:00
Jesse Glick df9c92e461 Removed DownloadSettings.checkSignature; back to using a plain system property for this. 2014-03-17 12:48:24 -04:00
Jesse Glick db8d6508aa Merge branch 'master' into DownloadSettings-JENKINS-19081 2014-03-17 12:33:48 -04:00
ikedam 5c3672270b [JENKINS-21932] Make the slave used in the test offline explicitly. 2014-03-15 14:30:24 +09:00
ikedam 35dfc75c68 [JENKINS-21932] Added tests to reproduce JENKINS-21932, Future#get does not abort even when a task in the queue is canceled. 2014-03-15 09:40:31 +09:00
Kohsuke Kawaguchi 0db32ecaa1 Clarifying assertions that they are trying to test. 2014-03-14 14:42:51 -07:00
Kohsuke Kawaguchi bd8234cceb Fixing a test failure.
The intent of this test is to make sure that a floating User object without any storage returns false from canDelete() method.
The earlier change made User.impersonate() to actually check if the user is a valid, so to make this test case work where it does
"user.impersonate" and "user2.impersonate2", I'm creating valid accounts for these two users.

Now what that means is that user2 is no longer a floating flyweight storage-less User, so it breaks the assumption of the
"User should not be able to delete because he is not saved." assertion.

To make this test case work, I'm introducing the 3rd user that is storage-less, and using it for the test.
2014-03-14 14:39:27 -07:00
Jesse Glick 2b6726290d Merge branch 'deconstructing-AbstractProject' 2014-03-14 13:29:11 -04:00
Kohsuke Kawaguchi f04b0e011a User.impersonate now requires that the user be a valid user.
These tests weren't using a SecurityRealm that recognizes these user names
2014-03-14 10:17:36 -07:00
Kohsuke Kawaguchi 2a78c10b94 Updating tests to fix more regressions 2014-03-14 10:17:36 -07:00
Kohsuke Kawaguchi 38ae112093 LastGrantedAuthoritiesProperty was missing a descriptor 2014-03-13 15:42:25 -07:00
Kohsuke Kawaguchi 16d0bc3fa9 More test fixes 2014-03-13 15:19:44 -07:00
Kohsuke Kawaguchi 664f7e3400 More test fixes 2014-03-13 13:31:04 -07:00
Kohsuke Kawaguchi e400bc7d94 Working toward fixing regressions.
So far none of them are real regressions but just that I needed to update tets
2014-03-13 12:48:27 -07:00
Kohsuke Kawaguchi ddf391cfec Updating test to fix failures.
Now that User.impersonate() actually checks if the user is valid, User.get("user").impersonate() is expected to fail.
Use a DummySecurityRealm to make this user a valid user.
2014-03-13 12:48:27 -07:00
Jesse Glick 5a01c0b7c5 Merge branch 'master' into deconstructing-AbstractProject 2014-03-13 10:37:21 -04:00
Kohsuke Kawaguchi 80b1cf9f8b Remember Me option doesn't always show. 2014-03-12 20:56:27 -07:00
Kohsuke Kawaguchi ce7e6390ee Adding the reload job functionality 2014-03-12 18:18:17 -07:00
Kohsuke Kawaguchi b478ca8904 Merge branch 'master' of github.com:jenkinsci/jenkins 2014-03-11 16:32:16 -07:00
Kohsuke Kawaguchi b078ac62f5 added another test for the basic remember-me flow 2014-03-11 16:22:40 -07:00
Kohsuke Kawaguchi 0e339d7a45 [JENKINS-20064]
Jenkins now remembers the authorities (read group memberships) that the user had carried when he/she last time interactively logged in.
This information is exposed via User.impersonate(), which is used when using Jenkins SSH, Jenkins CLI, or access via API tokens.

Previously this was impossible for a subset of SecurityRealms that does not allow us to read group membership information without
successful login (such as Active Directory, OpenID, etc.)

For security reasons, if the backend determines that the user does not exist (as opposed to the backend who cannot tell if the user
exists or not), then the impersonation will fail.

I need to check AD plugin is reporting a failure correctly in this case, before marking as JENKINS-20064 fixed.
2014-03-11 14:55:25 -07:00
Kohsuke Kawaguchi 86fcc4733d added a convenience method. 2014-03-11 14:21:46 -07:00
Kohsuke Kawaguchi 983ee33df1 added a convenience method 2014-03-11 14:12:27 -07:00
CloudBees DEV@Cloud f488ba8cbb Merge REMERGE_HEAD into HEAD 2014-03-11 19:39:52 +00:00
Kohsuke Kawaguchi 2dbd6eca7f [JENKINS-11643]
An unexpected failure in processing remember me cookie should be handled
gracefully. In particular, possibly problematic cookie should be
removed, or else the browser will keep bombarding the server with the
same cookie, and will never be able to get through.

It's much better to just drop the cookie.
2014-03-11 12:17:11 -07:00
Jesse Glick fb0ad71b71 Ensure that resolveDependencyJar works for NetBeans compile-on-save (and possibly other IDE’s similar features) even when plugin dependencies are snapshots (possibly in the reactor). 2014-03-11 14:15:26 -04:00
Jesse Glick d1b713a4d8 Renaming the newly introduced method avoids the need for an ambiguous overload. 2014-03-07 19:35:25 -08:00
Jesse Glick 9f19ae91f7 Introduced ParameterizedJobMixIn so that non-AbstractProject’s can use ParametersDefinitionProperty. 2014-03-07 11:44:28 -08:00
Jesse Glick 507d3a9fb7 Merge branch 'master' into DownloadSettings-JENKINS-19081
Conflicts:
	test/src/test/resources/hudson/model/update-center.json.html
2014-03-06 09:48:21 -08:00
Kohsuke Kawaguchi bd4f6bcf4c merged back the RC branch 2014-03-03 06:58:15 -08:00