And moving the permissions checks in BuildTrigger from being hardcoded in execute to being overridable in Dependency.
This has two benefits:
· We can restore the previous form validation logic predicting whether Item.BUILD will be available.
· A (true) Trigger could check Item.READ on the upstream project
under the authentication that the downstream project would have if it were to be built.
(This part is not yet implemented; probably will want to make this replace the current pseudotriggers.)
Also make a best effort to issue a warning in the log if downstream builds might skipped due to lack of authentication;
or if downstream build permissions might not be checked due to legacy behavior.
The intent of this test is to make sure that a floating User object without any storage returns false from canDelete() method.
The earlier change made User.impersonate() to actually check if the user is a valid, so to make this test case work where it does
"user.impersonate" and "user2.impersonate2", I'm creating valid accounts for these two users.
Now what that means is that user2 is no longer a floating flyweight storage-less User, so it breaks the assumption of the
"User should not be able to delete because he is not saved." assertion.
To make this test case work, I'm introducing the 3rd user that is storage-less, and using it for the test.
Now that User.impersonate() actually checks if the user is valid, User.get("user").impersonate() is expected to fail.
Use a DummySecurityRealm to make this user a valid user.
Jenkins now remembers the authorities (read group memberships) that the user had carried when he/she last time interactively logged in.
This information is exposed via User.impersonate(), which is used when using Jenkins SSH, Jenkins CLI, or access via API tokens.
Previously this was impossible for a subset of SecurityRealms that does not allow us to read group membership information without
successful login (such as Active Directory, OpenID, etc.)
For security reasons, if the backend determines that the user does not exist (as opposed to the backend who cannot tell if the user
exists or not), then the impersonation will fail.
I need to check AD plugin is reporting a failure correctly in this case, before marking as JENKINS-20064 fixed.
An unexpected failure in processing remember me cookie should be handled
gracefully. In particular, possibly problematic cookie should be
removed, or else the browser will keep bombarding the server with the
same cookie, and will never be able to get through.
It's much better to just drop the cookie.