Commit Graph
1508 Commits
Author SHA1 Message Date
Jesse Glick 78e1555867 Suppressing failure seen on CI builders.
Somehow they occasionally get corrupted files in the local repo.
2014-05-02 14:21:18 -04:00
Jesse Glick 05ea8cfc55 Merging test cases from #1190 and #1191 into one file. 2014-05-02 12:08:56 -04:00
Jesse Glick 64b98d2150 Merge branch 'dropLinks-JENKINS-22395' 2014-05-02 11:59:51 -04:00
Jesse Glick cbb6a8ac85 JUnit 4. 2014-04-30 19:05:10 -04:00
Jesse Glick 87e66570b8 JUnit 4. 2014-04-30 17:46:46 -04:00
Jesse Glick 872bc1cc30 JUnit 4. 2014-04-29 14:31:39 -04:00
Jesse Glick b227088704 Merge branch 'JENKINS-20662' of github.com:daniel-beck/jenkins 2014-04-23 16:38:23 -04:00
Daniel Beck b59c490a3b [JENKINS-20662] Simplify test after feedback 2014-04-23 21:46:02 +02:00
Kohsuke Kawaguchi d8a27358b3 made this list configurable 2014-04-22 11:35:41 -07:00
Kohsuke Kawaguchi 4b9387795f defer MavenEmbedder creation 2014-04-22 11:35:41 -07:00
Kohsuke Kawaguchi a8e05e2446 Resolving dependencies among other JPL files 2014-04-22 11:35:41 -07:00
Kohsuke Kawaguchi bd0c5b28c3 Moving the logic into an inner class.
This is in preparation of resolving dependencies within "List<URL> all"
2014-04-22 11:35:40 -07:00
Kohsuke Kawaguchi 50cc4f0f5d [JENKINS-17510]
Massaging the pull request.

- Simplifying by reusing InterceptingExecutorService
- Not hiding the implementation class for better
  consistency with other ExecutorService impls in
  Jenkins.
2014-04-19 15:48:48 -07:00
Kohsuke Kawaguchi da74cbfd6b Merge branch 'pull-766' 2014-04-19 15:40:24 -07:00
Kohsuke Kawaguchi bdfbf25129 [FIXED JENKINS-20857] Merged pull request 1060 2014-04-19 12:26:33 -07:00
gcummings 10ea9941ae [JENKINS-20857] - add unit test which recreates NullPointerException if selected build has been deleted 2014-04-19 12:24:35 -07:00
Daniel Beck 26735ec022 [JENKINS-20662] Add test. 2014-04-18 13:23:49 +02:00
Jesse Glick f1430a25ec [FIXED JENKINS-22395] Attempt to double-delete a Run probably caused by getNextBuild sometimes returning a build which was already deleted. 2014-04-15 18:24:01 -04:00
Jesse Glick 6fd76ea2e8 Trying to make SocketTimeoutException’s (as originally noted in 3ec7e56) not turn into test errors. (Works only in JenkinsRule, not HudsonTestCase.) Still have no clue as to cause. 2014-04-15 13:48:08 -04:00
Jesse Glick deb90a493c [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it. 2014-04-15 12:54:38 -04:00
Jesse Glick 6883b91523 Merge branch 'extract-matrix-project' 2014-04-15 00:41:53 -04:00
Jesse Glick 23bb42d235 Unused imports triggering compiler warnings. 2014-04-14 23:35:57 -04:00
Jesse Glick 4aad749cbe Removing hudson.matrix classes and associated resources as a first pass. 2014-04-14 19:03:29 -04:00
Kohsuke Kawaguchi fce4fed4e8 [JENKINS-21932] Merge pull request #1160 2014-04-13 16:54:57 -07:00
Oliver Gondža 82472d7f2b Merge pull request #1092 from jbrejner/master
[FIXED JENKINS-21394] Avoid irrelevant job queing while node is offline

Conflicts:
	test/src/test/java/hudson/model/ProjectTest.java
2014-04-13 00:08:34 +02:00
Jesse Glick 26ec7bdf93 Properly testing ReverseBuildTrigger, and refining what information is displayed in build logs. 2014-04-11 18:29:19 -04:00
Jesse Glick 772e36662e Introduced MockQueueItemAuthenticator as a convenience. 2014-04-11 16:38:18 -04:00
Jesse Glick ac220e3f2b Unnecessary and misleading for a QueueItemAuthenticator to be a @TestExtension.
(It may have a @TestExtension QueueItemAuthenticatorDescriptor if one is needed.)
2014-04-11 16:13:16 -04:00
Jesse Glick d4b5549d60 No sense in spending ~20s running HtmlUnit to verify code which has since been deleted anyway (configuration-time ACL checks). 2014-04-11 16:03:53 -04:00
Jesse Glick b53139e0db Test of JENKINS-13502 fix is obsolete since we no longer check permissions when configuring triggers. 2014-04-11 15:39:42 -04:00
Jesse Glick 840bb66944 Replacing pseudoUpstreamTrigger with ReverseBuildTrigger. 2014-04-10 20:58:30 -04:00
Jesse Glick 3342d74182 Merge branch 'master' into BuildTrigger-auth-JENKINS-16956 2014-04-09 12:10:47 -04:00
Jesse Glick ef382f90a5 Introduced a QueueItemAuthenticator overload taking Task.
And moving the permissions checks in BuildTrigger from being hardcoded in execute to being overridable in Dependency.
This has two benefits:
· We can restore the previous form validation logic predicting whether Item.BUILD will be available.
· A (true) Trigger could check Item.READ on the upstream project
  under the authentication that the downstream project would have if it were to be built.
  (This part is not yet implemented; probably will want to make this replace the current pseudotriggers.)
2014-04-03 17:09:41 -04:00
Jesse Glick dcfeaf3c2a OldDataMonitorTest.robustness consistently passes for me locally, but has been causing trouble in CI. Suppressing for now. 2014-04-03 12:29:13 -04:00
Jesse Glick d31ff2fed3 [JENKINS-16956] More compatible behavior: if no QIA’s are configured yet, fall back to running as SYSTEM.
Also make a best effort to issue a warning in the log if downstream builds might skipped due to lack of authentication;
or if downstream build permissions might not be checked due to legacy behavior.
2014-04-02 18:28:05 -04:00
Jesse Glick 48e92efaed [JENKINS-16956] Make BuildTrigger.execute pay attention to build permissions, rather than checking the configuring user. 2014-04-02 17:21:04 -04:00
Jesse Glick dd5a3b1465 @RandomlyFails 2014-03-24 13:41:54 -04:00
Jesse Glick f82f0bb9f6 testEnterCredential observed to fail due to offline mirror.
Since downloading tool metadata seems inessential for the test, leaving it disabled as is the default.
503 Service Unavailable for http://mirrors.jenkins-ci.org/updates/updates/hudson.tasks.Ant.AntInstaller.json?id=hudson.tasks.Ant.AntInstaller&version=1.557-SNAPSHOT%2520(private-03%252F24%252F2014%252014%253A15%2520GMT-jenkins)
2014-03-24 11:55:54 -04:00
Jesse Glick 56b360d6f3 [JENKINS-19976] Touch-ups to PR #1054. 2014-03-24 10:10:52 -04:00
Jesse Glick df8df45c27 [FIXED JENKINS-19976] Merged #1054: fix class loading from dynamically installed optional dependencies. 2014-03-24 09:52:32 -04:00
Jesse Glick 681a8ff307 [FIXED JENKINS-19544] When OldDataMonitor is reported a Run, just remember the ID rather than holding a strong reference. 2014-03-21 18:58:03 -04:00
Jesse Glick 8508fc365a [JENKINS-19544] Whether or not we manage to save an object with old data, be sure to remove it from the list, and continue with other objects.
Otherwise a bug like JENKINS-20950 can prevent *anything* from being saved, and holds references to all the old data.
2014-03-21 18:13:51 -04:00
Jesse Glick 8861563bd1 [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. 2014-03-19 16:03:41 -04:00
Mads Nielsen b98e0abe56 Added test for JENKINS-21394 2014-03-19 10:03:18 +01:00
Jesse Glick df9c92e461 Removed DownloadSettings.checkSignature; back to using a plain system property for this. 2014-03-17 12:48:24 -04:00
Jesse Glick db8d6508aa Merge branch 'master' into DownloadSettings-JENKINS-19081 2014-03-17 12:33:48 -04:00
ikedam 5c3672270b [JENKINS-21932] Make the slave used in the test offline explicitly. 2014-03-15 14:30:24 +09:00
ikedam 35dfc75c68 [JENKINS-21932] Added tests to reproduce JENKINS-21932, Future#get does not abort even when a task in the queue is canceled. 2014-03-15 09:40:31 +09:00
Kohsuke Kawaguchi 0db32ecaa1 Clarifying assertions that they are trying to test. 2014-03-14 14:42:51 -07:00
Kohsuke Kawaguchi bd8234cceb Fixing a test failure.
The intent of this test is to make sure that a floating User object without any storage returns false from canDelete() method.
The earlier change made User.impersonate() to actually check if the user is a valid, so to make this test case work where it does
"user.impersonate" and "user2.impersonate2", I'm creating valid accounts for these two users.

Now what that means is that user2 is no longer a floating flyweight storage-less User, so it breaks the assumption of the
"User should not be able to delete because he is not saved." assertion.

To make this test case work, I'm introducing the 3rd user that is storage-less, and using it for the test.
2014-03-14 14:39:27 -07:00