mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-10 02:26:18 +00:00
Oleg NenashevandMark Waite
faf13e19b9
* Add the maintainer checklist to the pull request template * Add checklist items for LTS * Add "Proposed changelog entries" to the pull request template * Pull request template: `Internal: ` prefix is now added automatically by the Core Changelog generator https://github.com/jenkinsci/jenkins-core-changelog-generator/pull/6 * Apply suggestions from review by @MarkEWaite Co-Authored-By: Mark Waite <mark.earl.waite@gmail.com> Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2.7 KiB
2.7 KiB
See JENKINS-XXXXX.
Proposed changelog entries
- Entry 1: Issue, Human-readable Text
- ...
Proposed upgrade guidelines
N/A
Submitter checklist
- JIRA issue is well described
- Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
- Fill-in the
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgrade
- Fill-in the
- Appropriate autotests or explanation to why this change has no tests
- For dependency updates: links to external changelogs and, if possible, full diffs
Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as ready-for-merge:
- There are at least 2 approvals for the pull request and no outstanding requests for change
- Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
- Changelog entries in the PR title and/or
Proposed changelog entriesare correct - Proper changelog labels are set so that the changelog can be generated automatically
- If the change needs additional upgrade steps from users,
upgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example) - If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as
lts-candidate