mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-10-31 13:35:19 +00:00
Mark Waite
4ef9cde5e4
* Skip symlink tests on Windows developer machines
Windows does not support symbolic links by default. Tests fail for new
contributors on Windows if they do not adjust their Windows configuration
to allow symbolic links.
We don't want to require that developers running on Windows must enable
symbolic links. We want to always run the tests on Windows machines in
our CI environment.
Amends pull request:
* https://github.com/jenkinsci/jenkins/pull/26203
New tests that depend on Windows symbolic links were added as part of
the core tests for SECURITY-3657 in commit 6dc9993760. The technique
from pull request 26203 is too complicated for use in multiple modules.
This change simplifies the logic by not attempting to detect if symlinks
are supported on the Windows computer running the tests. Since the full
set of automated tests of Jenkins core require many hours to complete
on Windows, it seems safe to assume that developers on Windows will not
mind skipping the tests that require symlinks.
Testing done:
* Confirmed tests pass on Linux
* Confirmed tests are skipped on Windows computers that are not CI agents
* Confirmed tests pass on Windows computers that are CI agents
* Disable symlink tests with a Maven profile
The profile will disable symlink tests on Windows unless the CI
environment variable is set.