mirror of
https://github.com/morluto/rea.git
synced 2026-11-18 20:53:00 +00:00
fix(ledger): authenticate evidence before committing
This commit is contained in:
1 parent
6dff37594c
commit
0407bbfbe6
2 files changed
+405
-95
No files matched your search
@@ -4,14 +4,16 @@ import { z } from "zod";
|
||||
import {
|
||||
createEvidenceBundle,
|
||||
createImmutableEvidenceBundle,
|
||||
safeParseEvidenceBundle,
|
||||
safeParseImmutableEvidenceBundle,
|
||||
InvalidResidualUnknownGraphError,
|
||||
validateResidualUnknownAddition,
|
||||
type EvidenceBundle,
|
||||
} from "../../domain/evidenceBundle.js";
|
||||
import { AnalysisInputError } from "../../domain/analysisErrorCore.js";
|
||||
import { EvidenceIntegrityError } from "../../domain/evidenceErrors.js";
|
||||
import { UnknownRegistryError } from "../../domain/unknownRegistryError.js";
|
||||
import { immutableEvidence, type Evidence } from "../../domain/evidence.js";
|
||||
import type { Evidence } from "../../domain/evidence.js";
|
||||
import { readImmutableEvidence } from "../../domain/evidenceValidation.js";
|
||||
import {
|
||||
createResidualUnknown,
|
||||
updateResidualUnknown,
|
||||
@@ -43,21 +45,17 @@ type ImportResult = Result<
|
||||
|
||||
/** Session-owned set of immutable evidence records. */
|
||||
export class EvidenceLedger {
|
||||
readonly #records = new Map<string, Evidence>();
|
||||
readonly #unknownRevisions = new Map<string, ResidualUnknown>();
|
||||
readonly #unknownHeads = new Map<string, ResidualUnknown>();
|
||||
#records = new Map<string, Evidence>();
|
||||
#unknownRevisions = new Map<string, ResidualUnknown>();
|
||||
#unknownHeads = new Map<string, ResidualUnknown>();
|
||||
/** Record evidence idempotently; conflicting content is rejected. */
|
||||
record(input: Evidence): RecordResult {
|
||||
let evidence: Evidence;
|
||||
try {
|
||||
evidence = immutableEvidence(input);
|
||||
} catch (cause: unknown) {
|
||||
return err(
|
||||
new EvidenceIntegrityError("Evidence record validation failed", {
|
||||
cause,
|
||||
}),
|
||||
);
|
||||
}
|
||||
const authenticated = readLedgerEvidence(
|
||||
input,
|
||||
"Evidence record validation failed",
|
||||
);
|
||||
if (!authenticated.ok) return authenticated;
|
||||
const evidence = authenticated.value;
|
||||
const existing = this.#records.get(evidence.evidence_id);
|
||||
if (existing !== undefined) {
|
||||
// A borrowed record is already authenticated and deeply immutable. Its
|
||||
@@ -74,7 +72,7 @@ export class EvidenceLedger {
|
||||
|
||||
/** Validate an entire bundle before atomically merging its records. */
|
||||
import(input: unknown): ImportResult {
|
||||
const parsed = safeParseEvidenceBundle(input);
|
||||
const parsed = safeParseImmutableEvidenceBundle(input);
|
||||
if (!parsed.ok) {
|
||||
const { kind, message, cause } = parsed.error;
|
||||
if (kind === "single-record")
|
||||
@@ -116,9 +114,8 @@ export class EvidenceLedger {
|
||||
additions.set(evidence.evidence_id, evidence);
|
||||
}
|
||||
for (const [id, evidence] of replacements)
|
||||
this.#records.set(id, immutableEvidence(evidence));
|
||||
for (const [id, evidence] of additions)
|
||||
this.#records.set(id, immutableEvidence(evidence));
|
||||
this.#records.set(id, evidence);
|
||||
for (const [id, evidence] of additions) this.#records.set(id, evidence);
|
||||
return ok({
|
||||
recordsAdded: additions.size,
|
||||
unknownsAdded: 0,
|
||||
@@ -154,19 +151,14 @@ export class EvidenceLedger {
|
||||
}
|
||||
const checked = this.#validateCandidate(pending, pendingUnknowns);
|
||||
if (!checked.ok) {
|
||||
if (checked.error instanceof UnknownRegistryError)
|
||||
return err(
|
||||
new EvidenceIntegrityError(
|
||||
"Evidence bundle unknown registry failed",
|
||||
{
|
||||
cause: checked.error,
|
||||
},
|
||||
),
|
||||
);
|
||||
return err(checked.error);
|
||||
return err(
|
||||
new EvidenceIntegrityError("Evidence bundle unknown registry failed", {
|
||||
cause: checked.error,
|
||||
}),
|
||||
);
|
||||
}
|
||||
const added = pending.size - this.#records.size;
|
||||
this.#commit(pending, pendingUnknowns);
|
||||
this.#commit(checked.value);
|
||||
return ok({
|
||||
recordsAdded: added,
|
||||
unknownsAdded,
|
||||
@@ -217,16 +209,12 @@ export class EvidenceLedger {
|
||||
ResidualUnknown,
|
||||
EvidenceIntegrityError | UnknownRegistryError | AnalysisInputError
|
||||
> {
|
||||
let parsedMutation: Evidence;
|
||||
try {
|
||||
parsedMutation = immutableEvidence(mutationEvidence);
|
||||
} catch (cause: unknown) {
|
||||
return err(
|
||||
new EvidenceIntegrityError("Unknown mutation evidence is invalid", {
|
||||
cause,
|
||||
}),
|
||||
);
|
||||
}
|
||||
const authenticated = readLedgerEvidence(
|
||||
mutationEvidence,
|
||||
"Unknown mutation evidence is invalid",
|
||||
);
|
||||
if (!authenticated.ok) return authenticated;
|
||||
const parsedMutation = authenticated.value;
|
||||
let unknown: ResidualUnknown;
|
||||
try {
|
||||
unknown = createResidualUnknown(
|
||||
@@ -235,7 +223,8 @@ export class EvidenceLedger {
|
||||
parsedMutation.subject?.digest.sha256 ?? null,
|
||||
);
|
||||
} catch (cause: unknown) {
|
||||
return err(unknownInputError("record_unknown", cause, input));
|
||||
if (!(cause instanceof z.ZodError)) throw cause;
|
||||
return err(requestInputError("record_unknown", cause, input));
|
||||
}
|
||||
if (this.#unknownHeads.has(unknown.unknown_id))
|
||||
return err(new UnknownRegistryError("already-exists"));
|
||||
@@ -251,18 +240,18 @@ export class EvidenceLedger {
|
||||
ResidualUnknown | null,
|
||||
EvidenceIntegrityError | UnknownRegistryError
|
||||
> {
|
||||
let evidence: Evidence;
|
||||
let mutation: Evidence;
|
||||
try {
|
||||
evidence = immutableEvidence(evidenceInput);
|
||||
mutation = immutableEvidence(mutationInput);
|
||||
} catch (cause: unknown) {
|
||||
return err(
|
||||
new EvidenceIntegrityError("Atomic Evidence validation failed", {
|
||||
cause,
|
||||
}),
|
||||
);
|
||||
}
|
||||
const authenticatedEvidence = readLedgerEvidence(
|
||||
evidenceInput,
|
||||
"Atomic Evidence validation failed",
|
||||
);
|
||||
if (!authenticatedEvidence.ok) return authenticatedEvidence;
|
||||
const authenticatedMutation = readLedgerEvidence(
|
||||
mutationInput,
|
||||
"Atomic Evidence validation failed",
|
||||
);
|
||||
if (!authenticatedMutation.ok) return authenticatedMutation;
|
||||
const evidence = authenticatedEvidence.value;
|
||||
const mutation = authenticatedMutation.value;
|
||||
const existingEvidence = this.#records.get(evidence.evidence_id);
|
||||
if (
|
||||
existingEvidence !== undefined &&
|
||||
@@ -277,6 +266,7 @@ export class EvidenceLedger {
|
||||
mutation.subject?.digest.sha256 ?? null,
|
||||
);
|
||||
} catch (cause: unknown) {
|
||||
if (!(cause instanceof z.ZodError)) throw cause;
|
||||
return err(new UnknownRegistryError("invalid-transition", { cause }));
|
||||
}
|
||||
const creationUnknown = this.#unknownRevisions.get(
|
||||
@@ -315,9 +305,15 @@ export class EvidenceLedger {
|
||||
mutationEvidence.evidence_id,
|
||||
);
|
||||
} catch (cause: unknown) {
|
||||
return err(unknownInputError("update_unknown", cause, input));
|
||||
if (!(cause instanceof z.ZodError)) throw cause;
|
||||
return err(requestInputError("update_unknown", cause, input));
|
||||
}
|
||||
return this.#appendUnknown(unknown, mutationEvidence);
|
||||
const authenticated = readLedgerEvidence(
|
||||
mutationEvidence,
|
||||
"Unknown mutation evidence is invalid",
|
||||
);
|
||||
if (!authenticated.ok) return authenticated;
|
||||
return this.#appendUnknown(unknown, authenticated.value);
|
||||
}
|
||||
|
||||
/** Query current heads in stable ID order. */
|
||||
@@ -391,23 +387,14 @@ export class EvidenceLedger {
|
||||
|
||||
#appendUnknown(
|
||||
unknown: ResidualUnknown,
|
||||
mutationEvidenceInput: Evidence,
|
||||
mutationEvidence: Evidence,
|
||||
): Result<ResidualUnknown, EvidenceIntegrityError | UnknownRegistryError> {
|
||||
let mutationEvidence: Evidence;
|
||||
try {
|
||||
mutationEvidence = immutableEvidence(mutationEvidenceInput);
|
||||
} catch (cause: unknown) {
|
||||
return err(
|
||||
new EvidenceIntegrityError("Unknown mutation evidence is invalid", {
|
||||
cause,
|
||||
}),
|
||||
);
|
||||
}
|
||||
const checked = this.#appendIncremental([mutationEvidence], unknown);
|
||||
if (!checked.ok) return checked;
|
||||
return ok(structuredClone(unknown));
|
||||
}
|
||||
|
||||
/** Incoming records were authenticated and sealed at the ingestion boundary. */
|
||||
#appendIncremental(
|
||||
records: readonly Evidence[],
|
||||
unknown?: ResidualUnknown,
|
||||
@@ -439,10 +426,10 @@ export class EvidenceLedger {
|
||||
this.#unknownHeads,
|
||||
);
|
||||
} catch (cause: unknown) {
|
||||
if (!(cause instanceof InvalidResidualUnknownGraphError)) throw cause;
|
||||
return err(new UnknownRegistryError("integrity", { cause }));
|
||||
}
|
||||
for (const [id, evidence] of additions)
|
||||
this.#records.set(id, immutableEvidence(evidence));
|
||||
for (const [id, evidence] of additions) this.#records.set(id, evidence);
|
||||
if (unknown !== undefined && unknownKey !== undefined) {
|
||||
this.#unknownRevisions.set(unknownKey, unknown);
|
||||
this.#unknownHeads.set(unknown.unknown_id, unknown);
|
||||
@@ -450,48 +437,60 @@ export class EvidenceLedger {
|
||||
return ok(undefined);
|
||||
}
|
||||
|
||||
/** Return the sealed candidate facts that the commit will adopt. */
|
||||
#validateCandidate(
|
||||
records: ReadonlyMap<string, Evidence>,
|
||||
unknowns: ReadonlyMap<string, ResidualUnknown>,
|
||||
): Result<void, EvidenceIntegrityError | UnknownRegistryError> {
|
||||
): Result<EvidenceBundle, UnknownRegistryError> {
|
||||
try {
|
||||
createImmutableEvidenceBundle(
|
||||
[...records.values()],
|
||||
[...unknowns.values()],
|
||||
return ok(
|
||||
createImmutableEvidenceBundle(
|
||||
[...records.values()],
|
||||
[...unknowns.values()],
|
||||
),
|
||||
);
|
||||
} catch (cause: unknown) {
|
||||
if (
|
||||
!(cause instanceof z.ZodError) &&
|
||||
!(cause instanceof InvalidResidualUnknownGraphError)
|
||||
)
|
||||
throw cause;
|
||||
return err(new UnknownRegistryError("integrity", { cause }));
|
||||
}
|
||||
return ok(undefined);
|
||||
}
|
||||
|
||||
#commit(
|
||||
records: ReadonlyMap<string, Evidence>,
|
||||
unknowns: ReadonlyMap<string, ResidualUnknown>,
|
||||
): void {
|
||||
this.#records.clear();
|
||||
for (const [id, evidence] of records)
|
||||
this.#records.set(id, immutableEvidence(evidence));
|
||||
this.#unknownRevisions.clear();
|
||||
this.#unknownHeads.clear();
|
||||
for (const [key, unknown] of unknowns) {
|
||||
this.#unknownRevisions.set(key, unknown);
|
||||
const head = this.#unknownHeads.get(unknown.unknown_id);
|
||||
#commit(bundle: EvidenceBundle): void {
|
||||
const records = new Map(
|
||||
bundle.records.map((evidence) => [evidence.evidence_id, evidence]),
|
||||
);
|
||||
const unknownRevisions = new Map(
|
||||
bundle.unknowns.map((unknown) => [unknownRevisionKey(unknown), unknown]),
|
||||
);
|
||||
const unknownHeads = new Map<string, ResidualUnknown>();
|
||||
for (const unknown of bundle.unknowns) {
|
||||
const head = unknownHeads.get(unknown.unknown_id);
|
||||
if (head === undefined || head.revision < unknown.revision)
|
||||
this.#unknownHeads.set(unknown.unknown_id, unknown);
|
||||
unknownHeads.set(unknown.unknown_id, unknown);
|
||||
}
|
||||
this.#records = records;
|
||||
this.#unknownRevisions = unknownRevisions;
|
||||
this.#unknownHeads = unknownHeads;
|
||||
}
|
||||
}
|
||||
|
||||
/** A caller's unknown that fails its schema is an input mistake, not a state change. */
|
||||
const unknownInputError = (
|
||||
operation: "record_unknown" | "update_unknown",
|
||||
cause: unknown,
|
||||
input: RecordUnknownInput | UpdateUnknownInput,
|
||||
): UnknownRegistryError | AnalysisInputError =>
|
||||
cause instanceof z.ZodError
|
||||
? requestInputError(operation, cause, input)
|
||||
: new UnknownRegistryError("invalid-transition", { cause });
|
||||
const readLedgerEvidence = (
|
||||
input: unknown,
|
||||
message: string,
|
||||
): Result<Evidence, EvidenceIntegrityError> => {
|
||||
const checked = readImmutableEvidence(input);
|
||||
return checked.ok
|
||||
? checked
|
||||
: err(
|
||||
new EvidenceIntegrityError(message, {
|
||||
cause: checked.error.cause,
|
||||
}),
|
||||
);
|
||||
};
|
||||
|
||||
const unknownRevisionKey = (unknown: ResidualUnknown): string =>
|
||||
`${unknown.unknown_id}:${String(unknown.revision)}`;
|
||||
|
||||
Reference in new issue
Block a user