mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 19:53:50 +00:00
test: let the deadline policy own test waits
Vitest's expect.poll and vi.waitFor stop after one second by default, a host-speed guess that the project's deadline policy does not see. Under hosted-CI load, kunaProjectConcurrency failed that way twice on unrelated PRs. Another 256 waits relied on the default, and 97 passed literals picked to fit some host. Waits now take as long as their test may run, less the reporting reserve that children already keep. Each Vitest project sets expect.poll's default, and the new waitFor in tests/support/testWait.ts replaces vi.waitFor. Fixture readiness waits (awaitAcknowledgement and the provider process waits) default to the same deadline, and their host-speed literal arguments are removed. One remainingTestDeadline owns the arithmetic for both children and waits. Ten waits whose short timeout was the real check now assert it directly (Kuna version probe, Cutter discovery, doctor and Inspector cancellation, apktool fixture teardown, JADX disconnect): settlement before the production deadline that would otherwise also satisfy the wait, or a deadline pinned beyond every test deadline. The rea/project-wait-deadline lint rule rejects vi.waitFor and explicit expect.poll timeouts. The testing guide and the CI tests audit skill now document the policy. Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
This commit is contained in:
1 parent
054fbc4c26
commit
07e4b700ac
119 files changed
+818
-648
No files matched your search
@@ -14,6 +14,7 @@ import type {
|
||||
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
||||
import { projectAnalysisError } from "../domain/analysisErrorProjection.js";
|
||||
import { ScreenJudgeProcess } from "./ScreenJudgeProcess.js";
|
||||
import { waitFor } from "../../tests/support/testWait.js";
|
||||
|
||||
vi.mock("./AgentEnvComputerHelper.js", async (importOriginal) => ({
|
||||
...(await importOriginal<typeof import("./AgentEnvComputerHelper.js")>()),
|
||||
@@ -261,7 +262,7 @@ it("waits for final process cleanup after cancellation and keeps its owner", asy
|
||||
settled = true;
|
||||
});
|
||||
// Wait for the mocked command to receive control, not just for the judge to start.
|
||||
await vi.waitFor(() =>
|
||||
await waitFor(() =>
|
||||
expect(vi.mocked(runOwnedCommand).mock.calls.at(-1)?.[2]?.signal).toBe(
|
||||
controller.signal,
|
||||
),
|
||||
|
||||
Reference in new issue
Block a user