refactor(verifiers): centralize named artifact output admission

Route six artifact verifiers through the canonical complete MCP output and error parsers. Remove duplicated JSON/schema interpretation while retaining Evidence authentication, provider provenance, independent CLI parsing and CLI/MCP parity checks. Validate malformed success/error envelopes at the shared boundary.

Validation: 11 boundary tests, Go compiler verifier (30 cases), and synthetic IL2CPP/Flutter verifier workflows passed; typecheck/lint passed. PCAP readiness passed with stub tools, but capture inspection is unsupported on macOS. Linux-only binary-layout and EVM verifier toolchains were unavailable.
This commit is contained in:
morluto committed 2026-10-26 22:48:22 +08:00
1 parent f02df45a46
commit 0828917c79
8 files changed
+147 -65

No files matched your search

@@ -1,3 +1,5 @@
import { toolContract } from "../../../src/contracts/toolContracts.js";
import type { ToolContract } from "../../../src/contracts/toolContractTypes.js";
import { createEvidence } from "../../../src/domain/evidence.js";
import {
createEvidenceBundle,
@@ -6,6 +8,12 @@ import {
import { expect, it } from "vitest";
interface VerifierResults {
readonly requireMcpOutput: (
result: unknown,
operation: string,
contract?: ToolContract,
) => unknown;
readonly requireMcpToolError: (result: unknown) => unknown;
readonly requireMcpEvidenceBundle: (result: unknown) => EvidenceBundle;
readonly requireMcpLifecycleResult: (
result: unknown,
@@ -182,3 +190,79 @@ it("retains summary discovery in the generic lifecycle reader but refuses it as
"summary metadata instead of complete Evidence",
);
});
const namedEvidence = () =>
createEvidence(
{
path: "/fixture/image.bin",
sha256: "a".repeat(64),
format: "elf",
architecture: "x86_64",
},
{ id: "fixture", name: "Fixture", version: "1" },
{
operation: "address_name",
parameters: { address: "0x1000" },
result: "entry",
rawResult: { engine_name: "entry", source: "symbol table" },
},
);
const textReply = (value: unknown) => ({
content: [{ type: "text", text: JSON.stringify(value) }],
});
it("returns complete named Evidence with its subject, provider and analysis provenance", async () => {
const { requireMcpOutput } = await verifierResults();
const evidence = namedEvidence();
expect(requireMcpOutput(textReply(evidence), "address_name")).toEqual(
evidence,
);
});
it("rejects mismatched named contracts, error-marked success and malformed normalized results", async () => {
const { requireMcpOutput } = await verifierResults();
const evidence = namedEvidence();
expect(() =>
requireMcpOutput(
textReply(evidence),
"address_name",
toolContract("set_address_name"),
),
).toThrow("received the set_address_name contract");
expect(() =>
requireMcpOutput({ ...textReply(evidence), isError: true }, "address_name"),
).toThrow("address_name failed");
expect(() =>
requireMcpOutput(
textReply({ ...evidence, normalized_result: { name: "entry" } }),
"address_name",
),
).toThrow();
});
it("requires canonical complete tool errors before inspecting their diagnostic fields", async () => {
const { requireMcpToolError } = await verifierResults();
const error = {
code: "invalid_request",
category: "invalid_input",
message: "The address is invalid",
retryable: false,
remediation: { action: "Choose an observed address" },
details: { operation: "address_name", address: "bad" },
};
expect(
requireMcpToolError({ ...textReply({ error }), isError: true }),
).toEqual(error);
for (const value of [
{ error: { category: "invalid_input" } },
error,
{ error: { ...error, retryable: "false" } },
{ error: { ...error, code: "vendor_failure" } },
])
expect(() =>
requireMcpToolError({ ...textReply(value), isError: true }),
).toThrow();
expect(() => requireMcpToolError(textReply({ error }))).toThrow(
"Expected an MCP tool failure",
);
});