diff --git a/scripts/verify/baselines/local-completeness-enum.json b/scripts/verify/baselines/local-completeness-enum.json index 0899fc2094..766e15d92e 100644 --- a/scripts/verify/baselines/local-completeness-enum.json +++ b/scripts/verify/baselines/local-completeness-enum.json @@ -2,7 +2,6 @@ "src/contracts/cutterToolContracts.ts": 1, "src/contracts/rizinDebugToolContracts.ts": 1, "src/cutter/CutterBridgeClient.ts": 2, - "src/domain/adb/adbDeviceAnalysis.ts": 10, "src/domain/analysisView/analysisViewResult.ts": 1, "src/domain/analysisView/browserScenarioViewSchemas.ts": 1, "src/domain/analysisView/goBinaryView.ts": 1, diff --git a/src/domain/adb/adbDeviceAnalysis.ts b/src/domain/adb/adbDeviceAnalysis.ts index 902eb49335..f0c53273c0 100644 --- a/src/domain/adb/adbDeviceAnalysis.ts +++ b/src/domain/adb/adbDeviceAnalysis.ts @@ -3,6 +3,7 @@ import { adbTransportIdSchema, } from "./adbTransportIdentity.js"; import { z } from "zod"; +import { coverageStatusSchema } from "../coverage.js"; import { localPathStringSchema } from "../localPath.js"; import { IDENTIFIER_PATTERN } from "../stringPatterns.js"; @@ -478,6 +479,12 @@ export const adbRequestSchema = z.discriminatedUnion("operation", [ }), ]); +/** + * ADB results report known coverage: each operation counts the lines it could + * not parse and the items it could not fetch, so it never reports `unknown`. + */ +const adbCoverageSchema = coverageStatusSchema.exclude(["unknown"]); + const client = z.strictObject({ binary_path: z.string().min(1), path_source: z.enum(["environment", "path"]), @@ -652,7 +659,7 @@ export const adbResultSchemas = { }), ), unparsed_lines: z.array(z.string().min(1)), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), pull_adb_package: z.strictObject({ client, @@ -661,7 +668,7 @@ export const adbResultSchemas = { output_directory: z.string().min(1), artifacts: z.array(pulledArtifact), failures: z.array(pullFailure), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), read_adb_logcat: z.strictObject({ client, @@ -671,7 +678,7 @@ export const adbResultSchemas = { pid: z.int().positive().nullable(), lines: z.array(z.string()), total_bytes: z.int().nonnegative(), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), inspect_adb_package: z.strictObject({ client, @@ -692,7 +699,7 @@ export const adbResultSchemas = { pkg_flags: z.string().nullable(), requested_permissions_count: z.int().nonnegative().nullable(), numeric_issues: adbPackageNumericIssuesSchema, - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), pull_adb_file: z.strictObject({ client, @@ -740,7 +747,7 @@ export const adbResultSchemas = { }), ), unparsed_lines: z.array(z.string().min(1)), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), list_adb_directory: z.strictObject({ client, @@ -759,7 +766,7 @@ export const adbResultSchemas = { }), ), unparsed_lines: z.array(z.string().min(1)), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), list_adb_features: z.strictObject({ client, @@ -771,7 +778,7 @@ export const adbResultSchemas = { }), ), unparsed_lines: z.array(z.string().min(1)), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), list_adb_services: z.strictObject({ client, @@ -783,7 +790,7 @@ export const adbResultSchemas = { }), ), unparsed_lines: z.array(z.string().min(1)), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), inspect_adb_display: z.strictObject({ client, @@ -801,7 +808,7 @@ export const adbResultSchemas = { physical_density: z.int().positive().nullable(), override_density: z.int().positive().nullable(), numeric_issues: adbDisplayNumericIssuesSchema, - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), inspect_adb_window: z.strictObject({ client, @@ -841,7 +848,7 @@ export const adbResultSchemas = { ), exact_match: z.boolean(), unparsed_lines: z.array(z.string().min(1)), - coverage: z.enum(["complete", "partial"]), + coverage: adbCoverageSchema, }), install_adb_package: z.strictObject({ client,