From 1682d9c645b68bf871519c70e0dc4fb709f4d172 Mon Sep 17 00:00:00 2001 From: morluto <76467478+morluto@users.noreply.github.com> Date: Sun, 15 Nov 2026 21:19:20 +0800 Subject: [PATCH] fix(native): report Objective-C class import binding coverage unknown when candidate completeness is unstated (#11139) --- src/domain/native/objcSwiftMetadata.ts | 7 ++++++- src/native/AppleDispatchMetadata.test.ts | 4 ++-- .../AppleObjcClassImportBindings.test.ts | 4 ++-- src/native/AppleObjcClassImportBindings.ts | 18 +++++++++++++++--- 4 files changed, 25 insertions(+), 8 deletions(-) diff --git a/src/domain/native/objcSwiftMetadata.ts b/src/domain/native/objcSwiftMetadata.ts index a4a3da094c..8782398601 100644 --- a/src/domain/native/objcSwiftMetadata.ts +++ b/src/domain/native/objcSwiftMetadata.ts @@ -350,6 +350,11 @@ export const objcClassImportIdentitySchema = machoImportBindingSchema.omit({ export const objcClassImportBindingCoverageSchema = nativeMetadataCoverageSchema.extend({ facet: z.literal("objc_class_import_bindings"), + /** `unknown` when the caller did not state whether the candidates are complete. */ + status: z.enum([ + ...nativeMetadataCoverageSchema.shape.status.options, + "unknown", + ]), examined: z.number().int().nonnegative(), decoded: z.number().int().nonnegative(), }); @@ -466,7 +471,7 @@ export const nativeDispatchMetadataInputSchema = z.strictObject({ objc_class_import_addresses_complete: z .boolean() .describe( - "Whether the candidate addresses include every selected class-label row. false keeps binding coverage partial when the existing record budget truncates the scan; omitted is unknown and also keeps it partial.", + "Whether the candidate addresses include every selected class-label row. false keeps binding coverage partial when the existing record budget truncates the scan; omitted makes binding coverage unknown.", ) .optional(), max_input_bytes: z diff --git a/src/native/AppleDispatchMetadata.test.ts b/src/native/AppleDispatchMetadata.test.ts index f4d28f96a3..feeb13df61 100644 --- a/src/native/AppleDispatchMetadata.test.ts +++ b/src/native/AppleDispatchMetadata.test.ts @@ -502,7 +502,7 @@ describe("Imported class symbol byte identities", () => { }); describe("Imported class symbol candidate completeness", () => { - it("keeps binding coverage partial when the caller does not state the candidates are complete", () => { + it("reports binding coverage unknown when the caller does not state the candidates are complete", () => { const result = decodeAppleDispatchMetadata( swiftExternalSwiftBindingImage("objc-class"), 100, @@ -514,7 +514,7 @@ describe("Imported class symbol candidate completeness", () => { expect.objectContaining({ symbol: "_OBJC_CLASS_$_NSObject" }), ]); expect(result.objc_class_import_binding_coverage).toMatchObject({ - status: "partial", + status: "unknown", reason: expect.stringContaining("objc_class_import_addresses_complete"), }); }); diff --git a/src/native/AppleObjcClassImportBindings.test.ts b/src/native/AppleObjcClassImportBindings.test.ts index 6e176ac6db..c7e0dfea53 100644 --- a/src/native/AppleObjcClassImportBindings.test.ts +++ b/src/native/AppleObjcClassImportBindings.test.ts @@ -227,14 +227,14 @@ describe("Objective-C import binding address inspection", () => { }); describe("Objective-C import binding candidate completeness", () => { - it("keeps coverage partial when the candidates' completeness was not stated", () => { + it("reports coverage unknown when the candidates' completeness was not stated", () => { for (const addresses of [["0x1000", "0x1008"], []]) expect( inspectObjcClassImportBindings( createInput({ addresses, addressesComplete: undefined }), ).coverage, ).toMatchObject({ - status: "partial", + status: "unknown", reason: expect.stringContaining("did not state"), }); }); diff --git a/src/native/AppleObjcClassImportBindings.ts b/src/native/AppleObjcClassImportBindings.ts index 56b09b080e..922e3b0b43 100644 --- a/src/native/AppleObjcClassImportBindings.ts +++ b/src/native/AppleObjcClassImportBindings.ts @@ -5,7 +5,12 @@ import type { MachoImportBinding } from "../domain/native/objcSwiftMetadata.js"; export interface ObjcClassImportBindingScan { readonly bindings: readonly MachoImportBinding[]; readonly coverage: { - readonly status: "complete" | "partial" | "unsupported" | "not_requested"; + readonly status: + | "complete" + | "partial" + | "unknown" + | "unsupported" + | "not_requested"; readonly reason: string | null; readonly examined: number; readonly decoded: number; @@ -25,7 +30,7 @@ export const inspectObjcClassImportBindings = (input: { const { bytes, layout, fixups, addresses, addressesComplete, maxRecords } = input; // A candidate scan that is truncated, or whose completeness was not stated, - // keeps its limitation even when no candidate was retained. + // reports that limitation even when no candidate was retained. if ( addresses === undefined || (addresses.length === 0 && addressesComplete === true) @@ -112,7 +117,14 @@ export const inspectObjcClassImportBindings = (input: { return { bindings, coverage: { - status: reason === null ? "complete" : "partial", + // Unstated candidate completeness leaves the whole scan's coverage + // unknown, even when other gaps are also known. + status: + addressesComplete === undefined + ? "unknown" + : reason === null + ? "complete" + : "partial", reason, examined: examinedAddresses.size, decoded: bindings.length,