fix(javascript): exclude TypeScript this annotations from runtime parameters (#2761)

* fix(javascript): exclude TypeScript this annotations from runtime parameters

* test(javascript): assert exact typed argument bindings

* test(apple): keep dyld slice regression portable

* fix(process): report no remaining time after a provider deadline fires

Node timers can fire while performance.now() is still a fraction of a
millisecond short of the monotonic deadline. ProviderStartupDeadline then
reported interruption "timeout" and an aborted signal while remainingMs()
returned ceil(0.x) = 1, so polling loops guarded by remainingMs() > 0
(Hopper and Ghidra startup) could run past an elapsed deadline, and the
real-timer test "aborts a bounded wait when its real monotonic deadline
expires" failed intermittently in CI (expected 1 to be 0).

Once the deadline's own timer has classified a timeout, report zero
remaining time. A deterministic regression test fires the timer with the
monotonic clock 0.4 ms short of the deadline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ci): restore descriptor and fixture validation

* test(ci): retain verification coverage within lint limits

* fix(test): share admitted Ghidra profile installation fixtures

* fix(ci): isolate timing report fixtures from workflow state

---------

Co-authored-by: hhang <169027046+xu91102@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
This commit is contained in:
authored and GitHub committed 2026-10-14 07:18:50 +08:00
1 parent 02987d8e8c
commit 1ae9000587
23 files changed
+309 -166

No files matched your search

@@ -18,6 +18,7 @@ import {
} from "./javascriptSemanticProjection.js";
import {
semanticObjectPatternKeys,
runtimeFunctionParameters,
semanticStaticPropertyKey,
semanticWriteTargets,
} from "./javascriptAstValues.js";
@@ -717,7 +718,7 @@ function* collectDefinitionsSteps(
functionBodies.push({
body: node,
scope: nested,
parameters: parent.params,
parameters: runtimeFunctionParameters(parent),
});
}
const scope = currentSemanticScope(stack);
@@ -1076,7 +1077,7 @@ const scopeKind = (
};
const functionParametersHaveExpressions = (node: t.Function): boolean => {
const pending: t.Node[] = [...node.params];
const pending: t.Node[] = [...runtimeFunctionParameters(node)];
while (pending.length > 0) {
const parameter = pending.pop();
if (t.isAssignmentPattern(parameter)) return true;
@@ -1133,7 +1134,7 @@ const bindFunctionLocals = (
scope: JavaScriptSemanticScopeState,
state: JavaScriptSemanticAnalysisState,
): void => {
for (const parameter of node.params)
for (const parameter of runtimeFunctionParameters(node))
bindPattern({
pattern: t.isTSParameterProperty(parameter)
? parameter.parameter