diff --git a/tests/boundary/cli/scenarioManifestCoverage.test.ts b/tests/boundary/cli/scenarioManifestCoverage.test.ts index 1f188f88e5..43128e635e 100644 --- a/tests/boundary/cli/scenarioManifestCoverage.test.ts +++ b/tests/boundary/cli/scenarioManifestCoverage.test.ts @@ -3,7 +3,10 @@ import { expect, it } from "vitest"; import { registerAnalysisViewCommands } from "../../../src/cli/analysisViewCommands.js"; import { sanitizeBrowserUrl } from "../../../src/domain/browserObservation.js"; -import { browserScenarioCaptureSchema } from "../../../src/domain/browserScenarioCapture.js"; +import { + browserScenarioCaptureSchema, + type BrowserScenarioCapture, +} from "../../../src/domain/browserScenarioCapture.js"; import { silentLogger } from "../../../src/logger.js"; import { scenarioCaptureEvidence, @@ -17,6 +20,46 @@ const unusableUrls = [ "not a url", "https:example.test/api/items", ]; +const omittedRequestCount = new RegExp( + `^${String(unusableUrls.length)}\\b.*without a usable request line\\b`, + "u", +); + +const projectManifest = async (capture: BrowserScenarioCapture) => { + const cli = createCommandCli(); + registerAnalysisViewCommands(cli, silentLogger); + let stdout = ""; + let exitCode = 0; + await cli.serve( + [ + "inspect-analysis-view", + JSON.stringify({ + source: { kind: "inline", evidence: scenarioCaptureEvidence(capture) }, + view: { kind: "environment-manifest" }, + }), + "--json", + ], + { + env: {}, + stdout: (text) => { + stdout += text; + }, + exit: (code) => { + exitCode = code; + }, + }, + ); + expect(exitCode, stdout).toBe(0); + return ( + JSON.parse(stdout) as { + normalized_result: { + records: { ordinal: number }[]; + tools: unknown[]; + limitations: string[]; + }; + } + ).normalized_result; +}; const manifest = async ( urls: readonly string[], @@ -49,51 +92,16 @@ const manifest = async ( }), }, }); - const cli = createCommandCli(); - registerAnalysisViewCommands(cli, silentLogger); - let stdout = ""; - let exitCode = 0; - await cli.serve( - [ - "inspect-analysis-view", - JSON.stringify({ - source: { kind: "inline", evidence: scenarioCaptureEvidence(capture) }, - view: { kind: "environment-manifest" }, - }), - "--json", - ], - { - env: {}, - stdout: (text) => { - stdout += text; - }, - exit: (code) => { - exitCode = code; - }, - }, - ); - expect(exitCode).toBe(0); - return ( - JSON.parse(stdout) as { - normalized_result: { - records: { ordinal: number }[]; - limitations: string[]; - }; - } - ).normalized_result; + return projectManifest(capture); }; -it.each( - unusableUrls.flatMap((url) => - (["absent", "redacted"] as const).map((body) => ({ url, body })), - ), -)( - "excludes $url from scenario $body body-retention coverage through the CLI handler", - async ({ url, body }) => { - const result = await manifest([url], body); +it.each(["absent", "redacted"] as const)( + "omits scenario %s body-retention coverage when no request line is usable", + async (body) => { + const result = await manifest(unusableUrls, body); expect(result.records).toEqual([]); expect(result.limitations).toContainEqual( - expect.stringMatching(/1.*request line.*not represented.*manifest/iu), + expect.stringMatching(omittedRequestCount), ); expect( result.limitations.filter((limitation) => @@ -111,17 +119,19 @@ it.each(["absent", "redacted"] as const)( expect(result.records.map((record) => record.ordinal)).toEqual([ unusableUrls.length, ]); - expect(result.limitations).toContain( - `${String(unusableUrls.length)} retained records without a usable request line are not represented in the manifest.`, + expect(result.limitations).toContainEqual( + expect.stringMatching(omittedRequestCount), ); expect( result.limitations.filter((limitation) => limitation.includes("scenario transactions with a usable request line"), ), ).toEqual([ - body === "absent" - ? "1 of 1 scenario transactions with a usable request line retained no response body; tools citing them replay only the recorded status and content type, either of which may be absent." - : "1 of 1 scenario transactions with a usable request line retained a response body with declared secret values replaced by redaction markers; tools citing them replay the redacted bytes.", + expect.stringMatching( + body === "absent" + ? /^1 of 1\b.*\bno response body\b/u + : /^1 of 1\b.*\bredaction markers\b/u, + ), ]); }, ); @@ -144,38 +154,7 @@ it("does not derive a tool from conflicting header-only MIME evidence through th })), }, ]); - const cli = createCommandCli(); - registerAnalysisViewCommands(cli, silentLogger); - let stdout = ""; - let exitCode = 0; - await cli.serve( - [ - "inspect-analysis-view", - JSON.stringify({ - source: { - kind: "inline", - evidence: scenarioCaptureEvidence(capture), - }, - view: { kind: "environment-manifest" }, - }), - "--json", - ], - { - env: {}, - stdout: (text) => { - stdout += text; - }, - exit: (code) => { - exitCode = code; - }, - }, - ); - expect(exitCode, stdout).toBe(0); - const result = ( - JSON.parse(stdout) as { - normalized_result: { tools: unknown[] }; - } - ).normalized_result; + const result = await projectManifest(capture); expect(result.tools, JSON.stringify(values)).toHaveLength( values.every((value) => value === "application/json") ? 1 : 0, );