refactor(application): build application cancellations with a required reason (#10574)

* refactor(application): build application cancellations with a required reason

Migrate every AnalysisCancelledError construction under src/application
to cancelledBy and lower the guard baseline from 671 to 442.

Shutdown refusals in BinarySession report OwnerCancellation.ownerClosed
when the caller did not abort, instead of an undefined reason.
ReverseEngineeringService and DesktopBuildOwnedWork close their work
with the typed owner reason. SharedStartupAttempt returns the departing
caller's reason with a cancelled wait. One shared isAborted predicate
replaces eleven local copies and narrows a checked signal for
cancelledBy.

* refactor(desktop): drop an unused cancellation import from desktop capture state
This commit is contained in:
morluto authored and GitHub committed 2026-11-15 18:38:24 +08:00
1 parent 0ddc732c69
commit 2826592759
86 files changed
+554 -1012

No files matched your search

+11 -17
View File
@@ -12,9 +12,10 @@ import { publishWebScripts } from "../browser/assets/PublishWebScripts.js";
import { selectScriptCapture } from "../browser/assets/ScriptCaptureAdapters.js";
import {
AnalysisAccessDeniedError,
AnalysisCancelledError,
AnalysisInputError,
AnalysisOutputError,
cancelledBy,
carriedReason,
} from "../domain/analysisErrorCore.js";
import { AnalysisError } from "../domain/analysisErrorBase.js";
import { ConfigurationError } from "../domain/configurationErrors.js";
@@ -87,9 +88,7 @@ export const exportWebScriptsValidated = async (
): Promise<Result<Evidence, AnalysisError>> => {
try {
if (options.signal?.aborted)
return err(
new AnalysisCancelledError(OPERATION, { cause: options.signal.reason }),
);
return err(cancelledBy(OPERATION, options.signal));
const prepared = await prepareCapture(
input.capture_path,
resources,
@@ -98,9 +97,7 @@ export const exportWebScriptsValidated = async (
if (!prepared.ok) return prepared;
const { bytes, loaded } = prepared.value;
if (options.signal?.aborted)
return err(
new AnalysisCancelledError(OPERATION, { cause: options.signal.reason }),
);
return err(cancelledBy(OPERATION, options.signal));
const sha256 = createHash("sha256").update(bytes).digest("hex");
const result = await publishWebScripts(input, loaded, sha256, {
resources,
@@ -108,8 +105,7 @@ export const exportWebScriptsValidated = async (
});
if (options.signal?.aborted === true)
return err(
new AnalysisCancelledError(OPERATION, {
cause: options.signal.reason,
cancelledBy(OPERATION, options.signal, {
partialObservation: { kind: "web-script-export", result },
}),
);
@@ -190,8 +186,7 @@ const mapExportFailure = (
cause.message,
{ cause, partialObservation: cause.partialObservation },
)
: new AnalysisCancelledError(OPERATION, {
cause: cause.cancellation.reason,
: cancelledBy(OPERATION, carriedReason(cause.cancellation.reason), {
partialObservation: cause.partialObservation,
});
if (cause.cleanup === undefined) return primary;
@@ -271,9 +266,10 @@ const readCapture = async (
? { reason: signal.reason }
: regularFileCancellation(cause);
if (cancellation !== undefined) {
const primary = new AnalysisCancelledError(OPERATION, {
cause: cancellation.reason,
});
const primary = cancelledBy(
OPERATION,
carriedReason(cancellation.reason),
);
return err(
retry.cleanup === undefined
? primary
@@ -304,9 +300,7 @@ const captureReadFailure = (
): AnalysisError => {
const cancellation = regularFileCancellation(failure);
if (cancellation !== undefined)
return new AnalysisCancelledError(OPERATION, {
cause: cancellation.reason,
});
return cancelledBy(OPERATION, carriedReason(cancellation.reason));
const primary =
failure instanceof RegularFileCleanupFailure &&
failure.outcome.kind === "failed"