fix(electron): report rejected CLI arguments with issue details (#5036)

* fix(electron): report rejected CLI arguments with issue details

Pass schema validation issues and submitted input to inputError in list-electron-targets and inspect-electron-page commands, matching the structured diagnostics returned by browser commands.

Fixes #3865

* test(electron): assert exit code 1 on rejected CLI arguments
This commit is contained in:
KIEU TRONG KHANG authored and GitHub committed 2026-10-22 04:08:52 +08:00
1 parent b0a554cc3a
commit 2aadcf7d04
2 files changed
+77 -11

No files matched your search

+18 -6
View File
@@ -217,10 +217,16 @@ const registerElectronTargetList = (
withCommandCancellation((signal) =>
logCliCommand(logger, "list-electron-targets", async () => {
const context = await electronObservationContext();
const parsed = listElectronTargetsInputSchema.safeParse({
const input = {
cdp_endpoint: args.endpoint,
});
if (!parsed.success) return inputError("list_electron_targets");
};
const parsed = listElectronTargetsInputSchema.safeParse(input);
if (!parsed.success)
return inputError(
"list_electron_targets",
parsed.error.issues,
input,
);
const { listElectronTargets } =
await import("../application/javascript/ElectronObservationService.js");
return await finishAnalysisCommand(
@@ -255,13 +261,19 @@ const registerElectronPageInspection = (
withCommandCancellation((signal) =>
logCliCommand(logger, "inspect-electron-page", async () => {
const context = await electronObservationContext();
const parsed = inspectElectronPageInputSchema.safeParse({
const input = {
cdp_endpoint: args.endpoint,
target_id: args.targetId,
observation_ms: options.observationMs,
include_script_sources: options.includeScriptSources,
});
if (!parsed.success) return inputError("inspect_electron_page");
};
const parsed = inspectElectronPageInputSchema.safeParse(input);
if (!parsed.success)
return inputError(
"inspect_electron_page",
parsed.error.issues,
input,
);
const { inspectElectronPage } =
await import("../application/javascript/ElectronObservationService.js");
return await finishAnalysisCommand(