fix(native): preserve function byte source qualifications (#8606)

* fix(native): preserve function byte source qualifications

* fix(native): recover oversized inline matching sources

* test(native): verify matching byte source recovery

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This commit is contained in:
morlutoandCursor Agent authored and GitHub committed 2026-11-05 04:01:16 +08:00
1 parent 4ec2726b1b
commit 2b740cab36
7 files changed
+524 -3

No files matched your search

@@ -12,6 +12,7 @@ import { createEvidence, type Evidence } from "../../domain/evidence.js";
import { readFunctionInventory } from "../../domain/native/functionInventory.js";
import {
nativeFunctionMatchingSchema,
nativeFunctionByteSourceGuidance,
NATIVE_FUNCTION_MATCHING_PREDICATE,
} from "../../domain/native/functionMatching.js";
import { AnalysisError } from "../../domain/analysisErrorBase.js";
@@ -94,6 +95,38 @@ const matchWithAdmission = async (
rightFunctions,
{ identicalBytesComparable: compatible, checkpoint },
);
const byteSources: {
side: "left" | "right";
evidence_id: string;
limitations: string[];
}[] = [];
for (const [side, functions, observations] of [
["left", leftFunctions, leftObservations],
["right", rightFunctions, rightObservations],
] as const) {
const used = new Set<string>();
for (const item of functions)
for (const id of item.member.evidence_links) {
if (!used.has(id)) await checkpoint(128 + id.length * 4);
used.add(id);
}
for (const observation of observations) {
if (
observation.operation !== "read_bytes" ||
!used.has(observation.evidence_id)
)
continue;
used.delete(observation.evidence_id);
await checkpoint(512 + observation.evidence_id.length * 8);
for (const limitation of observation.limitations)
await checkpoint(128 + limitation.length * 8);
byteSources.push({
side,
evidence_id: observation.evidence_id,
limitations: [...observation.limitations],
});
}
}
const limitations = [
...new Set([
...left.limitations.map((x) => `Left: ${x}`),
@@ -101,6 +134,7 @@ const matchWithAdmission = async (
"Coverage is restricted to the supplied provider-observed inventories; missing/truncated inventory facts never prove absence from either binary.",
"Only unique exact symbols and bytes are paired. Compatible observed CFG/call/string fingerprints propose unresolved candidates, never identity or equivalence. Missing structural coverage stays unknown.",
"Name or byte correspondence is not behavioral equivalence; use analyze_function for selected pairs, then compare_functions. Existing dossier pairs include directly usable retained-reference inputs.",
...(byteSources.length === 0 ? [] : [nativeFunctionByteSourceGuidance]),
...(!compatible
? [
"Identical-byte matching unavailable: input architectures are missing or differ.",
@@ -141,6 +175,8 @@ const matchWithAdmission = async (
).length,
},
summary,
byte_sources_count: byteSources.length,
byte_sources: byteSources,
matches,
limitations,
});