mirror of
https://github.com/morluto/rea.git
synced 2026-11-20 05:32:44 +00:00
fix(javascript): preserve object sibling reads across safe iterator close (#12587)
* fix(javascript): preserve sibling array reads under object bindings * fix(javascript): require coercible nested object pattern receivers
This commit is contained in:
1 parent
2b4442c0e9
commit
2ff20ce32e
3 files changed
+91
-10
No files matched your search
@@ -2038,13 +2038,67 @@ it.each([
|
||||
"candidate",
|
||||
],
|
||||
[
|
||||
"second nested iterator comes after first close",
|
||||
"second nested iterator after a harmless close",
|
||||
'const box={first:[0],items:["one"]};const {first:[used],items:[selected]}=box;box.items[0]="later";',
|
||||
["items", "0"],
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"second nested iterator below a different own-data object path",
|
||||
'const box={left:{first:[0]},right:{items:["one"]}};const {left:{first:[used]},right:{items:[selected]}}=box;box.right.items[0]="later";',
|
||||
["right", "items", "0"],
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"second nested iterator before a later return hook",
|
||||
'const box={first:[0],items:["one"]};const {first:[used],items:[selected]}=box;Object.getPrototypeOf([].values()).return=()=>({});box.items[0]="later";',
|
||||
["items", "0"],
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"second nested iterator after an inherited return hook",
|
||||
'const box={first:[0],items:["one"]};Object.prototype.return=()=>({});const {first:[used],items:[selected]}=box;box.items[0]="later";',
|
||||
["items", "0"],
|
||||
"candidate",
|
||||
],
|
||||
[
|
||||
"second nested iterator after an effectful first default",
|
||||
'const box={first:[undefined],items:["one"]};const {first:[used=(box.items[0]="default")],items:[selected]}=box;box.items[0]="later";',
|
||||
["items", "0"],
|
||||
"candidate",
|
||||
],
|
||||
[
|
||||
"second nested iterator after an intervening getter",
|
||||
'const box={first:[0],get between(){this.items[0]="getter";},items:["one"]};const {first:[used],between,items:[selected]}=box;box.items[0]="later";',
|
||||
["items", "0"],
|
||||
"candidate",
|
||||
],
|
||||
...[
|
||||
["null", "null", "candidate"],
|
||||
["void", "void 0", "candidate"],
|
||||
["unproved", "unknown()", "candidate"],
|
||||
["object", "{}", "resolved"],
|
||||
["array", "[]", "resolved"],
|
||||
["zero", "0", "resolved"],
|
||||
["false", "false", "resolved"],
|
||||
["empty string", '""', "resolved"],
|
||||
].map(
|
||||
([label, receiver, resolution]) =>
|
||||
[
|
||||
`second nested iterator after an empty pattern with receiver ${label}`,
|
||||
`const box={first:[0],middle:${receiver},items:["one"]};const {first:[used],middle:{},items:[selected]}=box;box.items[0]="later";`,
|
||||
["items", "0"],
|
||||
resolution,
|
||||
] as const,
|
||||
),
|
||||
[
|
||||
"second nested iterator after a prior assignment target",
|
||||
'const box={first:[0],items:["one"]};let used,selected;({first:[used],items:[selected]}=box);box.items[0]="later";',
|
||||
["items", "0"],
|
||||
"candidate",
|
||||
],
|
||||
] as const)(
|
||||
"owns a single native iterator below an object for %s",
|
||||
"owns native iterators below an object for %s",
|
||||
(_name, code, path, resolution) => {
|
||||
const graph = graphForJavaScript(code);
|
||||
const selected = graph.nodes.find(
|
||||
|
||||
Reference in new issue
Block a user