From 342471f28dc837a935c15cbb64b95ee7e23bb29d Mon Sep 17 00:00:00 2001 From: ShuaixinHuang <1836656514@qq.com> Date: Thu, 19 Nov 2026 11:29:21 +0800 Subject: [PATCH] ci(windows): reuse built runtime for package verifiers (#12178) Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com> --- .github/workflows/ci.yml | 5 +++-- .../boundary/filesystem/ciChangeScope.test.ts | 18 +++++++++++++----- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9dd5500d67..c1afb9057c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1083,14 +1083,15 @@ jobs: tests/boundary/filesystem/directoryArtifactReaderOpen.test.ts tests/boundary/filesystem/javascriptPackagePrecedence.test.ts tests/boundary/filesystem/javascriptArtifactContentIdentity.test.ts + # Use the runtime prepared above. npm pack still runs prepack. - name: Verify real Node Inspector discovery and observation timeout-minutes: 10 env: NODE_OPTIONS: "--max-old-space-size=1024" UV_THREADPOOL_SIZE: "2" - run: npm run verify:inspector + run: node scripts/verify/inspector/runtime-observation.mjs - name: Verify installed Windows package - run: npm run verify:package:windows + run: node scripts/verify-windows-package.mjs - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 with: node-version: 22.23.4 diff --git a/tests/boundary/filesystem/ciChangeScope.test.ts b/tests/boundary/filesystem/ciChangeScope.test.ts index 2177c9b11e..ced477fe0d 100644 --- a/tests/boundary/filesystem/ciChangeScope.test.ts +++ b/tests/boundary/filesystem/ciChangeScope.test.ts @@ -950,12 +950,20 @@ it("retains native Inspector verification on every documented package host", asy { os: "macos-15-intel", platform: "darwin", architecture: "x64" }, ], }); - const windowsInspector = stepSchema.parse( - workflow.jobs["windows-curated"].steps.find( - (step) => step.run === "npm run verify:inspector", - ), + const windowsSteps = workflow.jobs["windows-curated"].steps; + const windowsBuild = windowsSteps.findIndex( + (step) => step.run === "npm run build:cached", ); - expect(windowsInspector.if).toBeUndefined(); + expect(windowsBuild).toBeGreaterThanOrEqual(0); + expect(windowsSteps[windowsBuild]?.if).toBeUndefined(); + for (const verifier of [ + "node scripts/verify/inspector/runtime-observation.mjs", + "node scripts/verify-windows-package.mjs", + ]) { + const step = windowsSteps.findIndex(({ run }) => run === verifier); + expect(step).toBeGreaterThan(windowsBuild); + expect(windowsSteps[step]?.if).toBeUndefined(); + } }); it.each([