From 35595de07a06bf655613fa7dfcc642c0c79d7ae1 Mon Sep 17 00:00:00 2001 From: morluto <76467478+morluto@users.noreply.github.com> Date: Fri, 20 Nov 2026 10:58:39 -0500 Subject: [PATCH] test(cli): consolidate xrefs admission and prove fallback identity (#12873) --- .../composition/directAnalysisCleanup.test.ts | 15 +++++++ tests/composition/directAnalysisXrefs.test.ts | 39 ++++++------------- 2 files changed, 26 insertions(+), 28 deletions(-) diff --git a/tests/composition/directAnalysisCleanup.test.ts b/tests/composition/directAnalysisCleanup.test.ts index 54f552016e..8a1bc4dcb0 100644 --- a/tests/composition/directAnalysisCleanup.test.ts +++ b/tests/composition/directAnalysisCleanup.test.ts @@ -129,6 +129,7 @@ it("rejects malformed one-shot operation inputs before creating a session", asyn ...dependencies, createBinarySession: create, createNativeBinarySession: create, + createNativeDispatchBinarySession: create, createArtifactBinarySession: create, createManagedBinarySession: create, }; @@ -159,6 +160,10 @@ it("rejects malformed one-shot operation inputs before creating a session", asyn if (!result.ok) expect(result.error).toMatchObject({ code: "invalid_request" }); } + const xrefs = await runDirectAnalysis(guarded, "/missing", "xrefs", { + address: "table_only", + extra: true, + }); const managed = await runManagedProviderExecution( guarded, "/missing", @@ -172,6 +177,16 @@ it("rejects malformed one-shot operation inputs before creating a session", asyn code: "invalid_request", }); expect(create).not.toHaveBeenCalled(); + expect(xrefs).toMatchObject({ + ok: false, + error: { + code: "invalid_request", + details: { + operation: "xrefs", + issues: [{ path: ["extra"], reason: "unknown_argument" }], + }, + }, + }); }); it.each([false, true])( diff --git a/tests/composition/directAnalysisXrefs.test.ts b/tests/composition/directAnalysisXrefs.test.ts index ea8d367528..ba412a2fcb 100644 --- a/tests/composition/directAnalysisXrefs.test.ts +++ b/tests/composition/directAnalysisXrefs.test.ts @@ -18,7 +18,6 @@ import { } from "../fixtures/binarySession.js"; const inventory = [ - { address: "0x1000", value: "table_only" }, { address: "0x1000", value: "add" }, { address: "0x1000", value: "0xHelper" }, { address: "0x1000", value: "name:0xSuffix" }, @@ -55,7 +54,9 @@ const fixture = ( ), ); if (operation === "procedure_address") - return Promise.resolve(observed("0x1000")); + return Promise.resolve( + observed(parameters.procedure === "main" ? "0x5000" : null), + ); if (operation === "xrefs") { if (options.xrefsError !== undefined) return Promise.resolve(err(options.xrefsError)); @@ -77,6 +78,8 @@ const fixture = ( ]), ), ); + if (address === "0x5000") + return Promise.resolve(observed(["0x6000"])); return Promise.resolve( observed(address === "0x3000" ? [] : ["0x4000"]), ); @@ -100,29 +103,6 @@ const fixture = ( }; describe("direct CLI cross-reference selectors", () => { - it("rejects unknown arguments before opening a session", async () => { - const [path] = await createBinarySessionTargets(); - const provider = fixture({ - xrefsError: new AnalysisInputError("xrefs", undefined, [ - { path: ["address"], reason: "invalid_format" }, - ]), - }); - const result = await runDirectAnalysis( - provider.dependencies, - path, - "xrefs", - { address: "table_only", extra: true }, - ).then(projectCliAnalysisResult); - expect(result).toMatchObject({ - code: "invalid_request", - details: { - operation: "xrefs", - issues: [{ path: ["extra"], reason: "unknown_argument" }], - }, - }); - expect(provider.closed()).toBe(0); - }); - it("retains provider validation issues unrelated to symbol resolution", async () => { const [path] = await createBinarySessionTargets(); const issues = [ @@ -261,11 +241,11 @@ describe("direct CLI cross-reference name resolution", () => { }); const evidence = parseEvidence( await runDirectAnalysis(provider.dependencies, path, "xrefs", { - address: "table_only", + address: "main", }).then(projectCliAnalysisResult), ); - expect(evidence.parameters).toEqual({ address: "table_only" }); - expect(evidence.normalized_result).toEqual(["0x4000"]); + expect(evidence.parameters).toEqual({ address: "main" }); + expect(evidence.normalized_result).toEqual(["0x6000"]); expect(provider.closed()).toBe(1); }); @@ -289,6 +269,9 @@ describe("direct CLI cross-reference name resolution", () => { }, ).then(projectCliAnalysisResult); expect(result).toMatchObject({ code }); + expect(provider.calls.map(({ operation }) => operation)).not.toContain( + "procedure_address", + ); expect(provider.closed()).toBe(1); }, );