From 3bbdec3fc8e8f51e0118e8a2d0a95f829c087264 Mon Sep 17 00:00:00 2001
From: morluto <76467478+morluto@users.noreply.github.com>
Date: Sun, 15 Nov 2026 19:32:40 +0800
Subject: [PATCH] test(artifacts): compare ASAR block-integrity limitations
 with their owning constant (#11061)

Two tests matched three fragments of one limitation sentence, twice for the
same row. They now compare the row with BLOCK_INTEGRITY_LIMITATION from
AsarListing, beside the existing declared-integrity and hash-status facts.
---
 src/artifacts/AsarListing.ts                  |  3 ++-
 .../filesystem/asarListingAdmission.test.ts   | 20 ++++++-------------
 2 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/src/artifacts/AsarListing.ts b/src/artifacts/AsarListing.ts
index b534b97fb2..d225a9f773 100644
--- a/src/artifacts/AsarListing.ts
+++ b/src/artifacts/AsarListing.ts
@@ -9,7 +9,8 @@ import {
   DEFAULT_ASAR_LISTING_ADMISSION,
   type AsarListingAdmission,
 } from "../config/asarListingAdmission.js";
-const BLOCK_INTEGRITY_LIMITATION =
+/** Recorded once per member whose integrity declares a block table REA does not check. */
+export const BLOCK_INTEGRITY_LIMITATION =
   "ASAR block integrity declarations were not validated. Whole-file digest comparison does not establish block integrity or Electron runtime acceptance.";
 /** Source text quoted in listing diagnostics; longer values keep their length. */
 const MAX_QUOTED_SOURCE_UNITS = 256;
diff --git a/tests/boundary/filesystem/asarListingAdmission.test.ts b/tests/boundary/filesystem/asarListingAdmission.test.ts
index fa92e80dc5..1425ea3cc5 100644
--- a/tests/boundary/filesystem/asarListingAdmission.test.ts
+++ b/tests/boundary/filesystem/asarListingAdmission.test.ts
@@ -6,7 +6,10 @@ import { setImmediate } from "node:timers/promises";
 import { expect, it } from "vitest";
 
 import { AsarArtifactReader } from "../../../src/artifacts/AsarArtifactReader.js";
-import { readAsarListing } from "../../../src/artifacts/AsarListing.js";
+import {
+  BLOCK_INTEGRITY_LIMITATION,
+  readAsarListing,
+} from "../../../src/artifacts/AsarListing.js";
 import { resolveAsarHeaderAdmission } from "../../../src/artifacts/AsarHeader.js";
 import {
   asarHeaderBytes,
@@ -545,14 +548,7 @@ it("retains uninterpreted integrity declarations through packed and unpacked inv
     const row = occurrence(name);
     expect(row.declared_integrity).toEqual({ algorithm: "sha256", digest });
     expect(row.hash_status).toBe("verified");
-    expect(row.limitations).toEqual([
-      expect.stringContaining(
-        "block integrity declarations were not validated",
-      ),
-    ]);
-    expect(row.limitations[0]).toContain(
-      "does not establish block integrity or Electron runtime acceptance",
-    );
+    expect(row.limitations).toEqual([BLOCK_INTEGRITY_LIMITATION]);
   }
   for (const [name, declaration, reason] of [
     ["unsupported", unsupported, "unsupported algorithm"],
@@ -624,11 +620,7 @@ it.each([
       algorithm: "sha256",
       digest: "a".repeat(64),
     });
-    expect(entries[0]?.limitations).toEqual([
-      expect.stringContaining(
-        "block integrity declarations were not validated",
-      ),
-    ]);
+    expect(entries[0]?.limitations).toEqual([BLOCK_INTEGRITY_LIMITATION]);
   },
 );