From 3d0fa7dae2cd960c077aa63e8a80a2195a846a10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=90=B4=E4=BD=B3=E6=B5=A9Alben?= <35291372+XiaoBinGan@users.noreply.github.com> Date: Fri, 20 Nov 2026 03:23:54 +0800 Subject: [PATCH] refactor(managed): read metadata pointer rows through BinaryReader (#12483) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 吴佳浩 --- scripts/verify/baselines/raw-buffer-read.json | 1 - src/domain/managed/managedMemberPointers.ts | 7 +++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/scripts/verify/baselines/raw-buffer-read.json b/scripts/verify/baselines/raw-buffer-read.json index cf63bc7df0..7cd180fdba 100644 --- a/scripts/verify/baselines/raw-buffer-read.json +++ b/scripts/verify/baselines/raw-buffer-read.json @@ -13,7 +13,6 @@ "src/domain/elfRelocation.ts": 6, "src/domain/inesContainer.ts": 5, "src/domain/managed/managedCliHeaderPrefix.ts": 5, - "src/domain/managed/managedMemberPointers.ts": 2, "src/domain/managed/managedMetadataHeaps.ts": 4, "src/domain/managed/managedMetadataInventoryRows.ts": 2, "src/domain/managed/managedMetadataLayout.ts": 7, diff --git a/src/domain/managed/managedMemberPointers.ts b/src/domain/managed/managedMemberPointers.ts index 36446fbe99..2417775b04 100644 --- a/src/domain/managed/managedMemberPointers.ts +++ b/src/domain/managed/managedMemberPointers.ts @@ -1,3 +1,4 @@ +import { BinaryReader } from "../binaryContainer.js"; import { managedDecodeBudget } from "./managedDecodeBudget.js"; import type { ManagedMetadataLayout, @@ -73,10 +74,12 @@ export const memberListRowLookup = ( const positions = new Uint32Array(definitionCount + 1); try { const width = layout.tableIndexSize(table); + // The pointer table's index width is a property of the layout, not of the row, so one + // reader covers the whole scan and each row keeps the width the table declares. + const reader = new BinaryReader(bytes, true, "managed-metadata-pointers"); for (let row = 1; row <= pointers.rowCount; row += 1) { const offset: number = pointers.offset + (row - 1) * pointers.rowSize; - const definition = - width === 2 ? bytes.readUInt16LE(offset) : bytes.readUInt32LE(offset); + const definition = width === 2 ? reader.u16(offset) : reader.u32(offset); if (definition === 0 || definition > definitionCount) throw managedFailure( "invalid-row",