mirror of
https://github.com/morluto/rea.git
synced 2026-11-19 05:02:40 +00:00
refactor(process): give POSIX PATH search order one owner (#10891)
* refactor(process): give POSIX PATH search order one owner Program lookup, the packet-tool locator and Jadx's Java lookup each split PATH and resolved empty and relative entries themselves. They now take the candidates from posixPathCandidates in src/process/executableSearch and keep only their own probe and failure reporting. A counted architecture guard keeps new PATH splits from returning; the remaining Windows and Ghidra searches are baselined. * refactor(process): move the colon-split PATH searches onto the search owner REA's launcher-alias lookup and Ghidra's macOS Java lookup split PATH on ":" and skipped relative entries themselves; they now use posixPathCandidates with relativeEntries: "skip", and the guard counts colon splits of PATH as well. * fix(process): produce PATH candidates lazily so an unused entry cannot fail an earlier match * refactor(process): give Windows PATH/PATHEXT search order the executable search owner (#10916) * refactor(process): give Windows PATH/PATHEXT search order the executable search owner * fix(process): keep later PATH entries searchable after a stray quote or a removed working directory * fix(reverse): refuse a Windows objdump or Rizin command that PATH does not find (#10953) * fix(reverse): refuse an objdump or Rizin command Windows PATH does not find instead of launching the bare name * fix(reverse): report a Windows lookup refusal after cancellation and to capability discovery * fix(desktop): search a Windows host's PATH as Windows does when doctor looks up a program programOnPath sent every host through the POSIX PATH search, so on Windows a relative PATH entry reached absoluteCallerPath with platform linux and the Windows working directory, which resolved against itself until the stack overflowed. programOnPath now searches PATH and PATHEXT through windowsPathCandidates on a Windows host, and absoluteCallerPath refuses a non-POSIX working directory with a TypeError instead of recursing.
This commit is contained in:
1 parent
659772952d
commit
422cff00ab
23 files changed
+912
-330
No files matched your search
@@ -0,0 +1,170 @@
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
import {
|
||||
posixPathCandidates,
|
||||
windowsPathCandidates,
|
||||
} from "./executableSearch.js";
|
||||
|
||||
describe("posixPathCandidates", () => {
|
||||
it("searches PATH in order, resolving empty and relative entries against the working directory", () => {
|
||||
expect([
|
||||
...posixPathCandidates("tool", "/usr/bin::bin:/opt/./x/../y/", {
|
||||
relativeEntries: "resolve",
|
||||
workingDirectory: "/work",
|
||||
}),
|
||||
]).toEqual([
|
||||
{ path: "/usr/bin/tool", relativeEntry: false },
|
||||
{ path: "/work/tool", relativeEntry: true },
|
||||
{ path: "/work/bin/tool", relativeEntry: true },
|
||||
// `..` stays for the filesystem to resolve after a symbolic link.
|
||||
{ path: "/opt/x/../y/tool", relativeEntry: false },
|
||||
]);
|
||||
});
|
||||
|
||||
it("leaves out entries that depend on the working directory when asked", () => {
|
||||
expect([
|
||||
...posixPathCandidates("tool", ":bin:/usr/bin", {
|
||||
relativeEntries: "skip",
|
||||
}),
|
||||
]).toEqual([{ path: "/usr/bin/tool", relativeEntry: false }]);
|
||||
// An empty PATH is one empty entry: the working directory.
|
||||
expect([
|
||||
...posixPathCandidates("tool", "", { relativeEntries: "skip" }),
|
||||
]).toEqual([]);
|
||||
expect([
|
||||
...posixPathCandidates("tool", "", {
|
||||
relativeEntries: "resolve",
|
||||
workingDirectory: "/work",
|
||||
}),
|
||||
]).toEqual([{ path: "/work/tool", relativeEntry: true }]);
|
||||
});
|
||||
|
||||
it("resolves no entry after the one the caller stops at", () => {
|
||||
// Resolving `.` without a working directory reads this process's
|
||||
// directory, which may have been removed; an earlier match must not
|
||||
// depend on it.
|
||||
const cwd = vi.spyOn(process, "cwd").mockImplementation(() => {
|
||||
throw new Error("ENOENT: uv_cwd");
|
||||
});
|
||||
try {
|
||||
const [first] = posixPathCandidates("java", "/jdk/bin:.", {
|
||||
relativeEntries: "resolve",
|
||||
});
|
||||
expect(first).toEqual({ path: "/jdk/bin/java", relativeEntry: false });
|
||||
expect(cwd).not.toHaveBeenCalled();
|
||||
} finally {
|
||||
cwd.mockRestore();
|
||||
}
|
||||
});
|
||||
|
||||
it("skips relative entries once the working directory is removed and searches later ones", () => {
|
||||
const cwd = vi.spyOn(process, "cwd").mockImplementation(() => {
|
||||
throw new Error("ENOENT: uv_cwd");
|
||||
});
|
||||
try {
|
||||
expect([
|
||||
...posixPathCandidates("java", ".::/jdk/bin", {
|
||||
relativeEntries: "resolve",
|
||||
}),
|
||||
]).toEqual([{ path: "/jdk/bin/java", relativeEntry: false }]);
|
||||
const windows = windowsPathCandidates("java", {
|
||||
PATH: "bin;C:\\jdk\\bin",
|
||||
PATHEXT: ".EXE",
|
||||
});
|
||||
if (!windows.ok) throw new Error(windows.error.extension);
|
||||
expect([...windows.value]).toEqual([
|
||||
{ path: "C:\\jdk\\bin\\java.EXE", relativeEntry: false },
|
||||
]);
|
||||
} finally {
|
||||
cwd.mockRestore();
|
||||
}
|
||||
});
|
||||
|
||||
it("tries every name in an entry before the next entry", () => {
|
||||
expect([
|
||||
...posixPathCandidates(["ghidra", "ghidraRun"], "/a:/b", {
|
||||
relativeEntries: "skip",
|
||||
}),
|
||||
]).toEqual([
|
||||
{ path: "/a/ghidra", relativeEntry: false },
|
||||
{ path: "/a/ghidraRun", relativeEntry: false },
|
||||
{ path: "/b/ghidra", relativeEntry: false },
|
||||
{ path: "/b/ghidraRun", relativeEntry: false },
|
||||
]);
|
||||
});
|
||||
});
|
||||
|
||||
describe("windowsPathCandidates", () => {
|
||||
const paths = (
|
||||
...input: Parameters<typeof windowsPathCandidates>
|
||||
): readonly string[] => {
|
||||
const search = windowsPathCandidates(...input);
|
||||
if (!search.ok) throw new Error(search.error.extension);
|
||||
return [...search.value].map(({ path }) => path);
|
||||
};
|
||||
|
||||
it("searches quoted, relative and case-insensitive PATH entries with image PATHEXT extensions", () => {
|
||||
expect(
|
||||
paths(
|
||||
"rizin",
|
||||
{
|
||||
Path: '"C:\\Program Files\\a;b";.\\bin;;"";bad"quote',
|
||||
PathExt: ".CMD;.EXE;.COM",
|
||||
},
|
||||
{ cwd: "D:\\work" },
|
||||
),
|
||||
).toEqual([
|
||||
"C:\\Program Files\\a;b\\rizin.EXE",
|
||||
"C:\\Program Files\\a;b\\rizin.COM",
|
||||
"D:\\work\\bin\\rizin.EXE",
|
||||
"D:\\work\\bin\\rizin.COM",
|
||||
]);
|
||||
});
|
||||
|
||||
it("opens a quote only at the start of an entry, so a stray quote cannot hide later entries", () => {
|
||||
expect(
|
||||
paths(
|
||||
["ghidra.bat"],
|
||||
{ PATH: 'bad"quote;C:\\ghidra;"C:\\a;b"' },
|
||||
{ allowBatch: true, cwd: "C:\\" },
|
||||
),
|
||||
).toEqual(["C:\\ghidra\\ghidra.bat", "C:\\a;b\\ghidra.bat"]);
|
||||
});
|
||||
|
||||
it("includes batch launchers only when the caller can start them through cmd.exe", () => {
|
||||
const environment = { PATH: "C:\\tools", PATHEXT: ".BAT;.EXE" };
|
||||
expect(paths("apktool", environment, { cwd: "C:\\" })).toEqual([
|
||||
"C:\\tools\\apktool.EXE",
|
||||
]);
|
||||
expect(
|
||||
paths("apktool", environment, { cwd: "C:\\", allowBatch: true }),
|
||||
).toEqual(["C:\\tools\\apktool.BAT", "C:\\tools\\apktool.EXE"]);
|
||||
expect(paths("npm.cmd", environment, { cwd: "C:\\" })).toEqual([]);
|
||||
});
|
||||
|
||||
it("tries every launcher name in an entry before the next entry", () => {
|
||||
expect(
|
||||
paths(
|
||||
["ghidra.bat", "ghidra.exe"],
|
||||
{ PATH: "C:\\a;C:\\b" },
|
||||
{ allowBatch: true, cwd: "C:\\" },
|
||||
),
|
||||
).toEqual([
|
||||
"C:\\a\\ghidra.bat",
|
||||
"C:\\a\\ghidra.exe",
|
||||
"C:\\b\\ghidra.bat",
|
||||
"C:\\b\\ghidra.exe",
|
||||
]);
|
||||
});
|
||||
|
||||
it("fails a search that would append an invalid PATHEXT entry, but not one with a named extension", () => {
|
||||
const environment = { PATH: "C:\\jdk\\bin", PATHEXT: ".EXE;C:\\bad" };
|
||||
expect(windowsPathCandidates("java", environment)).toEqual({
|
||||
ok: false,
|
||||
error: { kind: "invalid_extension", extension: "C:\\bad" },
|
||||
});
|
||||
expect(paths("java.exe", environment, { cwd: "C:\\" })).toEqual([
|
||||
"C:\\jdk\\bin\\java.exe",
|
||||
]);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user