diff --git a/src/application/AnalysisSettings.test.ts b/src/application/AnalysisSettings.test.ts index 8f3a99ec9f..c360fd36f7 100644 --- a/src/application/AnalysisSettings.test.ts +++ b/src/application/AnalysisSettings.test.ts @@ -163,6 +163,17 @@ it("exposes shared provider controls and preserves the explicit unbounded decomp REA_GHIDRA_DECOMPILE_MAX_PAYLOAD_MIB: "64", }; const store = new AnalysisSettings(environment); + for (const provider of ["ghidra", "hopper"] as const) + expect( + store + .inspect({ provider, operation: "open_binary" }) + .settings.map(({ setting }) => setting), + ).toEqual( + expect.arrayContaining([ + `${provider}.startup_timeout_ms`, + "bridge.max_request_bytes", + ]), + ); const parsed = parseConfig(environment); if (!parsed.ok) throw parsed.error; const config = runtimeAnalysisConfig(parsed.value, store.read); diff --git a/src/domain/analysisSettingDefinitions.ts b/src/domain/analysisSettingDefinitions.ts index d54688dea6..0bef39f77d 100644 --- a/src/domain/analysisSettingDefinitions.ts +++ b/src/domain/analysisSettingDefinitions.ts @@ -227,6 +227,7 @@ export const ANALYSIS_SETTINGS = { appliesAt: "next_startup", provider: "ghidra", operations: [ + "open_binary", "binary_overview", "list_documents", "list_procedures", @@ -248,6 +249,7 @@ export const ANALYSIS_SETTINGS = { appliesAt: "next_startup", provider: "hopper", operations: [ + "open_binary", "binary_overview", "list_documents", "list_procedures", @@ -372,6 +374,7 @@ export const ANALYSIS_SETTINGS = { // Cutter bridge calls. bridgeMaxRequestBytes.test.ts fails when a registry // gains an operation that is missing here. operations: [ + "open_binary", "address_name", "comment", "current_address",