fix(errors): name rea doctor only for providers it can check (#10565)

* fix(errors): name rea doctor only for providers it can check

An unclassified ProviderAdapterError, an unreadable result and the final
presentation fallback all told the caller to run rea doctor, although doctor
checks only hopper, ghidra, ida, jadx, kuna and desktop_build. The doctor
scope list moves into the domain so presentation can consult it: covered
providers get `rea doctor --provider ID`, others are told plainly that the
failure is unclassified and where its reason is reported.

Producers whose actionable reason lived only in details.diagnostics now
author it: Ghidra's committed-profile conflicts share one owner that says to
reopen the target, closed analysis clients share one owner, and a jadx-reported
request failure no longer points at provider readiness. The deep-analysis
profile rejection names doctor only for doctor-checkable providers. Dead
presentation branches for tags handled earlier are removed.

* fix(errors): make provider recovery actionable

* test(android): remove brittle recovery wording check

* test: wait for observed child exit before cancellation

* test(errors): check that doctor is not offered instead of matching recovery prose
This commit is contained in:
morluto authored and GitHub committed 2026-11-15 18:09:40 +08:00
1 parent 428e006f66
commit 4aefe2daec
24 files changed
+257 -143

No files matched your search

+7
View File
@@ -52,6 +52,9 @@ import {
JADX_HEAP_REMEDIATION,
} from "./JadxRelease.js";
const JADX_REPORTED_FAILURE_REMEDIATION =
"jadx is running and reported this failure for the selected input, so provider readiness checks cannot repair it. Review details.diagnostics.reason and adjust the input or request if applicable. Repeating the unchanged request is not expected to succeed.";
type JadxCall = {
readonly operation: string;
readonly input: Readonly<Record<string, JsonValue>>;
@@ -431,7 +434,11 @@ export class JadxSession {
},
]);
}
// jadx answered, so its own reply, not provider readiness, explains
// the failure; doctor cannot repair a reported per-request error.
throw new ProviderAdapterError("jadx", request.operation, {
userMessage: `jadx reported an error for ${name} that REA did not classify; its reason is in details.diagnostics.reason.`,
remediationAction: JADX_REPORTED_FAILURE_REMEDIATION,
diagnostics: {
upstream_operation: name,
reason: text,