mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 03:33:25 +00:00
fix(errors): name rea doctor only for providers it can check (#10565)
* fix(errors): name rea doctor only for providers it can check An unclassified ProviderAdapterError, an unreadable result and the final presentation fallback all told the caller to run rea doctor, although doctor checks only hopper, ghidra, ida, jadx, kuna and desktop_build. The doctor scope list moves into the domain so presentation can consult it: covered providers get `rea doctor --provider ID`, others are told plainly that the failure is unclassified and where its reason is reported. Producers whose actionable reason lived only in details.diagnostics now author it: Ghidra's committed-profile conflicts share one owner that says to reopen the target, closed analysis clients share one owner, and a jadx-reported request failure no longer points at provider readiness. The deep-analysis profile rejection names doctor only for doctor-checkable providers. Dead presentation branches for tags handled earlier are removed. * fix(errors): make provider recovery actionable * test(android): remove brittle recovery wording check * test: wait for observed child exit before cancellation * test(errors): check that doctor is not offered instead of matching recovery prose
This commit is contained in:
1 parent
428e006f66
commit
4aefe2daec
24 files changed
+257
-143
No files matched your search
@@ -669,7 +669,10 @@ describe("analysis provider registry: rejection diagnostics", () => {
|
||||
providerId: "alpha",
|
||||
origin: "availability",
|
||||
code: "version_unresolved",
|
||||
remediation: expect.stringContaining("rea doctor") as unknown,
|
||||
// doctor cannot check this provider, so it is not offered.
|
||||
remediation: expect.not.stringContaining(
|
||||
"rea doctor",
|
||||
) as unknown,
|
||||
},
|
||||
],
|
||||
},
|
||||
|
||||
Reference in new issue
Block a user