diff --git a/src/application/analysisView/AnalysisViewService.test.ts b/src/application/analysisView/AnalysisViewService.test.ts index ca94588e65..83733c50bb 100644 --- a/src/application/analysisView/AnalysisViewService.test.ts +++ b/src/application/analysisView/AnalysisViewService.test.ts @@ -491,6 +491,15 @@ it("never seals a view as more certain than its parent Evidence", async () => { { kind: "summary" }, ), ]; + // The item view returns one selected section, not the whole collection. + expect(views[0]).toMatchObject({ + ok: true, + value: { + normalized_result: { + coverage: { examined: 1, total: 1, exhausted: true }, + }, + }, + }); for (const view of views) { if (!view.ok) throw view.error; expect(view.value.confidence).toBe(expected); diff --git a/src/domain/analysisView/EnvironmentManifestAccumulator.ts b/src/domain/analysisView/EnvironmentManifestAccumulator.ts index ae1cabbf22..66d56c0869 100644 --- a/src/domain/analysisView/EnvironmentManifestAccumulator.ts +++ b/src/domain/analysisView/EnvironmentManifestAccumulator.ts @@ -583,7 +583,7 @@ export class EnvironmentManifestAccumulator extends WebNetworkProjectionAccumula templated_groups: tools.filter((tool) => tool.params.length > 0).length + excluded.filter((exclusion) => exclusion.templated).length, - coverage: completeWithinViewCoverage(tools.length, tools.length), + coverage: completeWithinViewCoverage(tools.length), limitations: limitations.value, }); } diff --git a/src/domain/analysisView/analysisView.test.ts b/src/domain/analysisView/analysisView.test.ts index 69f1bf0dc3..2f0e21103d 100644 --- a/src/domain/analysisView/analysisView.test.ts +++ b/src/domain/analysisView/analysisView.test.ts @@ -579,7 +579,7 @@ it("projects layout summary, facet, item, and stable pages", () => { format: "elf", counts: { sections: 3, symbols: 3, segments: 0, relocations: 0 }, }, - coverage: completeWithinViewCoverage(6, 6), + coverage: completeWithinViewCoverage(6), }); const mitigations = projectAnalysisView(parent, { kind: "facet", diff --git a/src/domain/analysisView/analysisViewCoverage.ts b/src/domain/analysisView/analysisViewCoverage.ts index d5f694c0fd..d5ac40b70d 100644 --- a/src/domain/analysisView/analysisViewCoverage.ts +++ b/src/domain/analysisView/analysisViewCoverage.ts @@ -36,14 +36,18 @@ export const unavailableViewCoverage = (): z.output< exhausted: false, }); -/** Coverage for a summary, facet, or single selected object. */ +/** + * Coverage for a summary, facet, or single selected object that returns every + * record of its source collection. The view examined exactly the records it + * returns; whether the producer's collection is complete stays in the parent + * Evidence's own coverage and limitations. + */ export const completeWithinViewCoverage = ( - examined: number, - total: number, + returned: number, ): AnalysisViewCoverage => ({ status: "complete-within-view", - examined, - total, + examined: returned, + total: returned, next_offset: null, exhausted: true, }); diff --git a/src/domain/analysisView/androidPackageView.ts b/src/domain/analysisView/androidPackageView.ts index c455398d2b..20dccb9f2a 100644 --- a/src/domain/analysisView/androidPackageView.ts +++ b/src/domain/analysisView/androidPackageView.ts @@ -174,7 +174,7 @@ export const projectAndroidPackageView = ( text_included: false as const, }, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); } if (view.facet === "manifest") { @@ -299,7 +299,7 @@ export const projectAndroidPackageView = ( facet: "component-summary" as const, view, summary, - coverage: completeWithinViewCoverage(rows.length, rows.length), + coverage: completeWithinViewCoverage(rows.length), }; return jsonValueByteLength( result as unknown as JsonValue, diff --git a/src/domain/analysisView/androidSymbolView.ts b/src/domain/analysisView/androidSymbolView.ts index 3a39270ecf..329d84fd4d 100644 --- a/src/domain/analysisView/androidSymbolView.ts +++ b/src/domain/analysisView/androidSymbolView.ts @@ -101,7 +101,7 @@ export const projectAndroidSymbolSummary = ( path: parent.subject.local_path, sha256: parent.subject.digest.sha256, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), limitations: boundedViewMessages( parent.limitations, parent.evidenceId, diff --git a/src/domain/analysisView/apiContractView.ts b/src/domain/analysisView/apiContractView.ts index f6cf48fc71..9b6d99b122 100644 --- a/src/domain/analysisView/apiContractView.ts +++ b/src/domain/analysisView/apiContractView.ts @@ -199,7 +199,7 @@ export const projectApiContractView = ( sha256: context.artifact.sha256, }, summary: context, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const selected = selectRows(parsed.value, view); return ok({ diff --git a/src/domain/analysisView/apkSignatureView.ts b/src/domain/analysisView/apkSignatureView.ts index 1d1a2cdf3d..b436cebeb7 100644 --- a/src/domain/analysisView/apkSignatureView.ts +++ b/src/domain/analysisView/apkSignatureView.ts @@ -305,7 +305,7 @@ export const projectApkSignatureView = ( view, ...shared, summary, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const ids = view.ids === undefined ? undefined : new Set(view.ids); const signers = diff --git a/src/domain/analysisView/artifactInventoryView.ts b/src/domain/analysisView/artifactInventoryView.ts index 069e618c10..8ac7991e6a 100644 --- a/src/domain/analysisView/artifactInventoryView.ts +++ b/src/domain/analysisView/artifactInventoryView.ts @@ -373,7 +373,7 @@ export const projectArtifactInventoryView = ( }, limitation_count: limitations.length, }, - coverage: completeWithinViewCoverage(examined, examined), + coverage: completeWithinViewCoverage(examined), ...shared, }); } diff --git a/src/domain/analysisView/batchDecompileView.ts b/src/domain/analysisView/batchDecompileView.ts index bf2e62cc31..90f744e0da 100644 --- a/src/domain/analysisView/batchDecompileView.ts +++ b/src/domain/analysisView/batchDecompileView.ts @@ -364,7 +364,7 @@ export const projectBatchDecompileView = ( ...summarizeBatch(batch.items), limitation_count: new Set(parent.limitations).size, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if (view.collection === "items") { const indices = selected(view.where.indices); diff --git a/src/domain/analysisView/binaryLayoutView.ts b/src/domain/analysisView/binaryLayoutView.ts index f3d38e7aec..a9f7cd7d7d 100644 --- a/src/domain/analysisView/binaryLayoutView.ts +++ b/src/domain/analysisView/binaryLayoutView.ts @@ -204,10 +204,6 @@ export const projectBinaryLayoutView = ( layout.segments.length + layout.symbols.length + layout.relocations.length, - layout.sections.length + - layout.segments.length + - layout.symbols.length + - layout.relocations.length, ), ...shared, }); @@ -218,7 +214,7 @@ export const projectBinaryLayoutView = ( kind: "facet" as const, view, facet: view.facet === "mitigations" ? layout.mitigations : layout.linkage, - coverage: completeCoverage(1, 1), + coverage: completeCoverage(1), ...shared, }); } @@ -239,12 +235,7 @@ export const projectBinaryLayoutView = ( kind: "item" as const, view, item: selected.value, - coverage: completeCoverage( - 1, - view.collection === "sections" - ? layout.sections.length - : layout.symbols.length, - ), + coverage: completeCoverage(1), ...shared, }); } diff --git a/src/domain/analysisView/browserScenarioView.ts b/src/domain/analysisView/browserScenarioView.ts index 14d0af84ab..9668c0434f 100644 --- a/src/domain/analysisView/browserScenarioView.ts +++ b/src/domain/analysisView/browserScenarioView.ts @@ -367,7 +367,7 @@ export const projectBrowserScenarioView = ( network: summarizeBrowserScenarioNetwork(capture), limitation_count: shared.limitations.length, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if ( view.collection === "text" && diff --git a/src/domain/analysisView/byteEntropyView.ts b/src/domain/analysisView/byteEntropyView.ts index ae04201a6e..c204ea46e6 100644 --- a/src/domain/analysisView/byteEntropyView.ts +++ b/src/domain/analysisView/byteEntropyView.ts @@ -55,10 +55,7 @@ export const projectByteEntropyView = ( .sort((a, b) => b.length - a.length || a.offset - b.offset) .slice(0, 10), }, - coverage: completeWithinViewCoverage( - report.blocks.length, - report.blocks.length, - ), + coverage: completeWithinViewCoverage(report.blocks.length), limitations: [ ...new Set([...parent.limitations, ...report.limitations]), ].sort(), diff --git a/src/domain/analysisView/commandObservationView.ts b/src/domain/analysisView/commandObservationView.ts index 19d5482d88..24d0ae1b7c 100644 --- a/src/domain/analysisView/commandObservationView.ts +++ b/src/domain/analysisView/commandObservationView.ts @@ -99,7 +99,7 @@ export const projectCommandObservationView = ( source_provider: parent.provider ?? null, source_analysis_profile_digest: parent.analysisProfile?.digest ?? null, source_parameters: parameters.data, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), limitations: boundedViewMessages( parent.limitations, parent.evidenceId, diff --git a/src/domain/analysisView/dartAotView.ts b/src/domain/analysisView/dartAotView.ts index d1c196bf24..00ddcd3b8a 100644 --- a/src/domain/analysisView/dartAotView.ts +++ b/src/domain/analysisView/dartAotView.ts @@ -97,7 +97,7 @@ export const projectDartAotView = ( view, ...shared, summary: { ...report, string_pool }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const collection = report.string_pool[view.collection]; const items = collection.slice(view.offset, view.offset + view.limit); diff --git a/src/domain/analysisView/desktopApplicationView.ts b/src/domain/analysisView/desktopApplicationView.ts index 3be4848187..038117f64f 100644 --- a/src/domain/analysisView/desktopApplicationView.ts +++ b/src/domain/analysisView/desktopApplicationView.ts @@ -293,10 +293,7 @@ export const projectDesktopApplicationView = ( components: report.components.map(summarizeBasis), next_probe_groups: [...groups.values()], }, - coverage: completeWithinViewCoverage( - report.files.length, - report.files.length, - ), + coverage: completeWithinViewCoverage(report.files.length), }); } let rows: readonly DesktopViewRow[] = report[view.collection]; diff --git a/src/domain/analysisView/devicetreeView.ts b/src/domain/analysisView/devicetreeView.ts index 54232e38f4..eb3a61614c 100644 --- a/src/domain/analysisView/devicetreeView.ts +++ b/src/domain/analysisView/devicetreeView.ts @@ -105,7 +105,7 @@ export const projectDevicetreeView = ( kind: "summary" as const, view, summary: { ...context, summary: r.summary }, - coverage: completeWithinViewCoverage(r.nodes.length, r.nodes.length), + coverage: completeWithinViewCoverage(r.nodes.length), }); if (view.collection === "properties" && view.path === undefined) return invalid("A properties page requires an exact node path."); diff --git a/src/domain/analysisView/endpointComparisonView.ts b/src/domain/analysisView/endpointComparisonView.ts index c2266ea365..4c57f074f6 100644 --- a/src/domain/analysisView/endpointComparisonView.ts +++ b/src/domain/analysisView/endpointComparisonView.ts @@ -218,7 +218,7 @@ export const projectEndpointComparisonView = ( kind: "summary" as const, view, summary: context, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const selected = selectComparisonRows(parsed.value, view); return ok({ diff --git a/src/domain/analysisView/erlangBeamView.ts b/src/domain/analysisView/erlangBeamView.ts index fe634f1bf0..885105ed32 100644 --- a/src/domain/analysisView/erlangBeamView.ts +++ b/src/domain/analysisView/erlangBeamView.ts @@ -217,7 +217,7 @@ export const projectErlangBeamView = ( kind: "summary" as const, view, summary, - coverage: completeWithinViewCoverage(chunks.length, chunks.length), + coverage: completeWithinViewCoverage(chunks.length), }); const rows = parsed.value[view.collection]; if (rows === null) diff --git a/src/domain/analysisView/evmInterfaceView.ts b/src/domain/analysisView/evmInterfaceView.ts index 9a5148aa0a..c6f8e3114c 100644 --- a/src/domain/analysisView/evmInterfaceView.ts +++ b/src/domain/analysisView/evmInterfaceView.ts @@ -112,10 +112,7 @@ export const projectEvmInterfaceView = ( diagnostics: { ...diagnostics, stdout_code_units: stdout.length }, limitations: report.limitations, }, - coverage: completeWithinViewCoverage( - report.functions.length, - report.functions.length, - ), + coverage: completeWithinViewCoverage(report.functions.length), }); } if (view.facet === "functions") { diff --git a/src/domain/analysisView/featureTraceView.ts b/src/domain/analysisView/featureTraceView.ts index 49b3d6a582..9319a1bdd2 100644 --- a/src/domain/analysisView/featureTraceView.ts +++ b/src/domain/analysisView/featureTraceView.ts @@ -343,7 +343,7 @@ export const projectFeatureTraceView = ( : { semantic_discovery: result.semantic_discovery }), limitation_count: new Set(limitations).size, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); return ok(tracePage(result, view, { ...shared, ...context })); }; diff --git a/src/domain/analysisView/fridaSessionStatusView.ts b/src/domain/analysisView/fridaSessionStatusView.ts index b2bf3989cb..878f30281b 100644 --- a/src/domain/analysisView/fridaSessionStatusView.ts +++ b/src/domain/analysisView/fridaSessionStatusView.ts @@ -70,7 +70,7 @@ export const projectFridaSessionStatusView = ( source_provider: parent.provider ?? null, source_parameters: parameters.data, summary: { ...status, messages_retained: messages.length }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), limitations: boundedViewMessages( [ ...parent.limitations, diff --git a/src/domain/analysisView/goBinaryView.ts b/src/domain/analysisView/goBinaryView.ts index 079ea1d91c..b8ceac0775 100644 --- a/src/domain/analysisView/goBinaryView.ts +++ b/src/domain/analysisView/goBinaryView.ts @@ -271,7 +271,7 @@ export const projectGoBinaryView = ( string_literals: stringSummary, }), }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); } const indices = diff --git a/src/domain/analysisView/gpuCodeObjectsView.ts b/src/domain/analysisView/gpuCodeObjectsView.ts index 828dfe2f8d..68a4ac265f 100644 --- a/src/domain/analysisView/gpuCodeObjectsView.ts +++ b/src/domain/analysisView/gpuCodeObjectsView.ts @@ -258,10 +258,7 @@ export const projectGpuCodeObjectsView = ( view, ...shared, summary: { ...summary, limitations: shared.limitations }, - coverage: completeWithinViewCoverage( - report.objects.length, - report.objects.length, - ), + coverage: completeWithinViewCoverage(report.objects.length), }); } if (view.collection === "ptx") { diff --git a/src/domain/analysisView/graphqlContractView.ts b/src/domain/analysisView/graphqlContractView.ts index e2f1e7d4a8..cb8edd193c 100644 --- a/src/domain/analysisView/graphqlContractView.ts +++ b/src/domain/analysisView/graphqlContractView.ts @@ -276,7 +276,7 @@ export const projectGraphqlContractView = ( sha256: context.artifact.sha256, }, summary: context, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const selected = selectRows(report, view); return ok({ diff --git a/src/domain/analysisView/il2cppMetadataView.ts b/src/domain/analysisView/il2cppMetadataView.ts index 1d89c1c26a..a2cbc157ef 100644 --- a/src/domain/analysisView/il2cppMetadataView.ts +++ b/src/domain/analysisView/il2cppMetadataView.ts @@ -665,7 +665,7 @@ export const projectIl2cppMetadataView = ( ...(binary === undefined ? {} : { binary }), counts, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); } const nativeUnavailable = diff --git a/src/domain/analysisView/interfaceBuilderView.ts b/src/domain/analysisView/interfaceBuilderView.ts index 2d5a32757f..c8016bb302 100644 --- a/src/domain/analysisView/interfaceBuilderView.ts +++ b/src/domain/analysisView/interfaceBuilderView.ts @@ -177,7 +177,7 @@ const summarizeInterfaceBuilder = ( truncated: graph.truncated, limitation_count: limitationCount, }), - coverage: completeWithinViewCoverage(total, total), + coverage: completeWithinViewCoverage(total), }; }; diff --git a/src/domain/analysisView/javascriptApplicationView.ts b/src/domain/analysisView/javascriptApplicationView.ts index c81904c833..5061ac333a 100644 --- a/src/domain/analysisView/javascriptApplicationView.ts +++ b/src/domain/analysisView/javascriptApplicationView.ts @@ -419,7 +419,7 @@ export const projectJavaScriptApplicationView = ( }), limitation_count: limitationCount, }, - coverage: completeCoverage(moduleCount, moduleCount), + coverage: completeCoverage(moduleCount), ...shared, }); } @@ -437,7 +437,7 @@ export const projectJavaScriptApplicationView = ( kind: "item" as const, view, item: moduleItem(selected.value.node, selected.value.path), - coverage: completeCoverage(1, modules.length), + coverage: completeCoverage(1), ...shared, }); } diff --git a/src/domain/analysisView/javascriptRoutesView.ts b/src/domain/analysisView/javascriptRoutesView.ts index f28569c133..d08f0e7a6e 100644 --- a/src/domain/analysisView/javascriptRoutesView.ts +++ b/src/domain/analysisView/javascriptRoutesView.ts @@ -425,10 +425,7 @@ export const projectJavaScriptRoutesView = ( }, }, byte_limited: false, - coverage: completeWithinViewCoverage( - inventory.routes.length, - inventory.routes.length, - ), + coverage: completeWithinViewCoverage(inventory.routes.length), }; return jsonValueByteLength(summary, PROJECTION_BYTES) > PROJECTION_BYTES ? tooLarge() diff --git a/src/domain/analysisView/machoView.ts b/src/domain/analysisView/machoView.ts index 51194934e6..d130040a97 100644 --- a/src/domain/analysisView/machoView.ts +++ b/src/domain/analysisView/machoView.ts @@ -210,7 +210,7 @@ export const projectMachoView = ( ...shared, limitations, summary, - coverage: completeWithinViewCoverage(returned, returned), + coverage: completeWithinViewCoverage(returned), }); } const source = diff --git a/src/domain/analysisView/managedArtifactView.ts b/src/domain/analysisView/managedArtifactView.ts index 5dcb92b1d5..cdcfc4b93a 100644 --- a/src/domain/analysisView/managedArtifactView.ts +++ b/src/domain/analysisView/managedArtifactView.ts @@ -123,7 +123,7 @@ export const projectManagedArtifactView = ( view, ...shared, summary: { ...summary, reported_counts, identity_scope }, - coverage: completeWithinViewCoverage(total, total), + coverage: completeWithinViewCoverage(total), }); } const collection = report[view.collection]; diff --git a/src/domain/analysisView/managedMemberView.ts b/src/domain/analysisView/managedMemberView.ts index b6f9acb821..729570ca4e 100644 --- a/src/domain/analysisView/managedMemberView.ts +++ b/src/domain/analysisView/managedMemberView.ts @@ -342,7 +342,7 @@ export const projectManagedMemberView = ( view, ...shared, summary, - coverage: completeWithinViewCoverage(total, total), + coverage: completeWithinViewCoverage(total), }); } const selected = collectionPage(report, view); diff --git a/src/domain/analysisView/modelArtifactView.ts b/src/domain/analysisView/modelArtifactView.ts index 86ffa7b21a..bc90767d09 100644 --- a/src/domain/analysisView/modelArtifactView.ts +++ b/src/domain/analysisView/modelArtifactView.ts @@ -243,7 +243,7 @@ export const projectModelArtifactView = ( "limitations", ), }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const rows = view.collection === "tensors" diff --git a/src/domain/analysisView/nativeExportsView.ts b/src/domain/analysisView/nativeExportsView.ts index fce8e42268..6296db953c 100644 --- a/src/domain/analysisView/nativeExportsView.ts +++ b/src/domain/analysisView/nativeExportsView.ts @@ -126,7 +126,7 @@ export const projectNativeExportsView = ( kind: "summary" as const, view, summary, - coverage: completeWithinViewCoverage(exports.length, exports.length), + coverage: completeWithinViewCoverage(exports.length), }); const indices = view.indices === undefined ? undefined : new Set(view.indices); diff --git a/src/domain/analysisView/nativeFeatureTraceView.ts b/src/domain/analysisView/nativeFeatureTraceView.ts index edabccf2d7..8e1bca81bd 100644 --- a/src/domain/analysisView/nativeFeatureTraceView.ts +++ b/src/domain/analysisView/nativeFeatureTraceView.ts @@ -146,9 +146,6 @@ export const projectNativeFeatureTraceView = ( trace.matches.length + trace.references.length + trace.residual_unknowns.length, - trace.matches.length + - trace.references.length + - trace.residual_unknowns.length, ), }); const select = ( diff --git a/src/domain/analysisView/nativeFunctionMatchingView.ts b/src/domain/analysisView/nativeFunctionMatchingView.ts index 0d8bf4a92f..e35a13cb68 100644 --- a/src/domain/analysisView/nativeFunctionMatchingView.ts +++ b/src/domain/analysisView/nativeFunctionMatchingView.ts @@ -314,7 +314,7 @@ export const projectNativeFunctionMatchingView = ( view, ...shared, summary: context, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if (view.collection === "byte-sources") { if (entry.report.byte_sources === undefined) diff --git a/src/domain/analysisView/nativeFunctionView.ts b/src/domain/analysisView/nativeFunctionView.ts index 8ce34ee53f..31e8fc64bb 100644 --- a/src/domain/analysisView/nativeFunctionView.ts +++ b/src/domain/analysisView/nativeFunctionView.ts @@ -205,7 +205,7 @@ const summaryView = ( kind: "summary" as const, view, summary: summarizeDossier(dossier), - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), ...common, unknowns: uniqueSorted([ ...common.unknowns, @@ -250,7 +250,7 @@ export const projectNativeFunctionView = ( kind: "native" as const, view, item: jsonValueSchema.parse(item), - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), ...common, }); if (availability?.available === false) return ok(singleton(availability)); diff --git a/src/domain/analysisView/nativeInventoryView.ts b/src/domain/analysisView/nativeInventoryView.ts index 058946ea23..e643daa120 100644 --- a/src/domain/analysisView/nativeInventoryView.ts +++ b/src/domain/analysisView/nativeInventoryView.ts @@ -140,7 +140,7 @@ export const projectNativeInventoryView = ( discovery_coverage: "unknown" as const, selectable_fields: fieldSchema.options, }, - coverage: completeWithinViewCoverage(rows.length, rows.length), + coverage: completeWithinViewCoverage(rows.length), }); // Normalize the selection once: repeated caller fields must not multiply // work or temporary entries for every retained row. Keep the original view. diff --git a/src/domain/analysisView/nativeLoadImageView.ts b/src/domain/analysisView/nativeLoadImageView.ts index cfa808c302..09f3cc2ab0 100644 --- a/src/domain/analysisView/nativeLoadImageView.ts +++ b/src/domain/analysisView/nativeLoadImageView.ts @@ -278,7 +278,7 @@ export const projectNativeLoadImageView = ( sections: "sections" in report ? report.sections.length : null, }, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const selected = diff --git a/src/domain/analysisView/nativeProcedureReferencesView.ts b/src/domain/analysisView/nativeProcedureReferencesView.ts index 9b0a77d6bc..9a77438901 100644 --- a/src/domain/analysisView/nativeProcedureReferencesView.ts +++ b/src/domain/analysisView/nativeProcedureReferencesView.ts @@ -168,7 +168,7 @@ export const projectNativeProcedureReferencesView = ( kind: "summary" as const, view, summary, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }; return jsonValueByteLength(result as JsonValue, PAGE_BYTES - DIGEST_BYTES) > PAGE_BYTES - DIGEST_BYTES diff --git a/src/domain/analysisView/nativeValueTraceView.ts b/src/domain/analysisView/nativeValueTraceView.ts index a26215a5cc..c3234dccfb 100644 --- a/src/domain/analysisView/nativeValueTraceView.ts +++ b/src/domain/analysisView/nativeValueTraceView.ts @@ -77,7 +77,7 @@ export const projectNativeValueTraceView = ( truncated: trace.truncated, limitation_count: trace.limitations.length, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), limitations: boundedViewMessages( [...parent.limitations, ...trace.limitations], parent.evidenceId, diff --git a/src/domain/analysisView/pcapCaptureView.ts b/src/domain/analysisView/pcapCaptureView.ts index d42268dd70..0bfd0e17ac 100644 --- a/src/domain/analysisView/pcapCaptureView.ts +++ b/src/domain/analysisView/pcapCaptureView.ts @@ -293,7 +293,7 @@ export const projectPcapCaptureView = ( view, ...shared, summary: summarize(capture), - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if (view.facet === "diagnostics") { const value = diff --git a/src/domain/analysisView/playwrightTraceView.ts b/src/domain/analysisView/playwrightTraceView.ts index b762c717c8..881a87454a 100644 --- a/src/domain/analysisView/playwrightTraceView.ts +++ b/src/domain/analysisView/playwrightTraceView.ts @@ -321,7 +321,7 @@ export const projectPlaywrightTraceView = ( sha256: context.artifact.sha256, }, summary: context, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if (view.collection === "event-text") { const text = selectEventText(parsed.value, view); diff --git a/src/domain/analysisView/procedurePseudocodeView.ts b/src/domain/analysisView/procedurePseudocodeView.ts index e1f0f6b84d..cac1294229 100644 --- a/src/domain/analysisView/procedurePseudocodeView.ts +++ b/src/domain/analysisView/procedurePseudocodeView.ts @@ -103,7 +103,7 @@ export const projectProcedurePseudocodeView = ( unit: "utf16-code-units" as const, }, }, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if (text === null) return ok({ @@ -112,7 +112,7 @@ export const projectProcedurePseudocodeView = ( ...common, procedure_address: null, item: unavailable, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const page = analysisTextPage(text, view.offset, view.limit); return page.ok diff --git a/src/domain/analysisView/pythonPycView.ts b/src/domain/analysisView/pythonPycView.ts index 5b21fc73b1..f59979b86e 100644 --- a/src/domain/analysisView/pythonPycView.ts +++ b/src/domain/analysisView/pythonPycView.ts @@ -98,10 +98,7 @@ export const projectPythonPycView = ( kind: "summary" as const, view, summary, - coverage: completeWithinViewCoverage( - code_objects.length, - code_objects.length, - ), + coverage: completeWithinViewCoverage(code_objects.length), }); const names = view.names === undefined ? undefined : new Set(view.names); const indices = diff --git a/src/domain/analysisView/rustBinaryView.ts b/src/domain/analysisView/rustBinaryView.ts index 2781196b0e..78550b5257 100644 --- a/src/domain/analysisView/rustBinaryView.ts +++ b/src/domain/analysisView/rustBinaryView.ts @@ -189,7 +189,7 @@ export const projectRustBinaryView = ( view, ...shared, summary, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); if (metadata === null) return ok({ diff --git a/src/domain/analysisView/sourceToBundleView.ts b/src/domain/analysisView/sourceToBundleView.ts index cc13919dc1..66a557bccd 100644 --- a/src/domain/analysisView/sourceToBundleView.ts +++ b/src/domain/analysisView/sourceToBundleView.ts @@ -162,7 +162,7 @@ export const projectSourceToBundleView = ( view, ...shared, summary: context, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }); const paths = selected(view.source_paths), ids = selected(view.mapping_ids), diff --git a/src/domain/analysisView/wasmArtifactView.ts b/src/domain/analysisView/wasmArtifactView.ts index 4d16729658..e6939d305b 100644 --- a/src/domain/analysisView/wasmArtifactView.ts +++ b/src/domain/analysisView/wasmArtifactView.ts @@ -161,7 +161,6 @@ export const projectWasmArtifactView = ( }, coverage: completeWithinViewCoverage( report.sections.length + report.imports.length + report.exports.length, - report.sections.length + report.imports.length + report.exports.length, ), }); if (view.facet === "tool_profile") { @@ -179,7 +178,7 @@ export const projectWasmArtifactView = ( kind: "wasm" as const, view, item: report.tool_profile, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), ...shared, }); } diff --git a/src/domain/analysisView/webBundleView.ts b/src/domain/analysisView/webBundleView.ts index fb12384f73..ef07dbe45d 100644 --- a/src/domain/analysisView/webBundleView.ts +++ b/src/domain/analysisView/webBundleView.ts @@ -221,7 +221,7 @@ export const projectWebBundleView = ( view: selected, ...shared, summary, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }; return jsonValueByteLength( result as unknown as JsonValue, @@ -242,7 +242,7 @@ export const projectWebBundleView = ( items: [], summary, byte_limited: false, - coverage: completeWithinViewCoverage(1, 1), + coverage: completeWithinViewCoverage(1), }; return jsonValueByteLength( result as unknown as JsonValue, diff --git a/src/domain/analysisView/webNetworkCaptureView.ts b/src/domain/analysisView/webNetworkCaptureView.ts index b5d4e948a2..cc1f4e4334 100644 --- a/src/domain/analysisView/webNetworkCaptureView.ts +++ b/src/domain/analysisView/webNetworkCaptureView.ts @@ -564,10 +564,7 @@ export const projectWebNetworkCaptureView = ( ? { qlog: summarizeQlogCapture(report.qlog) } : {}), }, - coverage: completeWithinViewCoverage( - report.records.length, - report.records.length, - ), + coverage: completeWithinViewCoverage(report.records.length), }); if (view.kind === "qlog") { if (report.format !== "qlog")