From 528c46ae92d0935ecaad7b74869368ea446cd5a1 Mon Sep 17 00:00:00 2001
From: N0zoM1z0 <161784452+N0zoM1z0@users.noreply.github.com>
Date: Wed, 11 Nov 2026 09:09:08 +0000
Subject: [PATCH] test(pe): verify target refusal through CLI and stdio MCP

Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
---
 .../applications/peUnsupportedTargets.test.ts | 55 ++++++++++++++++---
 1 file changed, 46 insertions(+), 9 deletions(-)

diff --git a/tests/acceptance/applications/peUnsupportedTargets.test.ts b/tests/acceptance/applications/peUnsupportedTargets.test.ts
index 658a334b5b..966378e557 100644
--- a/tests/acceptance/applications/peUnsupportedTargets.test.ts
+++ b/tests/acceptance/applications/peUnsupportedTargets.test.ts
@@ -1,18 +1,46 @@
 import { readFile, writeFile } from "node:fs/promises";
 import { join } from "node:path";
 import { expect } from "vitest";
-import { dosMz } from "../../../src/domain/binaryTarget.fixture.js";
+import {
+  dosMz,
+  nonPeWindowsMz,
+} from "../../../src/domain/binaryTarget.fixture.js";
 import { connectLocalToolsMcp } from "../../fixtures/localToolsMcp.js";
 import { parseMcpToolError } from "../../fixtures/mcpToolError.js";
 import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
 import { cliTest } from "../../support/cli/cliFixture.js";
 
-cliTest.for(["CLI", "stdio MCP"] as const)(
-  "reports DOS as unsupported for PE resources and certificates through %s",
-  async (surface, { cli }) => {
+const cases = (
+  ["DOS", "NE", "LE", "LX", "unknown", "truncated PE", "truncated MZ"] as const
+).flatMap((format) =>
+  (["CLI", "stdio MCP"] as const).map((surface) => ({ format, surface })),
+);
+
+cliTest.for(cases)(
+  "classifies $format for PE resources and certificates through $surface",
+  async ({ format, surface }, { cli }) => {
     const root = await createTestTempDirectory("rea-pe-dos-public-");
-    const path = join(root, "dos.exe");
-    const bytes = dosMz(1024);
+    const path = join(root, "program.exe");
+    let bytes =
+      format === "DOS"
+        ? dosMz(1024)
+        : nonPeWindowsMz(
+            format === "NE" || format === "LE" || format === "LX"
+              ? format
+              : "NE",
+          );
+    const malformed =
+      format === "unknown" ||
+      format === "truncated PE" ||
+      format === "truncated MZ";
+    if (format === "truncated MZ") bytes = Buffer.from("MZ");
+    if (format === "unknown") bytes.write("ZZ", 128, "ascii");
+    if (format === "truncated PE") {
+      bytes.write("PE\0\0", 128, "binary");
+      bytes = bytes.subarray(0, 132);
+    }
+    // A recognized two-byte signature needs no PE COFF header to refuse it.
+    if (format === "LE") bytes = bytes.subarray(0, 130);
     await writeFile(path, bytes);
     const mcp =
       surface === "stdio MCP" ? await connectLocalToolsMcp() : undefined;
@@ -30,10 +58,19 @@ cliTest.for(["CLI", "stdio MCP"] as const)(
         error = parseMcpToolError(response).error;
       }
       expect(error).toMatchObject({
-        code: "unsupported_target",
-        category: "unsupported_target",
+        code: malformed ? "invalid_request" : "unsupported_target",
+        category: malformed ? "invalid_input" : "unsupported_target",
+        retryable: false,
+        details: { operation: `inspect_pe_${operation}` },
       });
-      expect(JSON.stringify(error)).not.toContain("inspect_input_contract");
+      if (malformed) {
+        expect(error).toMatchObject({
+          details: { issues: [{ path: ["path"], reason: "invalid_format" }] },
+        });
+      } else {
+        expect(error).toMatchObject({ details: { path } });
+        expect(JSON.stringify(error)).not.toContain("inspect_input_contract");
+      }
       expect(Buffer.compare(await readFile(path), bytes)).toBe(0);
     }
   },