From 583bb477c16eefefbefb0c7ee2144096aca61b29 Mon Sep 17 00:00:00 2001 From: gensokyo-dev Date: Sat, 14 Nov 2026 10:41:41 +0000 Subject: [PATCH] test(inspector): keep the sibling Node discovery fixtures out of underscored roots Use createNodeDiscoveryTempDirectory for the target-location and runtime-observation fixtures too, so a TMPDIR containing `_` cannot make them fail for the same reason as the cancellation test. Refs #9996 The sibling sites are the ones #4484 switched. Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com> --- .../boundary/inspector/javascriptRuntimeObservation.test.ts | 6 +++--- .../inspector/javascriptRuntimeTargetLocations.test.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/boundary/inspector/javascriptRuntimeObservation.test.ts b/tests/boundary/inspector/javascriptRuntimeObservation.test.ts index d3629eeb6c..e3dc06e97c 100644 --- a/tests/boundary/inspector/javascriptRuntimeObservation.test.ts +++ b/tests/boundary/inspector/javascriptRuntimeObservation.test.ts @@ -30,7 +30,7 @@ import { javascriptRuntimeReconciliationResultSchema } from "../../../src/domain import { parseRuntimeCapture } from "../../../src/domain/javascript/javascriptRuntimeReconciliationCaptureParsing.js"; import { startFakeV8Inspector } from "../../fixtures/inspector/fakeV8Inspector.js"; import { startFakeCdpBrowser } from "../../fixtures/fakeCdpBrowser.js"; -import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js"; +import { createNodeDiscoveryTempDirectory } from "../../fixtures/temporaryDirectory.js"; test("reports static-layer Evidence digest failure at its caller path", () => { const layer = JAVASCRIPT_RUNTIME_RECONCILIATION_EXAMPLE.static_layers[0]; @@ -961,14 +961,14 @@ test("keeps malformed scriptFailedToParse protocol values in the invalid count", }); const runtimeFixture = async () => { - const root = await createTestTempDirectory("rea-v8-runtime-"); + const root = await createNodeDiscoveryTempDirectory("rea-v8-runtime-"); const entry = join(root, "entry.js"); await writeFile(entry, "export const value = 1;\n"); return { root, entry }; }; const temporaryFile = async (name: string): Promise => { - const root = await createTestTempDirectory("rea-v8-outside-"); + const root = await createNodeDiscoveryTempDirectory("rea-v8-outside-"); const path = join(root, name); await writeFile(path, "export {};\n"); return path; diff --git a/tests/boundary/inspector/javascriptRuntimeTargetLocations.test.ts b/tests/boundary/inspector/javascriptRuntimeTargetLocations.test.ts index b5b8a9877a..91d9ee5993 100644 --- a/tests/boundary/inspector/javascriptRuntimeTargetLocations.test.ts +++ b/tests/boundary/inspector/javascriptRuntimeTargetLocations.test.ts @@ -6,10 +6,10 @@ import { expect, test } from "vitest"; import { V8InspectorProvider } from "../../../src/inspector/V8InspectorProvider.js"; import { startFakeV8Inspector } from "../../fixtures/inspector/fakeV8Inspector.js"; -import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js"; +import { createNodeDiscoveryTempDirectory } from "../../fixtures/temporaryDirectory.js"; async function entryFile(name: string): Promise { - const root = await createTestTempDirectory("rea-node-discovery-"); + const root = await createNodeDiscoveryTempDirectory("rea-node-discovery-"); const entry = join(root, name); await writeFile(entry, "setInterval(() => {}, 1000);\n"); return entry;