From 66d55c3bbb3fd7e839ec4af83a6f9a1cce14f247 Mon Sep 17 00:00:00 2001 From: highmachs Date: Thu, 5 Nov 2026 13:06:51 +0530 Subject: [PATCH] fix(native): declare temporary filesystem writes for inspect_macho (#8959) --- src/contracts/toolEffects.test.ts | 8 ++++++++ src/contracts/toolEffects.ts | 2 +- src/native/NativeMacOSProviderInput.test.ts | 8 ++++++++ src/native/NativeMacOSProviderMetadata.ts | 3 ++- 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/contracts/toolEffects.test.ts b/src/contracts/toolEffects.test.ts index 97493cf518..e0f43fc3bf 100644 --- a/src/contracts/toolEffects.test.ts +++ b/src/contracts/toolEffects.test.ts @@ -263,3 +263,11 @@ it("advertises signature inspection's temporary snapshot filesystem writes", () launchesProcess: true, }); }); + +it("advertises inspect_macho's temporary private operand filesystem writes", () => { + expect(TOOL_EFFECTS.inspect_macho).toMatchObject({ + writesFilesystem: true, + mutatesTarget: false, + launchesProcess: true, + }); +}); diff --git a/src/contracts/toolEffects.ts b/src/contracts/toolEffects.ts index c32fd18154..40852d4a24 100644 --- a/src/contracts/toolEffects.ts +++ b/src/contracts/toolEffects.ts @@ -614,7 +614,7 @@ export const TOOL_EFFECTS: Readonly> = { executesForeignCode: true, idempotent: false, }), - inspect_macho: nativeEvidence, + inspect_macho: { ...nativeEvidence, writesFilesystem: true }, inspect_signature: { ...nativeEvidence, writesFilesystem: true }, inspect_plist: nativeEvidence, list_architectures: nativeEvidence, diff --git a/src/native/NativeMacOSProviderInput.test.ts b/src/native/NativeMacOSProviderInput.test.ts index e588f5c12d..b7796afbaf 100644 --- a/src/native/NativeMacOSProviderInput.test.ts +++ b/src/native/NativeMacOSProviderInput.test.ts @@ -162,3 +162,11 @@ it("declares the signature snapshot write in provider capabilities", () => { )?.effects, ).toMatchObject({ mayWriteFilesystem: true, mutatesArtifact: false }); }); + +it("declares the temporary private operand write in inspect_macho provider capabilities", () => { + expect( + nativeMacOSCapabilities("darwin").find( + ({ operation }) => operation === "inspect_macho", + )?.effects, + ).toMatchObject({ mayWriteFilesystem: true, mutatesArtifact: false }); +}); diff --git a/src/native/NativeMacOSProviderMetadata.ts b/src/native/NativeMacOSProviderMetadata.ts index f9a13c7447..931d1ca5b6 100644 --- a/src/native/NativeMacOSProviderMetadata.ts +++ b/src/native/NativeMacOSProviderMetadata.ts @@ -58,7 +58,8 @@ export const nativeMacOSCapabilities = ( mayWriteFilesystem: OWNED_PROCESS_OPERATIONS.has(contract.name) || contract.name === "observe_native_ui" || - contract.name === "inspect_signature", + contract.name === "inspect_signature" || + contract.name === "inspect_macho", changesPermissions: false, requiresRoot: false, }),