mirror of
https://github.com/morluto/rea.git
synced 2026-11-18 20:53:00 +00:00
fix(javascript): stop recording replaced slot values as store receivers (#7128)
Reference-store identity queries resolved the written target as a value, so once a step consumed the written key the walk continued into the value read from that slot and recorded it, and everything reachable from it, as an object the store mutates. Every value stored into one local object at unknown keys then received an entry for every such store, and each new store re-queued every earlier one. Ambient-write indexing grew cubically in the number of such stores. Receiver queries now drop items whose projection no longer ends at the written key. Stored-value selection has one owner, which the resolver and the store fixpoint share. The fixpoint re-queues a dependent only when a changed entry can reach it with a selection that its receiver query keeps. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
5a22ae6bc8
commit
70b96b65d9
2 files changed
+189
-49
No files matched your search
@@ -1,3 +1,4 @@
|
||||
import * as t from "@babel/types";
|
||||
import { expect, it } from "vitest";
|
||||
|
||||
import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
|
||||
@@ -128,3 +129,114 @@ box.trigger;`;
|
||||
).toEqual(["box.trigger", "box.trigger"]);
|
||||
expect(effects[0]?.node).not.toBe(effects[1]?.node);
|
||||
});
|
||||
|
||||
const globalFetchWriteSites = (body: string): string[] => {
|
||||
const source = `var t={},k=[];${body}`;
|
||||
const parsed = parseJavaScriptSource(source);
|
||||
if (parsed === null) throw new Error("Expected stored-slot fixture");
|
||||
const state = completeSemanticSteps(
|
||||
indexJavaScriptBindingsSteps(parsed.program),
|
||||
);
|
||||
return state.ambientWriteEffects
|
||||
.filter(
|
||||
({ path }) =>
|
||||
JSON.stringify(path) === JSON.stringify(["global", "fetch"]),
|
||||
)
|
||||
.map(({ node }) =>
|
||||
node === undefined ? "" : source.slice(node.start ?? 0, node.end ?? 0),
|
||||
);
|
||||
};
|
||||
|
||||
it.each([
|
||||
{
|
||||
name: "an object read from a replaced slot",
|
||||
body: "var g={};t[k[0]]=g;t[k[1]]=window;g.fetch=replacement;",
|
||||
sites: [],
|
||||
},
|
||||
{
|
||||
name: "a literal property value whose slot is replaced",
|
||||
body: "var o={};var h={p:o};h.p=window;o.fetch=replacement;h.p.fetch=other;",
|
||||
sites: ["h.p.fetch=other"],
|
||||
},
|
||||
{
|
||||
name: "a global read back through an unknown slot",
|
||||
body: "t[k[0]]=window;t[k[1]].fetch=replacement;",
|
||||
sites: ["t[k[1]].fetch=replacement"],
|
||||
},
|
||||
{
|
||||
name: "a global read into an alias of an unknown slot",
|
||||
body: "t[k[0]]=window;var r=t[k[1]];r.fetch=replacement;",
|
||||
sites: ["r.fetch=replacement"],
|
||||
},
|
||||
{
|
||||
name: "a nested store through an unknown slot",
|
||||
body: "t[k[0]]={};t[k[1]].x=window;t[k[2]].x.fetch=replacement;",
|
||||
sites: ["t[k[2]].x.fetch=replacement"],
|
||||
},
|
||||
{
|
||||
name: "a store through an instance prototype",
|
||||
body: "function F(){}var x=new F();x.__proto__.slot=window;F.prototype.slot.fetch=replacement;",
|
||||
sites: ["F.prototype.slot.fetch=replacement"],
|
||||
},
|
||||
{
|
||||
name: "a store through an instance constructor",
|
||||
body: "function F(){}var x=new F();x.constructor.slot=window;F.slot.fetch=replacement;",
|
||||
sites: ["F.slot.fetch=replacement"],
|
||||
},
|
||||
{
|
||||
name: "a store into a rest copy",
|
||||
body: "var src={};var {...copy}=src;copy.slot=window;copy.slot.fetch=replacement;",
|
||||
sites: ["copy.slot.fetch=replacement"],
|
||||
},
|
||||
])("resolves stored references for $name", ({ body, sites }) => {
|
||||
expect(globalFetchWriteSites(body)).toEqual(sites);
|
||||
});
|
||||
|
||||
it("keeps an object read from a replaced slot as a URL base proof", () => {
|
||||
const worker =
|
||||
analyzeJavaScriptStaticSource(`import { Worker } from "node:worker_threads";
|
||||
const t={},k=[];const g={};t[k[0]]=g;t[k[1]]=globalThis;g.URL=replacement;
|
||||
new Worker(new URL("./worker.js", import.meta.url));`).references.find(
|
||||
(reference) => reference.kind === "worker",
|
||||
);
|
||||
expect(worker?.specifier).toBe("./worker.js");
|
||||
});
|
||||
|
||||
it("indexes unknown-key stores of fresh objects in linear stored-value work", () => {
|
||||
// Count reads of the stored values' own syntax during ambient indexing only.
|
||||
const work = (count: number): number => {
|
||||
const source = `var t={},k=[];${Array.from({ length: count }, (_, i) => `t[k[${String(i)}]]={v:${String(i)}};`).join("")}`;
|
||||
const parsed = parseJavaScriptSource(source);
|
||||
if (parsed === null) throw new Error("Expected stored-object fixture");
|
||||
const index = completeSemanticSteps(
|
||||
indexJavaScriptBindingsWithReceiversSteps(parsed.program),
|
||||
);
|
||||
let counting = false;
|
||||
let reads = 0;
|
||||
for (const statement of parsed.program.body) {
|
||||
if (
|
||||
!t.isExpressionStatement(statement) ||
|
||||
!t.isAssignmentExpression(statement.expression)
|
||||
)
|
||||
continue;
|
||||
const value = statement.expression.right;
|
||||
const type = value.type;
|
||||
Object.defineProperty(value, "type", {
|
||||
enumerable: true,
|
||||
configurable: true,
|
||||
get: () => {
|
||||
if (counting) reads += 1;
|
||||
return type;
|
||||
},
|
||||
});
|
||||
}
|
||||
counting = true;
|
||||
completeSemanticSteps(index.indexAmbientWritesSteps());
|
||||
counting = false;
|
||||
expect(index.bindings.ambientWriteEffects).toEqual([]);
|
||||
return reads;
|
||||
};
|
||||
// Each stored value is examined a bounded number of times. Re-reading every
|
||||
// earlier value from every later store grows at least quadratically.
|
||||
expect(work(64)).toBeLessThan(3 * work(32));
|
||||
});
|
||||
Reference in new issue
Block a user