test: assert structured recovery facts instead of recovery wording in src tests (#12721)

* test: assert structured recovery facts instead of recovery wording in src tests

Replace recovery-sentence locks with the structured fields that already
carry those facts, and own Batch 4 temporary directories through
createTestTempDirectory.

* test(hopper): keep recovery order that retry_action does not carry

retry_action names restart or unknown. It does not say to read
provider_operation_health before retrying, or to close_binary before
opening and retrying. Those order checks stay.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
This commit is contained in:
authored and GitHub committed 2026-11-19 23:05:20 -05:00
1 parent dc2c31e76d
commit 74bdfd2ec2
19 files changed
+238 -273

No files matched your search

@@ -1,15 +1,7 @@
import {
lstat,
mkdir,
mkdtemp,
open,
readdir,
rm,
writeFile,
} from "node:fs/promises";
import { lstat, mkdir, open, readdir, writeFile } from "node:fs/promises";
import { classifyProviderFailure } from "../providers/classifyProviderFailure.js";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { createTestTempDirectory } from "../../tests/fixtures/temporaryDirectory.js";
import { expect, it } from "vitest";
@@ -25,7 +17,7 @@ import { SQLITE_DATABASE_LIMITS } from "./SqliteDatabaseLimits.js";
import { sqliteDatabaseDialect } from "./SqliteDatabaseFailures.js";
it("tags an exact caller reason at snapshot admission", async () => {
const workspace = await mkdtemp(join(tmpdir(), "rea-sqlite-snapshot-entry-"));
const workspace = await createTestTempDirectory("rea-sqlite-snapshot-entry-");
const reason = { requested: "cancel at snapshot admission" };
const controller = new AbortController();
controller.abort(reason);
@@ -60,13 +52,12 @@ it("tags an exact caller reason at snapshot admission", async () => {
expect(projected.cause).toBe(reason);
} finally {
await resourceScope.close();
await rm(workspace, { force: true, recursive: true });
}
});
it("keeps the exact caller reason when cancellation lands at final snapshot verification", async () => {
const workspace = await mkdtemp(
join(tmpdir(), "rea-sqlite-snapshot-cancel-"),
const workspace = await createTestTempDirectory(
"rea-sqlite-snapshot-cancel-",
);
const databasePath = join(workspace, "selected.db");
const privateRoot = join(workspace, "private");
@@ -111,14 +102,13 @@ it("keeps the exact caller reason when cancellation lands at final snapshot veri
expect(projected.cause).toBe(reason);
} finally {
await resourceScope.close();
await rm(workspace, { force: true, recursive: true });
}
});
it("reports filesystem sizes above the safe-integer range exactly before opening files", async () => {
const databaseBytes = BigInt(Number.MAX_SAFE_INTEGER) + 1n;
const walBytes = 17n;
const workspace = await mkdtemp(join(tmpdir(), "rea-sqlite-budget-"));
const workspace = await createTestTempDirectory("rea-sqlite-budget-");
const databasePath = join(workspace, "selected.db");
const walPath = `${databasePath}-wal`;
const journalPath = `${databasePath}-journal`;
@@ -202,7 +192,6 @@ it("reports filesystem sizes above the safe-integer range exactly before opening
});
} finally {
await resourceScope.close();
await rm(workspace, { force: true, recursive: true });
}
});
@@ -212,7 +201,7 @@ it.each([
])(
"preserves $label when a late read-limit failure becomes changed evidence",
async ({ retainCleanup }) => {
const workspace = await mkdtemp(join(tmpdir(), "rea-sqlite-read-cleanup-"));
const workspace = await createTestTempDirectory("rea-sqlite-read-cleanup-");
const databasePath = join(workspace, "selected.db");
await writeFile(databasePath, "tiny fixture");
const stat = await lstat(databasePath, { bigint: true });
@@ -291,7 +280,6 @@ it.each([
}
} finally {
await resourceScope.close();
await rm(workspace, { force: true, recursive: true });
}
},
);