mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 11:43:20 +00:00
fix(javascript): keep both-direction feature traces from crossing shared containers (#7743)
* fix(javascript): keep both-direction feature traces from crossing shared containers trace_application_feature with direction "both" walked the application graph as if it were undirected. From a seed, one outgoing or incoming step into a shared container (an asset or the artifact root) followed by steps in the other direction reached every sibling of that container, so a trace seeded on one storage key returned the whole connected graph. "both" now returns the union of the outgoing and incoming closures. Each walk keeps its own predecessor chains, so a terminal path never changes direction midway. "outgoing" and "incoming" are unchanged. * test(javascript): check both-direction trace paths end to end The existing tests checked predecessor maps but no returned path. Add a trace whose seed reaches one storage terminal outgoing and another incoming, and assert each path's complete node_ids and edge_ids. A pathTo that reads only the first walk's map returns a one-node path for the incoming terminal and fails this test. * fix(javascript): confine only ascended containers in both-direction traces Making "both" the union of separate outgoing and incoming walks dropped modules that a feature reaches by crossing directions. In the Notes known-answer evaluation, the notes:export channel is pointed at by both the preload asset (invokes) and the handler (handles); its preload, renderer and csv modules are reached only through relationships that change direction, so the trace kept main.js alone and the feature_modules claim failed in tests/boundary/mcp/agentKnownAnswerMcp.test.ts. Walk both directions in one traversal again, and confine only the containment case the change was meant to stop: a node reached by stepping up a contains edge from one of its children follows only further contains steps up. A shared asset or artifact root then no longer leads into its other children, while relationships across the feature are kept. The Notes trace returns csv.js, main.js, preload.js and renderer.js again (30 nodes; the previous main returned the whole 32-node graph). outgoing and incoming traces are unchanged, and paths come from one predecessor map again, as before this branch.
This commit is contained in:
1 parent
8b74f30bf9
commit
7c389cbefc
3 files changed
+277
-8
No files matched your search
@@ -8,6 +8,8 @@ import { compareUnicodeCodePoints } from "../unicodeCodePointOrder.js";
|
||||
interface AdjacencyEntry {
|
||||
readonly edge: ApplicationEdge;
|
||||
readonly nextNodeId: string;
|
||||
/** In "both", the step goes from a contained node up to its container. */
|
||||
readonly ascends: boolean;
|
||||
}
|
||||
|
||||
interface Predecessor {
|
||||
@@ -33,20 +35,36 @@ export const traverseApplicationFeature = (
|
||||
const visited = new Set(seedNodeIds);
|
||||
const retainedEdges = new Map<string, ApplicationEdge>();
|
||||
const predecessors = new Map<string, Predecessor>();
|
||||
// A feature crosses relationships in both directions: a renderer invokes a
|
||||
// channel that its handler also points at. A container reached from one of
|
||||
// its children only leads further up; expanding it would return every
|
||||
// sibling in a shared asset or artifact root.
|
||||
const ascendedOnly = new Set<string>();
|
||||
const queue = [...seedNodeIds];
|
||||
for (let offset = 0; offset < queue.length; offset += 1) {
|
||||
const current = queue[offset];
|
||||
if (current === undefined) continue;
|
||||
const confined = ascendedOnly.has(current);
|
||||
for (const entry of adjacency.get(current) ?? []) {
|
||||
if (confined && !entry.ascends) continue;
|
||||
retainedEdges.set(entry.edge.edge_id, entry.edge);
|
||||
if (visited.has(entry.nextNodeId)) continue;
|
||||
if (!nodeById.has(entry.nextNodeId)) continue;
|
||||
visited.add(entry.nextNodeId);
|
||||
predecessors.set(entry.nextNodeId, {
|
||||
previousNodeId: current,
|
||||
edgeId: entry.edge.edge_id,
|
||||
});
|
||||
queue.push(entry.nextNodeId);
|
||||
const next = entry.nextNodeId;
|
||||
if (!nodeById.has(next)) continue;
|
||||
const nextConfined = confined || entry.ascends;
|
||||
// A node reached only from below is expanded again once it is reached
|
||||
// another way.
|
||||
if (visited.has(next) && (nextConfined || !ascendedOnly.has(next)))
|
||||
continue;
|
||||
if (!visited.has(next)) {
|
||||
visited.add(next);
|
||||
predecessors.set(next, {
|
||||
previousNodeId: current,
|
||||
edgeId: entry.edge.edge_id,
|
||||
});
|
||||
}
|
||||
if (nextConfined) ascendedOnly.add(next);
|
||||
else ascendedOnly.delete(next);
|
||||
queue.push(next);
|
||||
}
|
||||
}
|
||||
return {
|
||||
@@ -73,11 +91,13 @@ const buildAdjacency = (
|
||||
addAdjacency(adjacency, edge.source_node_id, {
|
||||
edge,
|
||||
nextNodeId: edge.target_node_id,
|
||||
ascends: false,
|
||||
});
|
||||
if (direction !== "outgoing")
|
||||
addAdjacency(adjacency, edge.target_node_id, {
|
||||
edge,
|
||||
nextNodeId: edge.source_node_id,
|
||||
ascends: direction === "both" && edge.relation === "contains",
|
||||
});
|
||||
}
|
||||
for (const entries of adjacency.values())
|
||||
|
||||
Reference in new issue
Block a user