mirror of
https://github.com/morluto/rea.git
synced 2026-11-20 13:45:30 +00:00
fix(javascript): retain iterator prototype effects through array spreads (#12563)
* fix(javascript): retain ambient references through array spread * fix(javascript): retain spread aliases to inherited iterator close hooks * fix(javascript): share dense inline array spread layout (#12564) * fix(javascript): share dense inline array spread layout * fix(javascript): report exhausted dense spread layout allowance * fix(javascript): preserve getter receivers through array spread * fix(javascript): guard native array iteration from opaque global code * test(javascript): group spread receiver controls * test(javascript): preserve getter fixture tuple types * fix(javascript): preserve spread slot projections for iterator receivers
This commit is contained in:
1 parent
1a070dee80
commit
7cb3f1090c
20 files changed
+907
-98
No files matched your search
@@ -0,0 +1,172 @@
|
||||
import * as t from "@babel/types";
|
||||
import {
|
||||
javaScriptExpressionWrapperTarget,
|
||||
unwrapJavaScriptExpression,
|
||||
} from "./javascriptAstValues.js";
|
||||
import {
|
||||
ambientPathMayObserveAt,
|
||||
semanticOpaqueGlobalMayHaveChanged,
|
||||
} from "./javascriptSemanticEffectLog.js";
|
||||
import type { JavaScriptSemanticPropertySelection } from "./javascriptSemanticPropertyPaths.js";
|
||||
import type { JavaScriptSemanticAnalysisState } from "./javascriptSemanticState.js";
|
||||
|
||||
/** Shared intrinsic reached through a native array iterator's prototype. */
|
||||
export const semanticArrayIteratorPrototypePath = [
|
||||
"array-iterator-prototype",
|
||||
] as const;
|
||||
const iteratorNextPath = [
|
||||
...semanticArrayIteratorPrototypePath,
|
||||
"next",
|
||||
] as const;
|
||||
|
||||
export const semanticNativeArrayIteratorIntactAt = (
|
||||
state: JavaScriptSemanticAnalysisState,
|
||||
acquisition: t.Node,
|
||||
): boolean =>
|
||||
!state.arrayIterationUnknown &&
|
||||
!semanticOpaqueGlobalMayHaveChanged(acquisition, state) &&
|
||||
!ambientPathMayObserveAt(state, acquisition, iteratorNextPath, "contents");
|
||||
|
||||
type ArrayLiteralSlot = {
|
||||
readonly kind: "slot";
|
||||
readonly element: t.Expression | null;
|
||||
readonly depth: number;
|
||||
};
|
||||
|
||||
type ArrayLiteralPart =
|
||||
| ArrayLiteralSlot
|
||||
| {
|
||||
readonly kind: "opaque-spread";
|
||||
readonly argument: t.Expression;
|
||||
};
|
||||
|
||||
const denseInlineSlots = (
|
||||
spread: t.SpreadElement,
|
||||
state: JavaScriptSemanticAnalysisState,
|
||||
allowance: { remaining: number },
|
||||
): readonly ArrayLiteralSlot[] | undefined => {
|
||||
const takeSelection = (): boolean => {
|
||||
if (allowance.remaining === 0) {
|
||||
state.valueResourceLimits.add("alias-selections");
|
||||
return false;
|
||||
}
|
||||
allowance.remaining--;
|
||||
return true;
|
||||
};
|
||||
const spreadArray = (part: t.SpreadElement) => {
|
||||
const argument = unwrapJavaScriptExpression(part.argument).node;
|
||||
return t.isArrayExpression(argument) &&
|
||||
semanticNativeArrayIteratorIntactAt(state, part)
|
||||
? argument
|
||||
: undefined;
|
||||
};
|
||||
const root = spreadArray(spread);
|
||||
if (root === undefined || !takeSelection()) return undefined;
|
||||
const pending = [{ array: root, index: 0 }];
|
||||
const slots: ArrayLiteralSlot[] = [];
|
||||
while (pending.length > 0) {
|
||||
const frame = pending.at(-1)!;
|
||||
if (frame.index === frame.array.elements.length) {
|
||||
pending.pop();
|
||||
continue;
|
||||
}
|
||||
if (!takeSelection()) return undefined;
|
||||
const element = frame.array.elements[frame.index++]!;
|
||||
if (element === null) return undefined;
|
||||
if (t.isSpreadElement(element)) {
|
||||
const array = spreadArray(element);
|
||||
if (array === undefined) return undefined;
|
||||
pending.push({ array, index: 0 });
|
||||
} else slots.push({ kind: "slot", element, depth: pending.length + 1 });
|
||||
}
|
||||
return slots;
|
||||
};
|
||||
|
||||
/** Source slots in destination order, with unresolved spread positions explicit. */
|
||||
export function* semanticArrayLiteralLayout(
|
||||
root: t.ArrayExpression,
|
||||
state?: JavaScriptSemanticAnalysisState,
|
||||
): IterableIterator<ArrayLiteralPart> {
|
||||
const allowance = { remaining: state?.precision.alias_selections ?? 0 };
|
||||
let opaque = false;
|
||||
for (const element of root.elements) {
|
||||
if (!t.isSpreadElement(element)) {
|
||||
yield { kind: "slot", element, depth: 1 };
|
||||
continue;
|
||||
}
|
||||
const slots =
|
||||
!opaque && state !== undefined
|
||||
? denseInlineSlots(element, state, allowance)
|
||||
: undefined;
|
||||
if (slots !== undefined) yield* slots;
|
||||
else {
|
||||
opaque = true;
|
||||
yield { kind: "opaque-spread", argument: element.argument };
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/** Find where a literal element's identity is stored, including inline copies. */
|
||||
export const semanticArrayLiteralElementOwner = (
|
||||
element: t.Node,
|
||||
array: t.ArrayExpression,
|
||||
state: JavaScriptSemanticAnalysisState,
|
||||
):
|
||||
| {
|
||||
readonly array: t.ArrayExpression;
|
||||
readonly key: number | JavaScriptSemanticPropertySelection;
|
||||
}
|
||||
| undefined => {
|
||||
const { parentsByNode } = state;
|
||||
while (true) {
|
||||
let operand: t.Node = array;
|
||||
let spread = parentsByNode.get(operand);
|
||||
while (
|
||||
spread !== undefined &&
|
||||
javaScriptExpressionWrapperTarget(spread) === operand
|
||||
) {
|
||||
operand = spread;
|
||||
spread = parentsByNode.get(operand);
|
||||
}
|
||||
if (!t.isSpreadElement(spread) || spread.argument !== operand) break;
|
||||
const destination = parentsByNode.get(spread);
|
||||
if (!t.isArrayExpression(destination)) break;
|
||||
array = destination;
|
||||
}
|
||||
let minimumIndex = 0;
|
||||
let uncertainIndex = false;
|
||||
for (const part of semanticArrayLiteralLayout(array, state)) {
|
||||
if (part.kind === "opaque-spread") {
|
||||
uncertainIndex = true;
|
||||
continue;
|
||||
}
|
||||
if (part.element === element)
|
||||
return {
|
||||
array,
|
||||
key: uncertainIndex
|
||||
? { excludedKeys: [], startIndex: minimumIndex }
|
||||
: minimumIndex,
|
||||
};
|
||||
minimumIndex++;
|
||||
}
|
||||
return undefined;
|
||||
};
|
||||
|
||||
/** A complete index for consumers that need repeated lookups in one query. */
|
||||
export const semanticArrayLiteralSlots = (
|
||||
root: t.ArrayExpression,
|
||||
state: JavaScriptSemanticAnalysisState,
|
||||
): readonly (t.Expression | null)[] | undefined => {
|
||||
if (
|
||||
root.elements.every(
|
||||
(element): element is t.Expression | null => !t.isSpreadElement(element),
|
||||
)
|
||||
)
|
||||
return root.elements;
|
||||
const slots: (t.Expression | null)[] = [];
|
||||
for (const part of semanticArrayLiteralLayout(root, state)) {
|
||||
if (part.kind === "opaque-spread") return undefined;
|
||||
slots.push(part.element);
|
||||
}
|
||||
return slots;
|
||||
};
|
||||
Reference in new issue
Block a user