mirror of
https://github.com/morluto/rea.git
synced 2026-11-21 06:04:03 +00:00
feat(managed): retain unresolved definition coordinates (#12462)
* feat(managed): retain unresolved definition coordinates * fix(managed): describe unresolved definition scope in summaries * test(managed): isolate the selected coordinate fixture * test(managed): use owned member scope guidance * test(managed): use historical evidence for unknown method scope --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This commit is contained in:
1 parent
18c8b957f8
commit
7df462cbfa
21 files changed
+656
-39
No files matched your search
@@ -3,7 +3,15 @@ import { join } from "node:path";
|
||||
import { expect } from "vitest";
|
||||
|
||||
import { parseEvidence } from "../../src/domain/evidence.js";
|
||||
import { managedMemberSummaryViewResultSchema } from "../../src/domain/analysisView/analysisViewResult.js";
|
||||
import { MANAGED_MEMBER_SCOPE_GUIDANCE } from "../../src/domain/analysisView/managedMemberView.js";
|
||||
import { managedMemberInspectionSchema } from "../../src/domain/managed/managedArtifact.js";
|
||||
import {
|
||||
metadataRowOffset,
|
||||
readManagedMetadataLayout,
|
||||
} from "../../src/domain/managed/managedMetadataLayout.js";
|
||||
import { readManagedPeLayout } from "../../src/domain/managed/managedPeReader.js";
|
||||
import { buildManagedPeFixture } from "../../src/dotnet/ManagedPe.fixture.js";
|
||||
import {
|
||||
managedStringsAmbiguity,
|
||||
STRING_AMBIGUITY_MVID,
|
||||
@@ -11,8 +19,22 @@ import {
|
||||
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
|
||||
import { cliTest } from "../support/cli/cliFixture.js";
|
||||
|
||||
const buildSelectedCoordinateFixture = (): Buffer => {
|
||||
const bytes = buildManagedPeFixture({ additionalEmptyTypes: 1 });
|
||||
const pe = readManagedPeLayout(bytes);
|
||||
if (pe.cli === null) throw new Error("Fixture omitted CLI metadata");
|
||||
const { rva, size } = pe.cli.metadata;
|
||||
const layout = readManagedMetadataLayout(
|
||||
bytes,
|
||||
pe.rvaToOffset(rva, size, "fixture"),
|
||||
size,
|
||||
);
|
||||
bytes.writeUInt16LE(0, metadataRowOffset(layout, 2, 1) + 4);
|
||||
return bytes;
|
||||
};
|
||||
|
||||
cliTest(
|
||||
"retains unnamed Module identity through CLI, MCP and a retained member page",
|
||||
"retains unresolved Module and definition facts through CLI, MCP and retained pages",
|
||||
async ({ cli }) => {
|
||||
const root = await createTestTempDirectory("rea-managed-module-name-");
|
||||
const path = join(root, "fixture.dll");
|
||||
@@ -37,15 +59,78 @@ cliTest(
|
||||
},
|
||||
identity_scope: { requires_mvid: STRING_AMBIGUITY_MVID },
|
||||
});
|
||||
const type = {
|
||||
kind: "TypeDef",
|
||||
token: "0x02000001",
|
||||
row_offset: 964,
|
||||
failed_fields: [
|
||||
{
|
||||
field: "Name",
|
||||
field_offset: 968,
|
||||
heap_index: bytes.readUInt16LE(968),
|
||||
reason: "ambiguous-string-heap",
|
||||
},
|
||||
{
|
||||
field: "Namespace",
|
||||
field_offset: 970,
|
||||
heap_index: bytes.readUInt16LE(970),
|
||||
reason: "ambiguous-string-heap",
|
||||
},
|
||||
],
|
||||
};
|
||||
const method = {
|
||||
kind: "MethodDef",
|
||||
token: "0x06000001",
|
||||
row_offset: 984,
|
||||
declaring_type_token: "0x02000001",
|
||||
rva: 10240,
|
||||
failed_fields: [
|
||||
{
|
||||
field: "Name",
|
||||
field_offset: 992,
|
||||
heap_index: bytes.readUInt16LE(992),
|
||||
reason: "ambiguous-string-heap",
|
||||
},
|
||||
],
|
||||
};
|
||||
expect(report.unresolved_definitions).toEqual({
|
||||
rows: [type, method],
|
||||
method_names_examined: true,
|
||||
});
|
||||
|
||||
const call = await cli.sharedMcpCall!();
|
||||
const mcp = await call("inspect_managed_members", { path });
|
||||
expect(mcp.isError, JSON.stringify(mcp)).not.toBe(true);
|
||||
const parent = parseEvidence(mcp.structuredContent);
|
||||
expect(parent.normalized_result).toEqual(report);
|
||||
const source = {
|
||||
kind: "retained-evidence",
|
||||
evidence_id: parent.evidence_id,
|
||||
};
|
||||
|
||||
for (const [offset, item] of [type, method].entries()) {
|
||||
const coordinates = await call("inspect_analysis_view", {
|
||||
source,
|
||||
view: {
|
||||
kind: "managed-members",
|
||||
collection: "unresolved_definitions",
|
||||
offset,
|
||||
limit: 1,
|
||||
},
|
||||
});
|
||||
expect(coordinates.isError, JSON.stringify(coordinates)).not.toBe(true);
|
||||
expect(
|
||||
parseEvidence(coordinates.structuredContent).normalized_result,
|
||||
).toMatchObject({
|
||||
parent_evidence_id: parent.evidence_id,
|
||||
source_metadata_status: "partial",
|
||||
unresolved_method_names_examined: true,
|
||||
page: { collection: "unresolved_definitions", rows: [item] },
|
||||
});
|
||||
}
|
||||
|
||||
const page = await call("inspect_analysis_view", {
|
||||
source: { kind: "retained-evidence", evidence_id: parent.evidence_id },
|
||||
source,
|
||||
view: { kind: "managed-members", collection: "methods", limit: 1 },
|
||||
});
|
||||
expect(page.isError, JSON.stringify(page)).not.toBe(true);
|
||||
@@ -56,5 +141,50 @@ cliTest(
|
||||
unresolved_module_name: report.metadata.unresolved_module_name,
|
||||
identity_scope: report.identity_scope,
|
||||
});
|
||||
|
||||
const selectedPath = join(root, "selected.dll");
|
||||
await writeFile(selectedPath, buildSelectedCoordinateFixture());
|
||||
const selected = await call("inspect_managed_members", {
|
||||
path: selectedPath,
|
||||
type_names: ["Fixture.Program"],
|
||||
detail: "summary",
|
||||
});
|
||||
expect(selected.isError, JSON.stringify(selected)).not.toBe(true);
|
||||
const scope = [
|
||||
MANAGED_MEMBER_SCOPE_GUIDANCE.selectedNominalRows,
|
||||
MANAGED_MEMBER_SCOPE_GUIDANCE.unresolvedTypeRows,
|
||||
MANAGED_MEMBER_SCOPE_GUIDANCE.unresolvedMethodRows,
|
||||
];
|
||||
const result = managedMemberSummaryViewResultSchema.parse(
|
||||
parseEvidence(selected.structuredContent).normalized_result,
|
||||
);
|
||||
expect(result).toMatchObject({
|
||||
summary: {
|
||||
selection: {
|
||||
type_names: ["Fixture.Program"],
|
||||
unmatched_type_names: [],
|
||||
},
|
||||
reported_counts: { types: 1, unresolved_definitions: 1 },
|
||||
},
|
||||
unknowns: expect.arrayContaining(scope),
|
||||
});
|
||||
const selectedPage = await call("inspect_analysis_view", {
|
||||
source: {
|
||||
kind: "retained-evidence",
|
||||
evidence_id: result.parent_evidence_id,
|
||||
},
|
||||
view: {
|
||||
kind: "managed-members",
|
||||
collection: "unresolved_definitions",
|
||||
limit: 1,
|
||||
},
|
||||
});
|
||||
expect(selectedPage.isError, JSON.stringify(selectedPage)).not.toBe(true);
|
||||
expect(
|
||||
parseEvidence(selectedPage.structuredContent).normalized_result,
|
||||
).toMatchObject({
|
||||
page: { rows: [{ kind: "TypeDef", token: "0x02000001" }] },
|
||||
unknowns: result.unknowns,
|
||||
});
|
||||
},
|
||||
);
|
||||
Reference in new issue
Block a user