mirror of
https://github.com/morluto/rea.git
synced 2026-11-18 20:53:00 +00:00
fix(reference): preserve incomplete resolution uncertainty
This commit is contained in:
1 parent
54fbfacfb1
commit
838f5f44d2
2 files changed
+286
-3
No files matched your search
@@ -364,3 +364,176 @@ it("resolves extensionless imports and requires to .mts and .cts files and direc
|
||||
]),
|
||||
);
|
||||
});
|
||||
|
||||
it("does not infer missing candidates or manifests from partial directory enumeration", () => {
|
||||
const file = (
|
||||
path: string,
|
||||
content: string,
|
||||
): ReferenceSourceRead["entries"][number] => ({
|
||||
status: "read",
|
||||
kind: "file",
|
||||
path,
|
||||
bytes: Buffer.from(content),
|
||||
size: Buffer.byteLength(content),
|
||||
});
|
||||
const read: ReferenceSourceRead = {
|
||||
root: "/selected/source",
|
||||
bytesRead: 0,
|
||||
limitations: [],
|
||||
entries: [
|
||||
file("package.json", '{"type":"commonjs"}'),
|
||||
file(
|
||||
"main.cjs",
|
||||
'require("./pkg"); require("./other"); require("./exact.js");',
|
||||
),
|
||||
file("pkg/index.js", "module.exports = 1;"),
|
||||
file("other/index.js", "module.exports = 1;"),
|
||||
file("exact.js", "module.exports = 1;"),
|
||||
file("pkg/source.js", 'require("../exact.js");'),
|
||||
{
|
||||
status: "failed",
|
||||
kind: "directory",
|
||||
path: "pkg",
|
||||
code: "io",
|
||||
message: "Partial enumeration",
|
||||
},
|
||||
{ status: "read", kind: "directory", path: "other" },
|
||||
],
|
||||
};
|
||||
const parsed = parseReferenceSourceEntries(read, []);
|
||||
expect(
|
||||
parsed.relationships.filter(({ from_path }) => from_path === "main.cjs"),
|
||||
).toEqual([
|
||||
expect.objectContaining({ to: "pkg", resolution: "unresolved" }),
|
||||
expect.objectContaining({ to: "other/index.js", resolution: "internal" }),
|
||||
expect.objectContaining({ to: "exact.js", resolution: "internal" }),
|
||||
]);
|
||||
expect(
|
||||
parsed.relationships.filter(
|
||||
({ from_path }) => from_path === "pkg/source.js",
|
||||
),
|
||||
).not.toContainEqual(expect.objectContaining({ resolution: "internal" }));
|
||||
const partialRoot = parseReferenceSourceEntries(
|
||||
{ ...read, rootFailure: { code: "io", message: "Partial root" } },
|
||||
[],
|
||||
);
|
||||
expect(
|
||||
partialRoot.relationships.find(
|
||||
({ from_path, to }) =>
|
||||
from_path === "main.cjs" && to === "other/index.js",
|
||||
),
|
||||
).toBeUndefined();
|
||||
expect(partialRoot.relationships).toContainEqual(
|
||||
expect.objectContaining({
|
||||
from_path: "main.cjs",
|
||||
to: "exact.js",
|
||||
resolution: "internal",
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it.each(["failed", "excluded"] as const)(
|
||||
"keeps higher priority %s candidates unknown",
|
||||
(state) => {
|
||||
const files = [
|
||||
["main.cjs", 'require("./pkg"); require("./pkg/index.js");'],
|
||||
["pkg/index.js", "module.exports = 1;"],
|
||||
] as const;
|
||||
const read: ReferenceSourceRead = {
|
||||
root: "/selected/source",
|
||||
bytesRead: 0,
|
||||
limitations: [],
|
||||
entries: [
|
||||
...files.map(([path, content]) => ({
|
||||
status: "read" as const,
|
||||
kind: "file" as const,
|
||||
path,
|
||||
bytes: Buffer.from(content),
|
||||
size: Buffer.byteLength(content),
|
||||
})),
|
||||
...(state === "failed"
|
||||
? [
|
||||
{
|
||||
status: "failed" as const,
|
||||
kind: "file" as const,
|
||||
path: "pkg.js",
|
||||
code: "io" as const,
|
||||
message: "Unreadable",
|
||||
},
|
||||
]
|
||||
: []),
|
||||
],
|
||||
};
|
||||
const parsed = parseReferenceSourceEntries(
|
||||
read,
|
||||
state === "excluded"
|
||||
? [
|
||||
{
|
||||
path: "pkg.js",
|
||||
entry_kind: "file",
|
||||
reason: "caller-excluded",
|
||||
pattern: "pkg.js",
|
||||
},
|
||||
]
|
||||
: [],
|
||||
);
|
||||
expect(parsed.relationships).toEqual([
|
||||
expect.objectContaining({ to: "pkg", resolution: "unresolved" }),
|
||||
expect.objectContaining({ to: "pkg/index.js", resolution: "internal" }),
|
||||
]);
|
||||
},
|
||||
);
|
||||
|
||||
it("retains observed manifests and closer completed scopes inside a partial inventory", () => {
|
||||
const files = [
|
||||
["main.cjs", 'require("./pkg");'],
|
||||
["pkg/package.json", '{"main":"entry.js","type":"commonjs"}'],
|
||||
["pkg/entry.js", 'require("./known.js");'],
|
||||
["pkg/known.js", "module.exports = 1;"],
|
||||
["complete/source.js", 'require("./known.js");'],
|
||||
["complete/known.js", "module.exports = 1;"],
|
||||
["complete/package.json", '{"type":"commonjs"}'],
|
||||
] as const;
|
||||
const parsed = parseReferenceSourceEntries(
|
||||
{
|
||||
root: "/selected/source",
|
||||
bytesRead: 0,
|
||||
limitations: [],
|
||||
entries: [
|
||||
...files.map(([path, content]) => ({
|
||||
status: "read" as const,
|
||||
kind: "file" as const,
|
||||
path,
|
||||
bytes: Buffer.from(content),
|
||||
size: Buffer.byteLength(content),
|
||||
})),
|
||||
{
|
||||
status: "failed",
|
||||
kind: "directory",
|
||||
path: "pkg",
|
||||
code: "io",
|
||||
message: "Partial enumeration",
|
||||
},
|
||||
{ status: "read", kind: "directory", path: "complete" },
|
||||
],
|
||||
},
|
||||
[],
|
||||
);
|
||||
expect(parsed.relationships).toEqual([
|
||||
expect.objectContaining({
|
||||
from_path: "main.cjs",
|
||||
to: "pkg/entry.js",
|
||||
resolution: "internal",
|
||||
}),
|
||||
expect.objectContaining({
|
||||
from_path: "pkg/entry.js",
|
||||
to: "pkg/known.js",
|
||||
resolution: "internal",
|
||||
}),
|
||||
expect.objectContaining({
|
||||
from_path: "complete/source.js",
|
||||
to: "complete/known.js",
|
||||
resolution: "internal",
|
||||
}),
|
||||
]);
|
||||
});
|
||||
Reference in new issue
Block a user