From 8e11a430cf3d460e232b74f9ad6fc1601b7490e8 Mon Sep 17 00:00:00 2001 From: N0zoM1z0 <161784452+N0zoM1z0@users.noreply.github.com> Date: Wed, 11 Nov 2026 08:46:29 +0000 Subject: [PATCH] fix(reference): scope missing directory targets before retaining their suffix Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com> --- src/reference/ReferenceSourceReaderEntries.ts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/reference/ReferenceSourceReaderEntries.ts b/src/reference/ReferenceSourceReaderEntries.ts index 163268f63c..38f7bd67a5 100644 --- a/src/reference/ReferenceSourceReaderEntries.ts +++ b/src/reference/ReferenceSourceReaderEntries.ts @@ -488,7 +488,7 @@ const readSymlinkTarget = async ( status: "read", kind: "symlink", path, - target: await missingSymlinkPath(root, nativeTarget), + target: await missingSymlinkPath(root, nativeTarget, code === "ENOENT"), targetState: "missing", }; } @@ -506,6 +506,7 @@ const readSymlinkTarget = async ( const missingSymlinkPath = async ( root: string, target: string, + missingFinalComponent: boolean, ): Promise => { if (basename(target) === "..") return target; let parent: string; @@ -519,11 +520,11 @@ const missingSymlinkPath = async ( throw cause; } const candidate = appendCallerPath(parent, basename(target)); - // A trailing separator requires a directory; relative() would erase it. - if (target.endsWith(sep)) return `${candidate}${sep}`; - return isPathWithinRoot(root, candidate) - ? pathFromRoot(root, candidate) - : candidate; + const directoryRequired = target.endsWith(sep); + if (directoryRequired && !missingFinalComponent) return `${candidate}${sep}`; + const internal = isPathWithinRoot(root, candidate); + const scoped = internal ? pathFromRoot(root, candidate) : candidate; + return directoryRequired ? `${scoped}${internal ? "/" : sep}` : scoped; }; const applyExclusion = (