mirror of
https://github.com/morluto/rea.git
synced 2026-11-21 14:05:49 +00:00
fix(javascript): retain array-pattern iterator close effects (#12534)
* fix(javascript): retain array-pattern iterator close effects * fix(javascript): bound array-pattern close exposure * fix(javascript): follow stored array elements at iterator close * fix(javascript): retain iterator closes before array rest
This commit is contained in:
1 parent
756f772430
commit
8ef5a34ff5
9 files changed
+601
-49
No files matched your search
@@ -1,7 +1,8 @@
|
||||
import type * as t from "@babel/types";
|
||||
import * as t from "@babel/types";
|
||||
import type { JavaScriptSemanticAnalysisState } from "./javascriptSemanticState.js";
|
||||
import {
|
||||
semanticArrayIndex,
|
||||
type JavaScriptSemanticPropertySelection,
|
||||
type JavaScriptSemanticPropertyPath as PropertyPath,
|
||||
} from "./javascriptSemanticPropertyPaths.js";
|
||||
import {
|
||||
@@ -53,6 +54,68 @@ export const semanticKnownArrayIteration = (
|
||||
!ambientPathMayObserveAt(state, read, arrayIteratorNextPath, "contents") &&
|
||||
value.items.every((item) => semanticArrayIndex(item.name) !== null);
|
||||
|
||||
const arrayIteratorReturnPaths = [
|
||||
[...semanticArrayIteratorPrototypePath, "return"],
|
||||
[...semanticArrayIteratorPrototypePath, "__proto__", "return"],
|
||||
[...semanticArrayIteratorPrototypePath, "__proto__", "__proto__", "return"],
|
||||
["global", "Iterator", "prototype", "return"],
|
||||
["global", "Object", "prototype", "return"],
|
||||
] as const;
|
||||
|
||||
/** References a possible native close hook can still obtain by advancing its iterator. */
|
||||
export const semanticArrayPatternCloseSelection = (
|
||||
pattern: t.ArrayPattern,
|
||||
owner: t.Node | undefined,
|
||||
array: Extract<JavaScriptSemanticValue, { status: "array" }>,
|
||||
state: JavaScriptSemanticAnalysisState,
|
||||
): JavaScriptSemanticPropertySelection | undefined => {
|
||||
if (
|
||||
!arrayIteratorReturnPaths.some((path) =>
|
||||
ambientPathMayObserveAt(state, pattern, path, "contents"),
|
||||
)
|
||||
)
|
||||
return undefined;
|
||||
const declaration =
|
||||
owner === undefined ? undefined : state.parentsByNode.get(owner);
|
||||
const last = pattern.elements.at(-1);
|
||||
const hasRest = t.isRestElement(last);
|
||||
let consumed = 0;
|
||||
if (
|
||||
t.isVariableDeclarator(owner) &&
|
||||
t.isVariableDeclaration(declaration) &&
|
||||
(declaration.kind === "const" || declaration.kind === "let")
|
||||
) {
|
||||
for (const [index, element] of pattern.elements.entries()) {
|
||||
// A lexical rest drains the iterator only after earlier pattern work
|
||||
// reaches it. A preceding default or nested binding can throw first.
|
||||
if (hasRest && element === last) return undefined;
|
||||
const slot = array.items[index];
|
||||
const ownSlot =
|
||||
consumed === index &&
|
||||
slot?.name === String(index) &&
|
||||
slot.presence === "present";
|
||||
if (
|
||||
element !== null &&
|
||||
!t.isIdentifier(element) &&
|
||||
!(
|
||||
hasRest &&
|
||||
owner.id === pattern &&
|
||||
ownSlot &&
|
||||
t.isAssignmentPattern(element) &&
|
||||
t.isIdentifier(element.left) &&
|
||||
semanticValueDefinitelyDefined(slot.value)
|
||||
)
|
||||
)
|
||||
break;
|
||||
if (ownSlot) consumed += 1;
|
||||
else if (!hasRest) break;
|
||||
}
|
||||
}
|
||||
// The literal suffix can be empty while the iterator still has references
|
||||
// from stored writes. Resolve those separately at the close site.
|
||||
return { excludedKeys: [], startIndex: consumed };
|
||||
};
|
||||
|
||||
/** Invocation spreads use the same native-iteration proof at their source read. */
|
||||
export const semanticKnownArrayIterationAt = (
|
||||
node: t.Node,
|
||||
|
||||
Reference in new issue
Block a user